[INFO] updating cached repository jfgreen/rusty-boids [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jfgreen/rusty-boids [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jfgreen/rusty-boids" "work/ex/clippy-test-run/sources/stable/gh/jfgreen/rusty-boids"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jfgreen/rusty-boids'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jfgreen/rusty-boids" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jfgreen/rusty-boids"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jfgreen/rusty-boids'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 89d394789b8dd195188118c3528f004dbbde43d7 [INFO] sha for GitHub repo jfgreen/rusty-boids: 89d394789b8dd195188118c3528f004dbbde43d7 [INFO] validating manifest of jfgreen/rusty-boids on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jfgreen/rusty-boids on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jfgreen/rusty-boids [INFO] finished frobbing jfgreen/rusty-boids [INFO] frobbed toml for jfgreen/rusty-boids written to work/ex/clippy-test-run/sources/stable/gh/jfgreen/rusty-boids/Cargo.toml [INFO] started frobbing jfgreen/rusty-boids [INFO] finished frobbing jfgreen/rusty-boids [INFO] frobbed toml for jfgreen/rusty-boids written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jfgreen/rusty-boids/Cargo.toml [INFO] crate jfgreen/rusty-boids has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jfgreen/rusty-boids against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jfgreen/rusty-boids:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dfdfff8a4690e3efe4327b72c8ed28b3c947e758ed20bcda3480ff068f381931 [INFO] running `"docker" "start" "-a" "dfdfff8a4690e3efe4327b72c8ed28b3c947e758ed20bcda3480ff068f381931"` [INFO] [stderr] Checking clap v2.31.2 [INFO] [stderr] Compiling gl_generator v0.6.1 [INFO] [stderr] Compiling gl_generator v0.8.0 [INFO] [stderr] Compiling syn v0.13.4 [INFO] [stderr] Checking cgmath v0.15.0 [INFO] [stderr] Checking wayland-window v0.13.3 [INFO] [stderr] Checking winit v0.10.0 [INFO] [stderr] Compiling glutin v0.12.2 [INFO] [stderr] Compiling gl v0.6.5 [INFO] [stderr] Compiling serde_derive_internals v0.23.1 [INFO] [stderr] Compiling serde_derive v1.0.45 [INFO] [stderr] Checking rust-boids v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/boids.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/boids.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/boids.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/boids.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/glx.rs:153:17 [INFO] [stderr] | [INFO] [stderr] 153 | program_id: program_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `program_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:26:24 [INFO] [stderr] | [INFO] [stderr] 26 | println!("{}", "Failure building configuration:"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:31:24 [INFO] [stderr] | [INFO] [stderr] 31 | println!("{}", "Failure running simulation"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/boids.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/boids.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/boids.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/boids.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/glx.rs:153:17 [INFO] [stderr] | [INFO] [stderr] 153 | program_id: program_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `program_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:26:24 [INFO] [stderr] | [INFO] [stderr] 26 | println!("{}", "Failure building configuration:"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:31:24 [INFO] [stderr] | [INFO] [stderr] 31 | println!("{}", "Failure running simulation"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/boids.rs:14:15 [INFO] [stderr] | [INFO] [stderr] 14 | const TITLE: &'static str = "rusty-boids"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/fps.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | 1000_000_000 / dt.subsec_nanos() [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/boids.rs:14:15 [INFO] [stderr] | [INFO] [stderr] 14 | const TITLE: &'static str = "rusty-boids"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/fps.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | 1000_000_000 / dt.subsec_nanos() [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/boids.rs:115:10 [INFO] [stderr] | [INFO] [stderr] 115 | .ok_or(SimulatorError::Window( [INFO] [stderr] | __________^ [INFO] [stderr] 116 | | "Tried to get size of closed window".to_string(), [INFO] [stderr] 117 | | ))?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 115 | .ok_or_else(|| SimulatorError::Window( [INFO] [stderr] 116 | "Tried to get size of closed window".to_string(), [INFO] [stderr] 117 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/boids.rs:252:26 [INFO] [stderr] | [INFO] [stderr] 252 | let window_builder = match window_size { [INFO] [stderr] | __________________________^ [INFO] [stderr] 253 | | &WindowSize::Fullscreen => { [INFO] [stderr] 254 | | let screen = Some(events_loop.get_primary_monitor()); [INFO] [stderr] 255 | | window_builder.with_fullscreen(screen) [INFO] [stderr] 256 | | } [INFO] [stderr] 257 | | &WindowSize::Dimensions((width, height)) => window_builder.with_dimensions(width, height), [INFO] [stderr] 258 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 252 | let window_builder = match *window_size { [INFO] [stderr] 253 | WindowSize::Fullscreen => { [INFO] [stderr] 254 | let screen = Some(events_loop.get_primary_monitor()); [INFO] [stderr] 255 | window_builder.with_fullscreen(screen) [INFO] [stderr] 256 | } [INFO] [stderr] 257 | WindowSize::Dimensions((width, height)) => window_builder.with_dimensions(width, height), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/glx.rs:213:22 [INFO] [stderr] | [INFO] [stderr] 213 | let mut status = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/glx.rs:217:18 [INFO] [stderr] | [INFO] [stderr] 217 | if status != (gl::TRUE as GLint) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/glx.rs:247:22 [INFO] [stderr] | [INFO] [stderr] 247 | let mut status = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/glx.rs:251:18 [INFO] [stderr] | [INFO] [stderr] 251 | if status != (gl::TRUE as GLint) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/boids.rs:115:10 [INFO] [stderr] | [INFO] [stderr] 115 | .ok_or(SimulatorError::Window( [INFO] [stderr] | __________^ [INFO] [stderr] 116 | | "Tried to get size of closed window".to_string(), [INFO] [stderr] 117 | | ))?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 115 | .ok_or_else(|| SimulatorError::Window( [INFO] [stderr] 116 | "Tried to get size of closed window".to_string(), [INFO] [stderr] 117 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/boids.rs:252:26 [INFO] [stderr] | [INFO] [stderr] 252 | let window_builder = match window_size { [INFO] [stderr] | __________________________^ [INFO] [stderr] 253 | | &WindowSize::Fullscreen => { [INFO] [stderr] 254 | | let screen = Some(events_loop.get_primary_monitor()); [INFO] [stderr] 255 | | window_builder.with_fullscreen(screen) [INFO] [stderr] 256 | | } [INFO] [stderr] 257 | | &WindowSize::Dimensions((width, height)) => window_builder.with_dimensions(width, height), [INFO] [stderr] 258 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 252 | let window_builder = match *window_size { [INFO] [stderr] 253 | WindowSize::Fullscreen => { [INFO] [stderr] 254 | let screen = Some(events_loop.get_primary_monitor()); [INFO] [stderr] 255 | window_builder.with_fullscreen(screen) [INFO] [stderr] 256 | } [INFO] [stderr] 257 | WindowSize::Dimensions((width, height)) => window_builder.with_dimensions(width, height), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/glx.rs:213:22 [INFO] [stderr] | [INFO] [stderr] 213 | let mut status = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/glx.rs:217:18 [INFO] [stderr] | [INFO] [stderr] 217 | if status != (gl::TRUE as GLint) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/glx.rs:247:22 [INFO] [stderr] | [INFO] [stderr] 247 | let mut status = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/glx.rs:251:18 [INFO] [stderr] | [INFO] [stderr] 251 | if status != (gl::TRUE as GLint) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 30.99s [INFO] running `"docker" "inspect" "dfdfff8a4690e3efe4327b72c8ed28b3c947e758ed20bcda3480ff068f381931"` [INFO] running `"docker" "rm" "-f" "dfdfff8a4690e3efe4327b72c8ed28b3c947e758ed20bcda3480ff068f381931"` [INFO] [stdout] dfdfff8a4690e3efe4327b72c8ed28b3c947e758ed20bcda3480ff068f381931