[INFO] updating cached repository jeysal/rust-uml-to-dot-concept [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jeysal/rust-uml-to-dot-concept [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jeysal/rust-uml-to-dot-concept" "work/ex/clippy-test-run/sources/stable/gh/jeysal/rust-uml-to-dot-concept"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jeysal/rust-uml-to-dot-concept'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jeysal/rust-uml-to-dot-concept" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jeysal/rust-uml-to-dot-concept"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jeysal/rust-uml-to-dot-concept'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8d075805c4eec603906cc1909b04eafa35f40101 [INFO] sha for GitHub repo jeysal/rust-uml-to-dot-concept: 8d075805c4eec603906cc1909b04eafa35f40101 [INFO] validating manifest of jeysal/rust-uml-to-dot-concept on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jeysal/rust-uml-to-dot-concept on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jeysal/rust-uml-to-dot-concept [INFO] finished frobbing jeysal/rust-uml-to-dot-concept [INFO] frobbed toml for jeysal/rust-uml-to-dot-concept written to work/ex/clippy-test-run/sources/stable/gh/jeysal/rust-uml-to-dot-concept/Cargo.toml [INFO] started frobbing jeysal/rust-uml-to-dot-concept [INFO] finished frobbing jeysal/rust-uml-to-dot-concept [INFO] frobbed toml for jeysal/rust-uml-to-dot-concept written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jeysal/rust-uml-to-dot-concept/Cargo.toml [INFO] crate jeysal/rust-uml-to-dot-concept has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jeysal/rust-uml-to-dot-concept against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jeysal/rust-uml-to-dot-concept:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a3db65145707b040b607004249ab46756460aee5d70b1423e09e0c05316b47f0 [INFO] running `"docker" "start" "-a" "a3db65145707b040b607004249ab46756460aee5d70b1423e09e0c05316b47f0"` [INFO] [stderr] Checking dot v0.1.4 [INFO] [stderr] Checking uml v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/diagram.rs:51:44 [INFO] [stderr] | [INFO] [stderr] 51 | let known_class_names: HashSet<&str> = declared_class_names [INFO] [stderr] | ____________________________________________^ [INFO] [stderr] 52 | | .union(&superclass_names) [INFO] [stderr] 53 | | .map(|name| name.clone()) [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 51 | let known_class_names: HashSet<&str> = declared_class_names [INFO] [stderr] 52 | .union(&superclass_names).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/diagram.rs:53:19 [INFO] [stderr] | [INFO] [stderr] 53 | .map(|name| name.clone()) [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 53 | .map(|name| &(*name).clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 53 | .map(|name| &str::clone(name)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/diagram.rs:116:24 [INFO] [stderr] | [INFO] [stderr] 116 | let source = class_map.get(class_name).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&class_map[class_name]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/diagram.rs:139:30 [INFO] [stderr] | [INFO] [stderr] 139 | let target = class_map.get(superclass).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&class_map[superclass]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/dot.rs:23:8 [INFO] [stderr] | [INFO] [stderr] 23 | .expect(format!("Invalid class name: '{}'", class.name).as_str()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Invalid class name: '{}'", class.name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `uml`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/diagram.rs:51:44 [INFO] [stderr] | [INFO] [stderr] 51 | let known_class_names: HashSet<&str> = declared_class_names [INFO] [stderr] | ____________________________________________^ [INFO] [stderr] 52 | | .union(&superclass_names) [INFO] [stderr] 53 | | .map(|name| name.clone()) [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 51 | let known_class_names: HashSet<&str> = declared_class_names [INFO] [stderr] 52 | .union(&superclass_names).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/diagram.rs:53:19 [INFO] [stderr] | [INFO] [stderr] 53 | .map(|name| name.clone()) [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 53 | .map(|name| &(*name).clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 53 | .map(|name| &str::clone(name)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/diagram.rs:116:24 [INFO] [stderr] | [INFO] [stderr] 116 | let source = class_map.get(class_name).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&class_map[class_name]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/diagram.rs:139:30 [INFO] [stderr] | [INFO] [stderr] 139 | let target = class_map.get(superclass).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&class_map[superclass]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/dot.rs:23:8 [INFO] [stderr] | [INFO] [stderr] 23 | .expect(format!("Invalid class name: '{}'", class.name).as_str()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Invalid class name: '{}'", class.name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `uml`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "a3db65145707b040b607004249ab46756460aee5d70b1423e09e0c05316b47f0"` [INFO] running `"docker" "rm" "-f" "a3db65145707b040b607004249ab46756460aee5d70b1423e09e0c05316b47f0"` [INFO] [stdout] a3db65145707b040b607004249ab46756460aee5d70b1423e09e0c05316b47f0