[INFO] updating cached repository jesskfullwood/hyper-proxy-bug [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jesskfullwood/hyper-proxy-bug [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jesskfullwood/hyper-proxy-bug" "work/ex/clippy-test-run/sources/stable/gh/jesskfullwood/hyper-proxy-bug"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jesskfullwood/hyper-proxy-bug'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jesskfullwood/hyper-proxy-bug" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jesskfullwood/hyper-proxy-bug"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jesskfullwood/hyper-proxy-bug'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9b0afd0023b69c8fd1635da0a99513a8ac586d2e [INFO] sha for GitHub repo jesskfullwood/hyper-proxy-bug: 9b0afd0023b69c8fd1635da0a99513a8ac586d2e [INFO] validating manifest of jesskfullwood/hyper-proxy-bug on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jesskfullwood/hyper-proxy-bug on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jesskfullwood/hyper-proxy-bug [INFO] finished frobbing jesskfullwood/hyper-proxy-bug [INFO] frobbed toml for jesskfullwood/hyper-proxy-bug written to work/ex/clippy-test-run/sources/stable/gh/jesskfullwood/hyper-proxy-bug/Cargo.toml [INFO] started frobbing jesskfullwood/hyper-proxy-bug [INFO] finished frobbing jesskfullwood/hyper-proxy-bug [INFO] frobbed toml for jesskfullwood/hyper-proxy-bug written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jesskfullwood/hyper-proxy-bug/Cargo.toml [INFO] crate jesskfullwood/hyper-proxy-bug has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jesskfullwood/hyper-proxy-bug against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jesskfullwood/hyper-proxy-bug:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2cac225a7247323d5da3756f60d2d0fa94a4b872b484657f9d33053d3483e9bc [INFO] running `"docker" "start" "-a" "2cac225a7247323d5da3756f60d2d0fa94a4b872b484657f9d33053d3483e9bc"` [INFO] [stderr] Compiling native-tls v0.2.0 [INFO] [stderr] Checking heck v0.3.0 [INFO] [stderr] Checking want v0.0.6 [INFO] [stderr] Checking http v0.1.10 [INFO] [stderr] Checking ring v0.13.2 [INFO] [stderr] Compiling syn v0.14.4 [INFO] [stderr] Checking regex v1.0.1 [INFO] [stderr] Compiling configure_derive v0.1.1 [INFO] [stderr] Checking erased-serde v0.3.3 [INFO] [stderr] Checking tokio-threadpool v0.1.5 [INFO] [stderr] Checking openssl v0.10.10 [INFO] [stderr] Checking tokio-tcp v0.1.1 [INFO] [stderr] Checking webpki v0.18.1 [INFO] [stderr] Checking sct v0.4.0 [INFO] [stderr] Checking configure v0.1.1 [INFO] [stderr] Checking tokio-fs v0.1.2 [INFO] [stderr] Checking rustls v0.13.0 [INFO] [stderr] Checking env_logger v0.5.12 [INFO] [stderr] Checking tokio v0.1.7 [INFO] [stderr] Compiling structopt-derive v0.2.10 [INFO] [stderr] Checking h2 v0.1.10 [INFO] [stderr] Checking tokio-rustls v0.7.1 [INFO] [stderr] Checking structopt v0.2.10 [INFO] [stderr] Checking hyper v0.12.8 [INFO] [stderr] Checking hyper-tls v0.3.0 [INFO] [stderr] Checking hyper-proxy v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/main.rs:115:12 [INFO] [stderr] | [INFO] [stderr] 115 | if let None = parts.path_and_query { [INFO] [stderr] | _____- ^^^^ [INFO] [stderr] 116 | | parts.path_and_query = Some(uri::PathAndQuery::from_static("/")); [INFO] [stderr] 117 | | } [INFO] [stderr] | |_____- help: try this: `if parts.path_and_query.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:138:20 [INFO] [stderr] | [INFO] [stderr] 138 | service_fn(move |req| service(req)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `service` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:159:24 [INFO] [stderr] | [INFO] [stderr] 159 | service_fn(move |req| service(req)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `service` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:175:27 [INFO] [stderr] | [INFO] [stderr] 175 | if host.ends_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/main.rs:115:12 [INFO] [stderr] | [INFO] [stderr] 115 | if let None = parts.path_and_query { [INFO] [stderr] | _____- ^^^^ [INFO] [stderr] 116 | | parts.path_and_query = Some(uri::PathAndQuery::from_static("/")); [INFO] [stderr] 117 | | } [INFO] [stderr] | |_____- help: try this: `if parts.path_and_query.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:138:20 [INFO] [stderr] | [INFO] [stderr] 138 | service_fn(move |req| service(req)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `service` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:159:24 [INFO] [stderr] | [INFO] [stderr] 159 | service_fn(move |req| service(req)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `service` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:175:27 [INFO] [stderr] | [INFO] [stderr] 175 | if host.ends_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 38.65s [INFO] running `"docker" "inspect" "2cac225a7247323d5da3756f60d2d0fa94a4b872b484657f9d33053d3483e9bc"` [INFO] running `"docker" "rm" "-f" "2cac225a7247323d5da3756f60d2d0fa94a4b872b484657f9d33053d3483e9bc"` [INFO] [stdout] 2cac225a7247323d5da3756f60d2d0fa94a4b872b484657f9d33053d3483e9bc