[INFO] updating cached repository jeromew21/rust-tic-tac-toe [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jeromew21/rust-tic-tac-toe [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jeromew21/rust-tic-tac-toe" "work/ex/clippy-test-run/sources/stable/gh/jeromew21/rust-tic-tac-toe"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jeromew21/rust-tic-tac-toe'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jeromew21/rust-tic-tac-toe" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jeromew21/rust-tic-tac-toe"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jeromew21/rust-tic-tac-toe'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 70d2f3e372b20e44eb425dac86cb22b0f11df24d [INFO] sha for GitHub repo jeromew21/rust-tic-tac-toe: 70d2f3e372b20e44eb425dac86cb22b0f11df24d [INFO] validating manifest of jeromew21/rust-tic-tac-toe on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jeromew21/rust-tic-tac-toe on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jeromew21/rust-tic-tac-toe [INFO] finished frobbing jeromew21/rust-tic-tac-toe [INFO] frobbed toml for jeromew21/rust-tic-tac-toe written to work/ex/clippy-test-run/sources/stable/gh/jeromew21/rust-tic-tac-toe/Cargo.toml [INFO] started frobbing jeromew21/rust-tic-tac-toe [INFO] finished frobbing jeromew21/rust-tic-tac-toe [INFO] frobbed toml for jeromew21/rust-tic-tac-toe written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jeromew21/rust-tic-tac-toe/Cargo.toml [INFO] crate jeromew21/rust-tic-tac-toe has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jeromew21/rust-tic-tac-toe against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jeromew21/rust-tic-tac-toe:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 77bfd5cd74c780b7fbc1736972a58dc728ed67ca410d79b4d92e20e6a4d9df75 [INFO] running `"docker" "start" "-a" "77bfd5cd74c780b7fbc1736972a58dc728ed67ca410d79b4d92e20e6a4d9df75"` [INFO] [stderr] Checking tic-tac-toe v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/ttt.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | / pub mod ttt { [INFO] [stderr] 2 | | extern crate rand; [INFO] [stderr] 3 | | use self::rand::Rng; [INFO] [stderr] 4 | | [INFO] [stderr] ... | [INFO] [stderr] 245 | | } [INFO] [stderr] 246 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ttt.rs:86:29 [INFO] [stderr] | [INFO] [stderr] 86 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ttt.rs:88:31 [INFO] [stderr] | [INFO] [stderr] 88 | _ => {return false;} [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ttt.rs:240:21 [INFO] [stderr] | [INFO] [stderr] 240 | return Some(*c); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(*c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/ttt.rs:91:17 [INFO] [stderr] | [INFO] [stderr] 77 | space => { [INFO] [stderr] | ----- matches any value [INFO] [stderr] ... [INFO] [stderr] 91 | _ => panic!("Wrong turn") [INFO] [stderr] | ^ unreachable pattern [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_patterns)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `num` [INFO] [stderr] --> src/main.rs:138:17 [INFO] [stderr] | [INFO] [stderr] 138 | let num = [INFO] [stderr] | ^^^ help: consider using `_num` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `error` [INFO] [stderr] --> src/main.rs:151:25 [INFO] [stderr] | [INFO] [stderr] 151 | Err(error) => { [INFO] [stderr] | ^^^^^ help: consider using `_error` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `space` [INFO] [stderr] --> src/ttt.rs:75:54 [INFO] [stderr] | [INFO] [stderr] 75 | pub fn make_move(&mut self, location: usize, space: &Space) -> bool { [INFO] [stderr] | ^^^^^ help: consider using `_space` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `c` [INFO] [stderr] --> src/ttt.rs:183:29 [INFO] [stderr] | [INFO] [stderr] 183 | if let Some(c) = i.move_index { [INFO] [stderr] | ^ help: consider using `_c` instead [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in self.board.iter().enumerate()` or similar iterators [INFO] [stderr] --> src/ttt.rs:48:22 [INFO] [stderr] | [INFO] [stderr] 48 | for s in self.board.iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: comparison is useless due to type limits [INFO] [stderr] --> src/ttt.rs:78:24 [INFO] [stderr] | [INFO] [stderr] 78 | if location < 0 || location > 8 { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_comparisons)] on by default [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/ttt.rs:78:24 [INFO] [stderr] | [INFO] [stderr] 78 | if location < 0 || location > 8 { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, this comparison is always false [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ttt.rs:122:24 [INFO] [stderr] | [INFO] [stderr] 122 | board: self.board.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.board` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/ttt.rs:188:40 [INFO] [stderr] | [INFO] [stderr] 188 | else { depth * -1 } [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_multiply)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | std::io::stdout().flush(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | File::create(RECORD_FILE); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | fs::write(RECORD_FILE, data); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let num =` [INFO] [stderr] --> src/main.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | / let num = [INFO] [stderr] 139 | | match input("Type a move: ").parse::() { [INFO] [stderr] 140 | | Ok(i) => { [INFO] [stderr] 141 | | if i > 0 && i <= 9 { [INFO] [stderr] ... | [INFO] [stderr] 154 | | } [INFO] [stderr] 155 | | }; [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `tic-tac-toe`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/ttt.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | / pub mod ttt { [INFO] [stderr] 2 | | extern crate rand; [INFO] [stderr] 3 | | use self::rand::Rng; [INFO] [stderr] 4 | | [INFO] [stderr] ... | [INFO] [stderr] 245 | | } [INFO] [stderr] 246 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ttt.rs:86:29 [INFO] [stderr] | [INFO] [stderr] 86 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ttt.rs:88:31 [INFO] [stderr] | [INFO] [stderr] 88 | _ => {return false;} [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ttt.rs:240:21 [INFO] [stderr] | [INFO] [stderr] 240 | return Some(*c); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(*c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/ttt.rs:91:17 [INFO] [stderr] | [INFO] [stderr] 77 | space => { [INFO] [stderr] | ----- matches any value [INFO] [stderr] ... [INFO] [stderr] 91 | _ => panic!("Wrong turn") [INFO] [stderr] | ^ unreachable pattern [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_patterns)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `num` [INFO] [stderr] --> src/main.rs:138:17 [INFO] [stderr] | [INFO] [stderr] 138 | let num = [INFO] [stderr] | ^^^ help: consider using `_num` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `error` [INFO] [stderr] --> src/main.rs:151:25 [INFO] [stderr] | [INFO] [stderr] 151 | Err(error) => { [INFO] [stderr] | ^^^^^ help: consider using `_error` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `space` [INFO] [stderr] --> src/ttt.rs:75:54 [INFO] [stderr] | [INFO] [stderr] 75 | pub fn make_move(&mut self, location: usize, space: &Space) -> bool { [INFO] [stderr] | ^^^^^ help: consider using `_space` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `c` [INFO] [stderr] --> src/ttt.rs:183:29 [INFO] [stderr] | [INFO] [stderr] 183 | if let Some(c) = i.move_index { [INFO] [stderr] | ^ help: consider using `_c` instead [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in self.board.iter().enumerate()` or similar iterators [INFO] [stderr] --> src/ttt.rs:48:22 [INFO] [stderr] | [INFO] [stderr] 48 | for s in self.board.iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: comparison is useless due to type limits [INFO] [stderr] --> src/ttt.rs:78:24 [INFO] [stderr] | [INFO] [stderr] 78 | if location < 0 || location > 8 { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_comparisons)] on by default [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/ttt.rs:78:24 [INFO] [stderr] | [INFO] [stderr] 78 | if location < 0 || location > 8 { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, this comparison is always false [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ttt.rs:122:24 [INFO] [stderr] | [INFO] [stderr] 122 | board: self.board.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.board` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/ttt.rs:188:40 [INFO] [stderr] | [INFO] [stderr] 188 | else { depth * -1 } [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_multiply)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | std::io::stdout().flush(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | File::create(RECORD_FILE); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | fs::write(RECORD_FILE, data); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let num =` [INFO] [stderr] --> src/main.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | / let num = [INFO] [stderr] 139 | | match input("Type a move: ").parse::() { [INFO] [stderr] 140 | | Ok(i) => { [INFO] [stderr] 141 | | if i > 0 && i <= 9 { [INFO] [stderr] ... | [INFO] [stderr] 154 | | } [INFO] [stderr] 155 | | }; [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `tic-tac-toe`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "77bfd5cd74c780b7fbc1736972a58dc728ed67ca410d79b4d92e20e6a4d9df75"` [INFO] running `"docker" "rm" "-f" "77bfd5cd74c780b7fbc1736972a58dc728ed67ca410d79b4d92e20e6a4d9df75"` [INFO] [stdout] 77bfd5cd74c780b7fbc1736972a58dc728ed67ca410d79b4d92e20e6a4d9df75