[INFO] updating cached repository jerk-rs/shipperingbot [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jerk-rs/shipperingbot [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jerk-rs/shipperingbot" "work/ex/clippy-test-run/sources/stable/gh/jerk-rs/shipperingbot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jerk-rs/shipperingbot'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jerk-rs/shipperingbot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jerk-rs/shipperingbot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jerk-rs/shipperingbot'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a33704f83dd7b1adaeaa41ccf21875eafc063690 [INFO] sha for GitHub repo jerk-rs/shipperingbot: a33704f83dd7b1adaeaa41ccf21875eafc063690 [INFO] validating manifest of jerk-rs/shipperingbot on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jerk-rs/shipperingbot on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jerk-rs/shipperingbot [INFO] finished frobbing jerk-rs/shipperingbot [INFO] frobbed toml for jerk-rs/shipperingbot written to work/ex/clippy-test-run/sources/stable/gh/jerk-rs/shipperingbot/Cargo.toml [INFO] started frobbing jerk-rs/shipperingbot [INFO] finished frobbing jerk-rs/shipperingbot [INFO] frobbed toml for jerk-rs/shipperingbot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jerk-rs/shipperingbot/Cargo.toml [INFO] crate jerk-rs/shipperingbot has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jerk-rs/shipperingbot against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jerk-rs/shipperingbot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7c22d2eac4a04712d9d2e04bc14bc7f4fa4e14d80a49e98fc39204fbea68c67b [INFO] running `"docker" "start" "-a" "7c22d2eac4a04712d9d2e04bc14bc7f4fa4e14d80a49e98fc39204fbea68c67b"` [INFO] [stderr] Compiling serde v1.0.82 [INFO] [stderr] Checking fallible-iterator v0.1.5 [INFO] [stderr] Checking liquid-error v0.16.1 [INFO] [stderr] Checking stringprep v0.1.2 [INFO] [stderr] Checking r2d2 v0.8.2 [INFO] [stderr] Compiling openssl v0.9.24 [INFO] [stderr] Checking mime v0.2.6 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking serde_json v0.9.10 [INFO] [stderr] Checking serde_urlencoded v0.4.3 [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Checking postgres-protocol v0.3.2 [INFO] [stderr] Checking dotenv v0.13.0 [INFO] [stderr] Checking ratelimit_meter v2.0.0 [INFO] [stderr] Checking hyper v0.10.13 [INFO] [stderr] Checking postgres-shared v0.4.2 [INFO] [stderr] Checking postgres v0.15.2 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Checking r2d2_postgres v0.14.0 [INFO] [stderr] Checking hyper-native-tls v0.2.4 [INFO] [stderr] Checking reqwest v0.4.0 [INFO] [stderr] Checking teleborg v0.1.32 [INFO] [stderr] Checking liquid-value v0.17.1 [INFO] [stderr] Checking liquid-interpreter v0.17.1 [INFO] [stderr] Checking liquid-compiler v0.17.1 [INFO] [stderr] Checking liquid v0.17.1 [INFO] [stderr] Checking shippering v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/command/lastpairs.rs:32:23 [INFO] [stderr] | [INFO] [stderr] 32 | let text = if rows.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `rows.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/command/shippering.rs:31:12 [INFO] [stderr] | [INFO] [stderr] 31 | if rows.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!rows.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/command/toplovelaces.rs:51:23 [INFO] [stderr] | [INFO] [stderr] 51 | let text = if rows.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `rows.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/command/utils.rs:7:22 [INFO] [stderr] | [INFO] [stderr] 7 | let mut result = format!("{}", first_name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `first_name.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/command/utils.rs:26:14 [INFO] [stderr] | [INFO] [stderr] 26 | chat_id: &i64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/command/lastpairs.rs:32:23 [INFO] [stderr] | [INFO] [stderr] 32 | let text = if rows.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `rows.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/command/shippering.rs:31:12 [INFO] [stderr] | [INFO] [stderr] 31 | if rows.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!rows.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/command/toplovelaces.rs:51:23 [INFO] [stderr] | [INFO] [stderr] 51 | let text = if rows.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `rows.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/command/utils.rs:7:22 [INFO] [stderr] | [INFO] [stderr] 7 | let mut result = format!("{}", first_name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `first_name.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/command/utils.rs:26:14 [INFO] [stderr] | [INFO] [stderr] 26 | chat_id: &i64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 43.77s [INFO] running `"docker" "inspect" "7c22d2eac4a04712d9d2e04bc14bc7f4fa4e14d80a49e98fc39204fbea68c67b"` [INFO] running `"docker" "rm" "-f" "7c22d2eac4a04712d9d2e04bc14bc7f4fa4e14d80a49e98fc39204fbea68c67b"` [INFO] [stdout] 7c22d2eac4a04712d9d2e04bc14bc7f4fa4e14d80a49e98fc39204fbea68c67b