[INFO] updating cached repository jeremyschlatter/enigma
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/jeremyschlatter/enigma
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/jeremyschlatter/enigma" "work/ex/clippy-test-run/sources/stable/gh/jeremyschlatter/enigma"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jeremyschlatter/enigma'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/jeremyschlatter/enigma" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jeremyschlatter/enigma"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jeremyschlatter/enigma'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 53a87a60fdb02bfe08a73da5d1d1ea5a5c30cbfd
[INFO] sha for GitHub repo jeremyschlatter/enigma: 53a87a60fdb02bfe08a73da5d1d1ea5a5c30cbfd
[INFO] validating manifest of jeremyschlatter/enigma on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of jeremyschlatter/enigma on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing jeremyschlatter/enigma
[INFO] finished frobbing jeremyschlatter/enigma
[INFO] frobbed toml for jeremyschlatter/enigma written to work/ex/clippy-test-run/sources/stable/gh/jeremyschlatter/enigma/Cargo.toml
[INFO] started frobbing jeremyschlatter/enigma
[INFO] finished frobbing jeremyschlatter/enigma
[INFO] frobbed toml for jeremyschlatter/enigma written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jeremyschlatter/enigma/Cargo.toml
[INFO] crate jeremyschlatter/enigma has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting jeremyschlatter/enigma against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jeremyschlatter/enigma:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 4191e0f2a54a64ba7dd63e3984b4c892d514326bc31198b4b6e22e2e4afd92ee
[INFO] running `"docker" "start" "-a" "4191e0f2a54a64ba7dd63e3984b4c892d514326bc31198b4b6e22e2e4afd92ee"`
[INFO] [stderr]     Checking enigma v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/main.rs:48:17
[INFO] [stderr]    |
[INFO] [stderr] 48 |         let (a, b) = (p[i * 2], p[i * 2 + 1]);
[INFO] [stderr]    |                 ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:137:13
[INFO] [stderr]     |
[INFO] [stderr] 137 |             notch: notch,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `notch`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/main.rs:48:17
[INFO] [stderr]    |
[INFO] [stderr] 48 |         let (a, b) = (p[i * 2], p[i * 2 + 1]);
[INFO] [stderr]    |                 ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:137:13
[INFO] [stderr]     |
[INFO] [stderr] 137 |             notch: notch,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `notch`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/main.rs:35:11
[INFO] [stderr]    |
[INFO] [stderr] 35 |     (u + ('a' as u8 as usize)) as u8 as char
[INFO] [stderr]    |           ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::char_lit_as_u8)] on by default
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'a'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `r`
[INFO] [stderr]   --> src/main.rs:44:14
[INFO] [stderr]    |
[INFO] [stderr] 44 |     for i in 0..r.len() {
[INFO] [stderr]    |              ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 44 |     for (i, <item>) in r.iter_mut().enumerate() {
[INFO] [stderr]    |         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/main.rs:108:21
[INFO] [stderr]     |
[INFO] [stderr] 108 |         let mut r = p.clone();
[INFO] [stderr]     |                     ^^^^^^^^^ help: try removing the `clone` call: `p`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `p`
[INFO] [stderr]    --> src/main.rs:139:18
[INFO] [stderr]     |
[INFO] [stderr] 139 |         for i in 0..ALPHABET_SIZE {
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 139 |         for (i, <item>) in p.iter_mut().enumerate().take(ALPHABET_SIZE) {
[INFO] [stderr]     |             ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/main.rs:35:11
[INFO] [stderr]    |
[INFO] [stderr] 35 |     (u + ('a' as u8 as usize)) as u8 as char
[INFO] [stderr]    |           ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::char_lit_as_u8)] on by default
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'a'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `r`
[INFO] [stderr]   --> src/main.rs:44:14
[INFO] [stderr]    |
[INFO] [stderr] 44 |     for i in 0..r.len() {
[INFO] [stderr]    |              ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 44 |     for (i, <item>) in r.iter_mut().enumerate() {
[INFO] [stderr]    |         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/main.rs:108:21
[INFO] [stderr]     |
[INFO] [stderr] 108 |         let mut r = p.clone();
[INFO] [stderr]     |                     ^^^^^^^^^ help: try removing the `clone` call: `p`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `p`
[INFO] [stderr]    --> src/main.rs:139:18
[INFO] [stderr]     |
[INFO] [stderr] 139 |         for i in 0..ALPHABET_SIZE {
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 139 |         for (i, <item>) in p.iter_mut().enumerate().take(ALPHABET_SIZE) {
[INFO] [stderr]     |             ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.01s
[INFO] running `"docker" "inspect" "4191e0f2a54a64ba7dd63e3984b4c892d514326bc31198b4b6e22e2e4afd92ee"`
[INFO] running `"docker" "rm" "-f" "4191e0f2a54a64ba7dd63e3984b4c892d514326bc31198b4b6e22e2e4afd92ee"`
[INFO] [stdout] 4191e0f2a54a64ba7dd63e3984b4c892d514326bc31198b4b6e22e2e4afd92ee