[INFO] updating cached repository jeramyRR/play_vm [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jeramyRR/play_vm [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jeramyRR/play_vm" "work/ex/clippy-test-run/sources/stable/gh/jeramyRR/play_vm"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jeramyRR/play_vm'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jeramyRR/play_vm" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jeramyRR/play_vm"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jeramyRR/play_vm'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6cb47be238ed2ffbdbdeb0b5fcca01790fff6511 [INFO] sha for GitHub repo jeramyRR/play_vm: 6cb47be238ed2ffbdbdeb0b5fcca01790fff6511 [INFO] validating manifest of jeramyRR/play_vm on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jeramyRR/play_vm on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jeramyRR/play_vm [INFO] finished frobbing jeramyRR/play_vm [INFO] frobbed toml for jeramyRR/play_vm written to work/ex/clippy-test-run/sources/stable/gh/jeramyRR/play_vm/Cargo.toml [INFO] started frobbing jeramyRR/play_vm [INFO] finished frobbing jeramyRR/play_vm [INFO] frobbed toml for jeramyRR/play_vm written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jeramyRR/play_vm/Cargo.toml [INFO] crate jeramyRR/play_vm has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jeramyRR/play_vm against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jeramyRR/play_vm:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 812b4c3305b6ef0374fff1e10ae723ab3ecf3952422279789663002dc109a0ad [INFO] running `"docker" "start" "-a" "812b4c3305b6ef0374fff1e10ae723ab3ecf3952422279789663002dc109a0ad"` [INFO] [stderr] Checking memchr v2.0.2 [INFO] [stderr] Checking nom v4.0.0 [INFO] [stderr] Checking iridium v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instruction.rs:55:19 [INFO] [stderr] | [INFO] [stderr] 55 | Instruction { opcode: opcode } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instruction.rs:55:19 [INFO] [stderr] | [INFO] [stderr] 55 | Instruction { opcode: opcode } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vm.rs:153:5 [INFO] [stderr] | [INFO] [stderr] 153 | return opcode; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `opcode` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vm.rs:161:5 [INFO] [stderr] | [INFO] [stderr] 161 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vm.rs:167:5 [INFO] [stderr] | [INFO] [stderr] 167 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vm.rs:153:5 [INFO] [stderr] | [INFO] [stderr] 153 | return opcode; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `opcode` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vm.rs:161:5 [INFO] [stderr] | [INFO] [stderr] 161 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vm.rs:167:5 [INFO] [stderr] | [INFO] [stderr] 167 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `repl::REPL` [INFO] [stderr] --> src/repl/mod.rs:13:3 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> REPL { [INFO] [stderr] 14 | | REPL { [INFO] [stderr] 15 | | command_buffer: vec![], [INFO] [stderr] 16 | | vm: VM::new(), [INFO] [stderr] 17 | | } [INFO] [stderr] 18 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | impl Default for repl::REPL { [INFO] [stderr] 13 | fn default() -> Self { [INFO] [stderr] 14 | Self::new() [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `vm::VM` [INFO] [stderr] --> src/vm.rs:18:3 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> VM { [INFO] [stderr] 19 | | VM { [INFO] [stderr] 20 | | registers: [0; 32], [INFO] [stderr] 21 | | pc: 0, [INFO] [stderr] ... | [INFO] [stderr] 25 | | } [INFO] [stderr] 26 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/vm.rs:49:22 [INFO] [stderr] | [INFO] [stderr] 49 | let number = self.next_16_bits() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.next_16_bits())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/vm.rs:165:24 [INFO] [stderr] | [INFO] [stderr] 165 | let result: u16 = ((self.program[self.pc] as u16) << 8) | self.program[self.pc + 1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.program[self.pc])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/vm.rs:165:63 [INFO] [stderr] | [INFO] [stderr] 165 | let result: u16 = ((self.program[self.pc] as u16) << 8) | self.program[self.pc + 1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.program[self.pc + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `repl::REPL` [INFO] [stderr] --> src/repl/mod.rs:13:3 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> REPL { [INFO] [stderr] 14 | | REPL { [INFO] [stderr] 15 | | command_buffer: vec![], [INFO] [stderr] 16 | | vm: VM::new(), [INFO] [stderr] 17 | | } [INFO] [stderr] 18 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | impl Default for repl::REPL { [INFO] [stderr] 13 | fn default() -> Self { [INFO] [stderr] 14 | Self::new() [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `vm::VM` [INFO] [stderr] --> src/vm.rs:18:3 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> VM { [INFO] [stderr] 19 | | VM { [INFO] [stderr] 20 | | registers: [0; 32], [INFO] [stderr] 21 | | pc: 0, [INFO] [stderr] ... | [INFO] [stderr] 25 | | } [INFO] [stderr] 26 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/vm.rs:49:22 [INFO] [stderr] | [INFO] [stderr] 49 | let number = self.next_16_bits() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.next_16_bits())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/vm.rs:165:24 [INFO] [stderr] | [INFO] [stderr] 165 | let result: u16 = ((self.program[self.pc] as u16) << 8) | self.program[self.pc + 1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.program[self.pc])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/vm.rs:165:63 [INFO] [stderr] | [INFO] [stderr] 165 | let result: u16 = ((self.program[self.pc] as u16) << 8) | self.program[self.pc + 1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.program[self.pc + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.30s [INFO] running `"docker" "inspect" "812b4c3305b6ef0374fff1e10ae723ab3ecf3952422279789663002dc109a0ad"` [INFO] running `"docker" "rm" "-f" "812b4c3305b6ef0374fff1e10ae723ab3ecf3952422279789663002dc109a0ad"` [INFO] [stdout] 812b4c3305b6ef0374fff1e10ae723ab3ecf3952422279789663002dc109a0ad