[INFO] updating cached repository jepityr/aoc [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jepityr/aoc [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jepityr/aoc" "work/ex/clippy-test-run/sources/stable/gh/jepityr/aoc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jepityr/aoc'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jepityr/aoc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jepityr/aoc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jepityr/aoc'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f71a39c70cd0ba686c2e7966d346edb0596b2908 [INFO] sha for GitHub repo jepityr/aoc: f71a39c70cd0ba686c2e7966d346edb0596b2908 [INFO] validating manifest of jepityr/aoc on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jepityr/aoc on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jepityr/aoc [INFO] finished frobbing jepityr/aoc [INFO] frobbed toml for jepityr/aoc written to work/ex/clippy-test-run/sources/stable/gh/jepityr/aoc/Cargo.toml [INFO] started frobbing jepityr/aoc [INFO] finished frobbing jepityr/aoc [INFO] frobbed toml for jepityr/aoc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jepityr/aoc/Cargo.toml [INFO] crate jepityr/aoc has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jepityr/aoc against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jepityr/aoc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4430036af2c0e2d42adf7369acfd2563d35195a1544e8426a9f24e109dc34cab [INFO] running `"docker" "start" "-a" "4430036af2c0e2d42adf7369acfd2563d35195a1544e8426a9f24e109dc34cab"` [INFO] [stderr] Checking aoc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/bin/day7.rs:1322:5 [INFO] [stderr] | [INFO] [stderr] 1322 | / let mut c = None; [INFO] [stderr] 1323 | | if l.split(' ').count() > 2 { [INFO] [stderr] 1324 | | c = Some(l.split(' ').skip(3).map(|s| s.trim_matches(',')).collect()); [INFO] [stderr] 1325 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let c = if l.split(' ').count() > 2 { Some(l.split(' ').skip(3).map(|s| s.trim_matches(',')).collect()) } else { None };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/bin/day7.rs:1322:5 [INFO] [stderr] | [INFO] [stderr] 1322 | / let mut c = None; [INFO] [stderr] 1323 | | if l.split(' ').count() > 2 { [INFO] [stderr] 1324 | | c = Some(l.split(' ').skip(3).map(|s| s.trim_matches(',')).collect()); [INFO] [stderr] 1325 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let c = if l.split(' ').count() > 2 { Some(l.split(' ').skip(3).map(|s| s.trim_matches(',')).collect()) } else { None };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.91s [INFO] running `"docker" "inspect" "4430036af2c0e2d42adf7369acfd2563d35195a1544e8426a9f24e109dc34cab"` [INFO] running `"docker" "rm" "-f" "4430036af2c0e2d42adf7369acfd2563d35195a1544e8426a9f24e109dc34cab"` [INFO] [stdout] 4430036af2c0e2d42adf7369acfd2563d35195a1544e8426a9f24e109dc34cab