[INFO] updating cached repository jelford/squirrel [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jelford/squirrel [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jelford/squirrel" "work/ex/clippy-test-run/sources/stable/gh/jelford/squirrel"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jelford/squirrel'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jelford/squirrel" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jelford/squirrel"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jelford/squirrel'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5702fbf7576fe5041f5dfcc9284e48fca6748cd9 [INFO] sha for GitHub repo jelford/squirrel: 5702fbf7576fe5041f5dfcc9284e48fca6748cd9 [INFO] validating manifest of jelford/squirrel on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jelford/squirrel on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jelford/squirrel [INFO] finished frobbing jelford/squirrel [INFO] frobbed toml for jelford/squirrel written to work/ex/clippy-test-run/sources/stable/gh/jelford/squirrel/Cargo.toml [INFO] started frobbing jelford/squirrel [INFO] finished frobbing jelford/squirrel [INFO] frobbed toml for jelford/squirrel written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jelford/squirrel/Cargo.toml [INFO] crate jelford/squirrel has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jelford/squirrel against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jelford/squirrel:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 24d821f9e8cf512662d9f445b037908defa9615b3d0f3848e2c45bdf134d13c0 [INFO] running `"docker" "start" "-a" "24d821f9e8cf512662d9f445b037908defa9615b3d0f3848e2c45bdf134d13c0"` [INFO] [stderr] Checking memchr v1.0.1 [INFO] [stderr] Checking inotify v0.3.0 [INFO] [stderr] Checking filetime v0.1.12 [INFO] [stderr] Checking net2 v0.2.31 [INFO] [stderr] Compiling libsqlite3-sys v0.8.1 [INFO] [stderr] Checking nix v0.5.1 [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking aho-corasick v0.6.3 [INFO] [stderr] Checking miow v0.1.5 [INFO] [stderr] Checking regex v0.2.2 [INFO] [stderr] Checking rusqlite v0.12.0 [INFO] [stderr] Checking mio v0.5.1 [INFO] [stderr] Checking globset v0.2.0 [INFO] [stderr] Checking env_logger v0.4.3 [INFO] [stderr] Checking notify v4.0.1 [INFO] [stderr] Checking ignore v0.2.2 [INFO] [stderr] Checking squirrel v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/squirrel/squirrel.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | journal: journal, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `journal` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/squirrel/event.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | event_type: event_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `event_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/squirrel/event.rs:115:9 [INFO] [stderr] | [INFO] [stderr] 115 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/squirrel/event.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | snapshot: snapshot, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `snapshot` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/squirrel/event.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | before_path: before_path, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `before_path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/squirrel/event.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | after_path: after_path, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `after_path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/squirrel/snapshot_viewer.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | glob: glob, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `glob` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/squirrel/snapshot_viewer.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | "Snapshot" [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/path_filter.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | base_path: base_path, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `base_path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/path_filter.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | stash_path: stash_path, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stash_path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/squirrel/squirrel.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | journal: journal, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `journal` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/squirrel/event.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | event_type: event_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `event_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/squirrel/event.rs:115:9 [INFO] [stderr] | [INFO] [stderr] 115 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/squirrel/event.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | snapshot: snapshot, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `snapshot` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/squirrel/event.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | before_path: before_path, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `before_path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/squirrel/event.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | after_path: after_path, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `after_path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/squirrel/snapshot_viewer.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | glob: glob, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `glob` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/squirrel/snapshot_viewer.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | "Snapshot" [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/path_filter.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | base_path: base_path, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `base_path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/path_filter.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | stash_path: stash_path, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stash_path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/squirrel/mod.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | mod squirrel; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/path_filter.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | return Ok(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(true)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/squirrel/mod.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | mod squirrel; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/path_filter.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | return Ok(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(true)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/squirrel/server.rs:48:39 [INFO] [stderr] | [INFO] [stderr] 48 | watcher.unwatch(&watched).expect(&format!( [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 49 | | "Unable to unwatch {:?}", [INFO] [stderr] 50 | | watched [INFO] [stderr] 51 | | )); [INFO] [stderr] | |______________^ help: try this: `unwrap_or_else(|_| panic!("Unable to unwatch {:?}", watched))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/squirrel/squirrel.rs:13:19 [INFO] [stderr] | [INFO] [stderr] 13 | pub(crate) fn new<'a, Journal>( [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/squirrel/event.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / match self { [INFO] [stderr] 22 | | &FileEvent::Write(ref p) | [INFO] [stderr] 23 | | &FileEvent::Create(ref p) | [INFO] [stderr] 24 | | &FileEvent::Rename(ref p, _) | [INFO] [stderr] 25 | | &FileEvent::Remove(ref p) => Some(p), [INFO] [stderr] 26 | | &FileEvent::UnknownEvent => None, [INFO] [stderr] 27 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 21 | match *self { [INFO] [stderr] 22 | FileEvent::Write(ref p) | [INFO] [stderr] 23 | FileEvent::Create(ref p) | [INFO] [stderr] 24 | FileEvent::Rename(ref p, _) | [INFO] [stderr] 25 | FileEvent::Remove(ref p) => Some(p), [INFO] [stderr] 26 | FileEvent::UnknownEvent => None, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/squirrel/event.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | / match self { [INFO] [stderr] 87 | | &EventType::Create => write!(f, "Create"), [INFO] [stderr] 88 | | &EventType::Remove => write!(f, "Remove"), [INFO] [stderr] 89 | | &EventType::Update => write!(f, "Update"), [INFO] [stderr] 90 | | &EventType::Rename => write!(f, "Rename"), [INFO] [stderr] 91 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 86 | match *self { [INFO] [stderr] 87 | EventType::Create => write!(f, "Create"), [INFO] [stderr] 88 | EventType::Remove => write!(f, "Remove"), [INFO] [stderr] 89 | EventType::Update => write!(f, "Update"), [INFO] [stderr] 90 | EventType::Rename => write!(f, "Rename"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/squirrel/journal/sqlite_journal.rs:39:25 [INFO] [stderr] | [INFO] [stderr] 39 | let timestamp = format!("{}", event.timestamp.rfc3339()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `event.timestamp.rfc3339().to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/squirrel/journal/sqlite_journal.rs:87:36 [INFO] [stderr] | [INFO] [stderr] 87 | after_path: after_path.map(|s| PathBuf::from(s)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PathBuf::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/squirrel/journal/sqlite_journal.rs:88:35 [INFO] [stderr] | [INFO] [stderr] 88 | before_path: snapshot.map(|s| PathBuf::from(s)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PathBuf::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/squirrel/journal/sqlite_journal.rs:89:35 [INFO] [stderr] | [INFO] [stderr] 89 | snapshot: before_path.map(|s| PathBuf::from(s)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PathBuf::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/squirrel/snapshot_viewer.rs:34:14 [INFO] [stderr] | [INFO] [stderr] 34 | .unwrap_or(String::from("")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from(""))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/squirrel/snapshot_viewer.rs:59:37 [INFO] [stderr] | [INFO] [stderr] 59 | let snapshot_path = event [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 60 | | .snapshot [INFO] [stderr] 61 | | .map(|p| String::from(p.to_string_lossy())) [INFO] [stderr] 62 | | .unwrap_or(String::new()); [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 59 | let snapshot_path = event [INFO] [stderr] 60 | .snapshot [INFO] [stderr] 61 | .map(|p| String::from(p.to_string_lossy())).unwrap_or_default(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/path_filter.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | / match c { [INFO] [stderr] 70 | | Component::Normal(ref path_part) => { [INFO] [stderr] 71 | | if path_part.to_string_lossy().starts_with(".") { [INFO] [stderr] 72 | | return true; [INFO] [stderr] ... | [INFO] [stderr] 75 | | _ => {} [INFO] [stderr] 76 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 69 | if let Component::Normal(ref path_part) = c { [INFO] [stderr] 70 | if path_part.to_string_lossy().starts_with(".") { [INFO] [stderr] 71 | return true; [INFO] [stderr] 72 | } [INFO] [stderr] 73 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/path_filter.rs:71:64 [INFO] [stderr] | [INFO] [stderr] 71 | if path_part.to_string_lossy().starts_with(".") { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:50:12 [INFO] [stderr] | [INFO] [stderr] 50 | if let Some(_) = matches.subcommand_matches("daemon") { [INFO] [stderr] | _____- ^^^^^^^ [INFO] [stderr] 51 | | return squirrel::run_squirrel(&watched_dir, &stash_path); [INFO] [stderr] 52 | | } [INFO] [stderr] | |_____- help: try this: `if matches.subcommand_matches("daemon").is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/squirrel/server.rs:48:39 [INFO] [stderr] | [INFO] [stderr] 48 | watcher.unwatch(&watched).expect(&format!( [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 49 | | "Unable to unwatch {:?}", [INFO] [stderr] 50 | | watched [INFO] [stderr] 51 | | )); [INFO] [stderr] | |______________^ help: try this: `unwrap_or_else(|_| panic!("Unable to unwatch {:?}", watched))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/squirrel/squirrel.rs:13:19 [INFO] [stderr] | [INFO] [stderr] 13 | pub(crate) fn new<'a, Journal>( [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/squirrel/event.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / match self { [INFO] [stderr] 22 | | &FileEvent::Write(ref p) | [INFO] [stderr] 23 | | &FileEvent::Create(ref p) | [INFO] [stderr] 24 | | &FileEvent::Rename(ref p, _) | [INFO] [stderr] 25 | | &FileEvent::Remove(ref p) => Some(p), [INFO] [stderr] 26 | | &FileEvent::UnknownEvent => None, [INFO] [stderr] 27 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 21 | match *self { [INFO] [stderr] 22 | FileEvent::Write(ref p) | [INFO] [stderr] 23 | FileEvent::Create(ref p) | [INFO] [stderr] 24 | FileEvent::Rename(ref p, _) | [INFO] [stderr] 25 | FileEvent::Remove(ref p) => Some(p), [INFO] [stderr] 26 | FileEvent::UnknownEvent => None, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/squirrel/event.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | / match self { [INFO] [stderr] 87 | | &EventType::Create => write!(f, "Create"), [INFO] [stderr] 88 | | &EventType::Remove => write!(f, "Remove"), [INFO] [stderr] 89 | | &EventType::Update => write!(f, "Update"), [INFO] [stderr] 90 | | &EventType::Rename => write!(f, "Rename"), [INFO] [stderr] 91 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 86 | match *self { [INFO] [stderr] 87 | EventType::Create => write!(f, "Create"), [INFO] [stderr] 88 | EventType::Remove => write!(f, "Remove"), [INFO] [stderr] 89 | EventType::Update => write!(f, "Update"), [INFO] [stderr] 90 | EventType::Rename => write!(f, "Rename"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/squirrel/journal/sqlite_journal.rs:39:25 [INFO] [stderr] | [INFO] [stderr] 39 | let timestamp = format!("{}", event.timestamp.rfc3339()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `event.timestamp.rfc3339().to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/squirrel/journal/sqlite_journal.rs:87:36 [INFO] [stderr] | [INFO] [stderr] 87 | after_path: after_path.map(|s| PathBuf::from(s)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PathBuf::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/squirrel/journal/sqlite_journal.rs:88:35 [INFO] [stderr] | [INFO] [stderr] 88 | before_path: snapshot.map(|s| PathBuf::from(s)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PathBuf::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/squirrel/journal/sqlite_journal.rs:89:35 [INFO] [stderr] | [INFO] [stderr] 89 | snapshot: before_path.map(|s| PathBuf::from(s)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PathBuf::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/squirrel/snapshot_viewer.rs:34:14 [INFO] [stderr] | [INFO] [stderr] 34 | .unwrap_or(String::from("")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from(""))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/squirrel/snapshot_viewer.rs:59:37 [INFO] [stderr] | [INFO] [stderr] 59 | let snapshot_path = event [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 60 | | .snapshot [INFO] [stderr] 61 | | .map(|p| String::from(p.to_string_lossy())) [INFO] [stderr] 62 | | .unwrap_or(String::new()); [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 59 | let snapshot_path = event [INFO] [stderr] 60 | .snapshot [INFO] [stderr] 61 | .map(|p| String::from(p.to_string_lossy())).unwrap_or_default(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/path_filter.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | / match c { [INFO] [stderr] 70 | | Component::Normal(ref path_part) => { [INFO] [stderr] 71 | | if path_part.to_string_lossy().starts_with(".") { [INFO] [stderr] 72 | | return true; [INFO] [stderr] ... | [INFO] [stderr] 75 | | _ => {} [INFO] [stderr] 76 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 69 | if let Component::Normal(ref path_part) = c { [INFO] [stderr] 70 | if path_part.to_string_lossy().starts_with(".") { [INFO] [stderr] 71 | return true; [INFO] [stderr] 72 | } [INFO] [stderr] 73 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/path_filter.rs:71:64 [INFO] [stderr] | [INFO] [stderr] 71 | if path_part.to_string_lossy().starts_with(".") { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:50:12 [INFO] [stderr] | [INFO] [stderr] 50 | if let Some(_) = matches.subcommand_matches("daemon") { [INFO] [stderr] | _____- ^^^^^^^ [INFO] [stderr] 51 | | return squirrel::run_squirrel(&watched_dir, &stash_path); [INFO] [stderr] 52 | | } [INFO] [stderr] | |_____- help: try this: `if matches.subcommand_matches("daemon").is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.88s [INFO] running `"docker" "inspect" "24d821f9e8cf512662d9f445b037908defa9615b3d0f3848e2c45bdf134d13c0"` [INFO] running `"docker" "rm" "-f" "24d821f9e8cf512662d9f445b037908defa9615b3d0f3848e2c45bdf134d13c0"` [INFO] [stdout] 24d821f9e8cf512662d9f445b037908defa9615b3d0f3848e2c45bdf134d13c0