[INFO] updating cached repository jeffs/rust-euler [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jeffs/rust-euler [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jeffs/rust-euler" "work/ex/clippy-test-run/sources/stable/gh/jeffs/rust-euler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jeffs/rust-euler'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jeffs/rust-euler" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jeffs/rust-euler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jeffs/rust-euler'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ee12b0d784974fd5b7c586463acbbd0e042291bf [INFO] sha for GitHub repo jeffs/rust-euler: ee12b0d784974fd5b7c586463acbbd0e042291bf [INFO] validating manifest of jeffs/rust-euler on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jeffs/rust-euler on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jeffs/rust-euler [INFO] finished frobbing jeffs/rust-euler [INFO] frobbed toml for jeffs/rust-euler written to work/ex/clippy-test-run/sources/stable/gh/jeffs/rust-euler/Cargo.toml [INFO] started frobbing jeffs/rust-euler [INFO] finished frobbing jeffs/rust-euler [INFO] frobbed toml for jeffs/rust-euler written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jeffs/rust-euler/Cargo.toml [INFO] crate jeffs/rust-euler has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jeffs/rust-euler against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jeffs/rust-euler:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 98ccc6db462caff2c38a6da3736a9de2bc86b863946384590911c3140310e333 [INFO] running `"docker" "start" "-a" "98ccc6db462caff2c38a6da3736a9de2bc86b863946384590911c3140310e333"` [INFO] [stderr] Checking rust-euler v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/problem1.rs:27:32 [INFO] [stderr] | [INFO] [stderr] 27 | assert_eq!(solution(), 233168); [INFO] [stderr] | ^^^^^^ help: consider: `233_168` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/problem4.rs:52:38 [INFO] [stderr] | [INFO] [stderr] 52 | assert_eq!(to_digits_reverse(8675309, 10), vec![9, 0, 3, 5, 7, 6, 8]); [INFO] [stderr] | ^^^^^^^ help: consider: `8_675_309` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/problem4.rs:57:32 [INFO] [stderr] | [INFO] [stderr] 57 | assert_eq!(solution(), 906609); [INFO] [stderr] | ^^^^^^ help: consider: `906_609` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/problem7.rs:22:32 [INFO] [stderr] | [INFO] [stderr] 22 | assert_eq!(solution(), 104743); [INFO] [stderr] | ^^^^^^ help: consider: `104_743` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/problem5.rs:19:29 [INFO] [stderr] | [INFO] [stderr] 19 | for m in (1..21u64).map(|i| factor(i)) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `factor` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/problem6.rs:20:31 [INFO] [stderr] | [INFO] [stderr] 20 | let sum_of_squares: u64 = (1..(n + 1)).map(|x| x * x).sum(); [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `(1..=n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/prime.rs:17:11 [INFO] [stderr] | [INFO] [stderr] 17 | pairs.into_iter().cloned().collect() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/prime.rs:63:21 [INFO] [stderr] | [INFO] [stderr] 63 | fn none_divides(ds: &Vec, n: u64) -> bool { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/problem5.rs:19:29 [INFO] [stderr] | [INFO] [stderr] 19 | for m in (1..21u64).map(|i| factor(i)) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `factor` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/problem6.rs:20:31 [INFO] [stderr] | [INFO] [stderr] 20 | let sum_of_squares: u64 = (1..(n + 1)).map(|x| x * x).sum(); [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `(1..=n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/prime.rs:17:11 [INFO] [stderr] | [INFO] [stderr] 17 | pairs.into_iter().cloned().collect() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/prime.rs:63:21 [INFO] [stderr] | [INFO] [stderr] 63 | fn none_divides(ds: &Vec, n: u64) -> bool { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.78s [INFO] running `"docker" "inspect" "98ccc6db462caff2c38a6da3736a9de2bc86b863946384590911c3140310e333"` [INFO] running `"docker" "rm" "-f" "98ccc6db462caff2c38a6da3736a9de2bc86b863946384590911c3140310e333"` [INFO] [stdout] 98ccc6db462caff2c38a6da3736a9de2bc86b863946384590911c3140310e333