[INFO] updating cached repository jeffrey-xiao/hash-rings-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jeffrey-xiao/hash-rings-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jeffrey-xiao/hash-rings-rs" "work/ex/clippy-test-run/sources/stable/gh/jeffrey-xiao/hash-rings-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jeffrey-xiao/hash-rings-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jeffrey-xiao/hash-rings-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jeffrey-xiao/hash-rings-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jeffrey-xiao/hash-rings-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1ce1fad2d0c33c4f76190383841573d1c37e7af2 [INFO] sha for GitHub repo jeffrey-xiao/hash-rings-rs: 1ce1fad2d0c33c4f76190383841573d1c37e7af2 [INFO] validating manifest of jeffrey-xiao/hash-rings-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jeffrey-xiao/hash-rings-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jeffrey-xiao/hash-rings-rs [INFO] finished frobbing jeffrey-xiao/hash-rings-rs [INFO] frobbed toml for jeffrey-xiao/hash-rings-rs written to work/ex/clippy-test-run/sources/stable/gh/jeffrey-xiao/hash-rings-rs/Cargo.toml [INFO] started frobbing jeffrey-xiao/hash-rings-rs [INFO] finished frobbing jeffrey-xiao/hash-rings-rs [INFO] frobbed toml for jeffrey-xiao/hash-rings-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jeffrey-xiao/hash-rings-rs/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jeffrey-xiao/hash-rings-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jeffrey-xiao/hash-rings-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f3c909cfc55de52d2230c26664dd35d7e2df0f7e59b249fa95920e314c563f23 [INFO] running `"docker" "start" "-a" "f3c909cfc55de52d2230c26664dd35d7e2df0f7e59b249fa95920e314c563f23"` [INFO] [stderr] Checking primal-estimate v0.2.1 [INFO] [stderr] Checking primal-bit v0.2.4 [INFO] [stderr] Checking smallvec v0.6.8 [INFO] [stderr] Checking num-integer v0.1.39 [INFO] [stderr] Checking primal-check v0.2.3 [INFO] [stderr] Checking primal-sieve v0.2.9 [INFO] [stderr] Checking primal v0.2.3 [INFO] [stderr] Checking hash-rings v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `BTreeMap` [INFO] [stderr] --> src/consistent.rs:319:13 [INFO] [stderr] | [INFO] [stderr] 319 | / if !self.data.contains_key(&new_hash) { [INFO] [stderr] 320 | | if let Some((hash, points)) = self.get_next_node(new_hash) { [INFO] [stderr] 321 | | let (old_set, new_set) = points.drain().partition(|point| { [INFO] [stderr] 322 | | let point_hash = util::gen_hash(point); [INFO] [stderr] ... | [INFO] [stderr] 333 | | self.data.insert(new_hash, new_points); [INFO] [stderr] 334 | | } [INFO] [stderr] | |_____________^ help: consider using: `self.data.entry(new_hash)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `BTreeMap` [INFO] [stderr] --> src/consistent.rs:319:13 [INFO] [stderr] | [INFO] [stderr] 319 | / if !self.data.contains_key(&new_hash) { [INFO] [stderr] 320 | | if let Some((hash, points)) = self.get_next_node(new_hash) { [INFO] [stderr] 321 | | let (old_set, new_set) = points.drain().partition(|point| { [INFO] [stderr] 322 | | let point_hash = util::gen_hash(point); [INFO] [stderr] ... | [INFO] [stderr] 333 | | self.data.insert(new_hash, new_points); [INFO] [stderr] 334 | | } [INFO] [stderr] | |_____________^ help: consider using: `self.data.entry(new_hash)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.30s [INFO] running `"docker" "inspect" "f3c909cfc55de52d2230c26664dd35d7e2df0f7e59b249fa95920e314c563f23"` [INFO] running `"docker" "rm" "-f" "f3c909cfc55de52d2230c26664dd35d7e2df0f7e59b249fa95920e314c563f23"` [INFO] [stdout] f3c909cfc55de52d2230c26664dd35d7e2df0f7e59b249fa95920e314c563f23