[INFO] updating cached repository jeeb/rustly_mpegts [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jeeb/rustly_mpegts [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jeeb/rustly_mpegts" "work/ex/clippy-test-run/sources/stable/gh/jeeb/rustly_mpegts"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jeeb/rustly_mpegts'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jeeb/rustly_mpegts" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jeeb/rustly_mpegts"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jeeb/rustly_mpegts'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 71cc5e987b107a2620ae99813a06e78a40616d8b [INFO] sha for GitHub repo jeeb/rustly_mpegts: 71cc5e987b107a2620ae99813a06e78a40616d8b [INFO] validating manifest of jeeb/rustly_mpegts on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jeeb/rustly_mpegts on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jeeb/rustly_mpegts [INFO] finished frobbing jeeb/rustly_mpegts [INFO] frobbed toml for jeeb/rustly_mpegts written to work/ex/clippy-test-run/sources/stable/gh/jeeb/rustly_mpegts/Cargo.toml [INFO] started frobbing jeeb/rustly_mpegts [INFO] finished frobbing jeeb/rustly_mpegts [INFO] frobbed toml for jeeb/rustly_mpegts written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jeeb/rustly_mpegts/Cargo.toml [INFO] crate jeeb/rustly_mpegts has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jeeb/rustly_mpegts against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jeeb/rustly_mpegts:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5210be1826e5672b848e2f5127889aae103ff487acc6076693066505bbfd0c87 [INFO] running `"docker" "start" "-a" "5210be1826e5672b848e2f5127889aae103ff487acc6076693066505bbfd0c87"` [INFO] [stderr] Checking rustly_mpegts v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused imports: `BigEndian`, `ReadBytesExt` [INFO] [stderr] --> src/main.rs:16:17 [INFO] [stderr] | [INFO] [stderr] 16 | use byteorder::{BigEndian, ReadBytesExt}; [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | return self.pid == 0x00; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.pid == 0x00` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | return (self.adaptation_field_control & 0b10) != 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.adaptation_field_control & 0b10) != 0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | return (self.adaptation_field_control & 0b01) != 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.adaptation_field_control & 0b01) != 0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | / return Ok(TransportPacket { [INFO] [stderr] 150 | | header: header, [INFO] [stderr] 151 | | adaptation_field: af, [INFO] [stderr] 152 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 149 | Ok(TransportPacket { [INFO] [stderr] 150 | header: header, [INFO] [stderr] 151 | adaptation_field: af, [INFO] [stderr] 152 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:94:50 [INFO] [stderr] | [INFO] [stderr] 94 | transport_error_indicator: (buf[1] & 0b10000000) != 0, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:95:53 [INFO] [stderr] | [INFO] [stderr] 95 | payload_unit_start_indicator: (buf[1] & 0b01000000) != 0, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:96:43 [INFO] [stderr] | [INFO] [stderr] 96 | transport_priority: (buf[1] & 0b00100000) != 0, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:97:63 [INFO] [stderr] | [INFO] [stderr] 97 | pid: (((buf[1] as u16) << 8) | (buf[2] as u16)) & 0b0001111111111111, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0b0001_1111_1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:98:53 [INFO] [stderr] | [INFO] [stderr] 98 | transport_scrambling_control: (buf[3] & 0b11000000) >> 6, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:99:49 [INFO] [stderr] | [INFO] [stderr] 99 | adaptation_field_control: (buf[3] & 0b00110000) >> 4, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:128:73 [INFO] [stderr] | [INFO] [stderr] 128 | discontinuity_indicator: (af_data[1] & 0b10000000) != 0, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:129:73 [INFO] [stderr] | [INFO] [stderr] 129 | random_access_indicator: (af_data[1] & 0b01000000) != 0, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:130:73 [INFO] [stderr] | [INFO] [stderr] 130 | elementary_stream_priority_indicator: (af_data[1] & 0b00100000) != 0, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:131:73 [INFO] [stderr] | [INFO] [stderr] 131 | pcr_flag: (af_data[1] & 0b00010000) != 0, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:132:73 [INFO] [stderr] | [INFO] [stderr] 132 | opcr_flag: (af_data[1] & 0b00001000) != 0, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:133:73 [INFO] [stderr] | [INFO] [stderr] 133 | splicing_point_flag: (af_data[1] & 0b00000100) != 0, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:134:73 [INFO] [stderr] | [INFO] [stderr] 134 | transport_private_data_flag: (af_data[1] & 0b00000010) != 0, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:135:73 [INFO] [stderr] | [INFO] [stderr] 135 | adaptation_field_extension_flag: (af_data[1] & 0b00000001) != 0, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:156:9 [INFO] [stderr] | [INFO] [stderr] 156 | return self.header.is_pat(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.header.is_pat()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:160:9 [INFO] [stderr] | [INFO] [stderr] 160 | return self.header.has_adaptation_field(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.header.has_adaptation_field()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:164:9 [INFO] [stderr] | [INFO] [stderr] 164 | return self.header.has_payload(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.header.has_payload()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:223:13 [INFO] [stderr] | [INFO] [stderr] 223 | return Err(std::io::Error::new(std::io::ErrorKind::Other, why)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(std::io::Error::new(std::io::ErrorKind::Other, why))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:226:13 [INFO] [stderr] | [INFO] [stderr] 226 | return Ok(tp); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(tp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused imports: `BigEndian`, `ReadBytesExt` [INFO] [stderr] --> src/main.rs:16:17 [INFO] [stderr] | [INFO] [stderr] 16 | use byteorder::{BigEndian, ReadBytesExt}; [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | return self.pid == 0x00; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.pid == 0x00` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | return (self.adaptation_field_control & 0b10) != 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.adaptation_field_control & 0b10) != 0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | return (self.adaptation_field_control & 0b01) != 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.adaptation_field_control & 0b01) != 0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | / return Ok(TransportPacket { [INFO] [stderr] 150 | | header: header, [INFO] [stderr] 151 | | adaptation_field: af, [INFO] [stderr] 152 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 149 | Ok(TransportPacket { [INFO] [stderr] 150 | header: header, [INFO] [stderr] 151 | adaptation_field: af, [INFO] [stderr] 152 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:94:50 [INFO] [stderr] | [INFO] [stderr] 94 | transport_error_indicator: (buf[1] & 0b10000000) != 0, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:95:53 [INFO] [stderr] | [INFO] [stderr] 95 | payload_unit_start_indicator: (buf[1] & 0b01000000) != 0, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:96:43 [INFO] [stderr] | [INFO] [stderr] 96 | transport_priority: (buf[1] & 0b00100000) != 0, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:97:63 [INFO] [stderr] | [INFO] [stderr] 97 | pid: (((buf[1] as u16) << 8) | (buf[2] as u16)) & 0b0001111111111111, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0b0001_1111_1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:98:53 [INFO] [stderr] | [INFO] [stderr] 98 | transport_scrambling_control: (buf[3] & 0b11000000) >> 6, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:99:49 [INFO] [stderr] | [INFO] [stderr] 99 | adaptation_field_control: (buf[3] & 0b00110000) >> 4, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:128:73 [INFO] [stderr] | [INFO] [stderr] 128 | discontinuity_indicator: (af_data[1] & 0b10000000) != 0, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:129:73 [INFO] [stderr] | [INFO] [stderr] 129 | random_access_indicator: (af_data[1] & 0b01000000) != 0, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:130:73 [INFO] [stderr] | [INFO] [stderr] 130 | elementary_stream_priority_indicator: (af_data[1] & 0b00100000) != 0, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:131:73 [INFO] [stderr] | [INFO] [stderr] 131 | pcr_flag: (af_data[1] & 0b00010000) != 0, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:132:73 [INFO] [stderr] | [INFO] [stderr] 132 | opcr_flag: (af_data[1] & 0b00001000) != 0, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:133:73 [INFO] [stderr] | [INFO] [stderr] 133 | splicing_point_flag: (af_data[1] & 0b00000100) != 0, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:134:73 [INFO] [stderr] | [INFO] [stderr] 134 | transport_private_data_flag: (af_data[1] & 0b00000010) != 0, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:135:73 [INFO] [stderr] | [INFO] [stderr] 135 | adaptation_field_extension_flag: (af_data[1] & 0b00000001) != 0, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:156:9 [INFO] [stderr] | [INFO] [stderr] 156 | return self.header.is_pat(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.header.is_pat()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:160:9 [INFO] [stderr] | [INFO] [stderr] 160 | return self.header.has_adaptation_field(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.header.has_adaptation_field()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:164:9 [INFO] [stderr] | [INFO] [stderr] 164 | return self.header.has_payload(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.header.has_payload()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:223:13 [INFO] [stderr] | [INFO] [stderr] 223 | return Err(std::io::Error::new(std::io::ErrorKind::Other, why)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(std::io::Error::new(std::io::ErrorKind::Other, why))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:226:13 [INFO] [stderr] | [INFO] [stderr] 226 | return Ok(tp); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(tp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: method is never used: `has_adaptation_field` [INFO] [stderr] --> src/main.rs:159:5 [INFO] [stderr] | [INFO] [stderr] 159 | pub fn has_adaptation_field(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] warning: method is never used: `has_adaptation_field` [INFO] [stderr] --> src/main.rs:159:5 [INFO] [stderr] | [INFO] [stderr] 159 | pub fn has_adaptation_field(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `has_payload` [INFO] [stderr] --> src/main.rs:163:5 [INFO] [stderr] | [INFO] [stderr] 163 | pub fn has_payload(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `has_payload` [INFO] [stderr] --> src/main.rs:163:5 [INFO] [stderr] | [INFO] [stderr] 163 | pub fn has_payload(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | / let mut af: Option = None; [INFO] [stderr] 105 | | [INFO] [stderr] 106 | | if header.has_adaptation_field() { [INFO] [stderr] 107 | | let af_data = &buf[4 ..]; [INFO] [stderr] ... | [INFO] [stderr] 142 | | }); [INFO] [stderr] 143 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 104 | let af = if header.has_adaptation_field() { ..; Some(AdaptationField { [INFO] [stderr] 105 | length: af_length, [INFO] [stderr] 106 | header: af_header, [INFO] [stderr] 107 | }) } else { None }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | / let mut af: Option = None; [INFO] [stderr] 105 | | [INFO] [stderr] 106 | | if header.has_adaptation_field() { [INFO] [stderr] 107 | | let af_data = &buf[4 ..]; [INFO] [stderr] ... | [INFO] [stderr] 142 | | }); [INFO] [stderr] 143 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 104 | let af = if header.has_adaptation_field() { ..; Some(AdaptationField { [INFO] [stderr] 105 | length: af_length, [INFO] [stderr] 106 | header: af_header, [INFO] [stderr] 107 | }) } else { None }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:97:20 [INFO] [stderr] | [INFO] [stderr] 97 | pid: (((buf[1] as u16) << 8) | (buf[2] as u16)) & 0b0001111111111111, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:97:44 [INFO] [stderr] | [INFO] [stderr] 97 | pid: (((buf[1] as u16) << 8) | (buf[2] as u16)) & 0b0001111111111111, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:97:20 [INFO] [stderr] | [INFO] [stderr] 97 | pid: (((buf[1] as u16) << 8) | (buf[2] as u16)) & 0b0001111111111111, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | / match header.has_payload() { [INFO] [stderr] 114 | | true => { [INFO] [stderr] 115 | | if af_length > 182 { [INFO] [stderr] 116 | | return Err(format!("AdaptationField length too large! ({})", af_length)); [INFO] [stderr] ... | [INFO] [stderr] 123 | | }, [INFO] [stderr] 124 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:97:44 [INFO] [stderr] | [INFO] [stderr] 97 | pid: (((buf[1] as u16) << 8) | (buf[2] as u16)) & 0b0001111111111111, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 113 | if header.has_payload() { [INFO] [stderr] 114 | if af_length > 182 { [INFO] [stderr] 115 | return Err(format!("AdaptationField length too large! ({})", af_length)); [INFO] [stderr] 116 | } [INFO] [stderr] 117 | } else { [INFO] [stderr] 118 | if af_length != 183 { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | / match header.has_payload() { [INFO] [stderr] 114 | | true => { [INFO] [stderr] 115 | | if af_length > 182 { [INFO] [stderr] 116 | | return Err(format!("AdaptationField length too large! ({})", af_length)); [INFO] [stderr] ... | [INFO] [stderr] 123 | | }, [INFO] [stderr] 124 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 113 | if header.has_payload() { [INFO] [stderr] 114 | if af_length > 182 { [INFO] [stderr] 115 | return Err(format!("AdaptationField length too large! ({})", af_length)); [INFO] [stderr] 116 | } [INFO] [stderr] 117 | } else { [INFO] [stderr] 118 | if af_length != 183 { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.16s [INFO] running `"docker" "inspect" "5210be1826e5672b848e2f5127889aae103ff487acc6076693066505bbfd0c87"` [INFO] running `"docker" "rm" "-f" "5210be1826e5672b848e2f5127889aae103ff487acc6076693066505bbfd0c87"` [INFO] [stdout] 5210be1826e5672b848e2f5127889aae103ff487acc6076693066505bbfd0c87