[INFO] updating cached repository jearbear/cl-bot [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jearbear/cl-bot [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jearbear/cl-bot" "work/ex/clippy-test-run/sources/stable/gh/jearbear/cl-bot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jearbear/cl-bot'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jearbear/cl-bot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jearbear/cl-bot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jearbear/cl-bot'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4737d4c4c187751f05cfa08d20eb1cd22e670393 [INFO] sha for GitHub repo jearbear/cl-bot: 4737d4c4c187751f05cfa08d20eb1cd22e670393 [INFO] validating manifest of jearbear/cl-bot on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jearbear/cl-bot on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jearbear/cl-bot [INFO] finished frobbing jearbear/cl-bot [INFO] frobbed toml for jearbear/cl-bot written to work/ex/clippy-test-run/sources/stable/gh/jearbear/cl-bot/Cargo.toml [INFO] started frobbing jearbear/cl-bot [INFO] finished frobbing jearbear/cl-bot [INFO] frobbed toml for jearbear/cl-bot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jearbear/cl-bot/Cargo.toml [INFO] crate jearbear/cl-bot has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jearbear/cl-bot against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jearbear/cl-bot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 780c76c54a713e24f3ca622daff03108b21a21a8586e3ca4a0c4bd8f017ed1a8 [INFO] running `"docker" "start" "-a" "780c76c54a713e24f3ca622daff03108b21a21a8586e3ca4a0c4bd8f017ed1a8"` [INFO] [stderr] Compiling libsqlite3-sys v0.10.0 [INFO] [stderr] Checking nom v4.1.1 [INFO] [stderr] Compiling syn v0.15.18 [INFO] [stderr] Checking tokio-threadpool v0.1.8 [INFO] [stderr] Checking regex v1.0.5 [INFO] [stderr] Compiling string_cache_codegen v0.4.2 [INFO] [stderr] Checking tokio-reactor v0.1.6 [INFO] [stderr] Compiling string_cache v0.6.2 [INFO] [stderr] Compiling markup5ever v0.3.2 [INFO] [stderr] Checking tokio-fs v0.1.4 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio-uds v0.2.3 [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Checking tokio v0.1.11 [INFO] [stderr] Checking hyper v0.12.13 [INFO] [stderr] Compiling synstructure v0.10.1 [INFO] [stderr] Compiling structopt-derive v0.2.13 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Compiling failure_derive v0.1.3 [INFO] [stderr] Checking html5ever v0.18.0 [INFO] [stderr] Checking structopt v0.2.13 [INFO] [stderr] Checking failure v0.1.3 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking select v0.4.2 [INFO] [stderr] Checking reqwest v0.9.4 [INFO] [stderr] Checking rusqlite v0.15.0 [INFO] [stderr] Checking cl-bot v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/listing.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | price: price, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `price` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/listing.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | title: title, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `title` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/listing.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | location: location, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `location` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/telegram.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | chat_id: chat_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `chat_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/listing.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | price: price, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `price` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/listing.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | title: title, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `title` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/listing.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | location: location, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `location` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/telegram.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | chat_id: chat_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `chat_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/listing.rs:62:14 [INFO] [stderr] | [INFO] [stderr] 62 | .ok_or(format_err!("url not found"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("url not found"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/listing.rs:60:14 [INFO] [stderr] | [INFO] [stderr] 60 | .ok_or(format_err!("url not found"))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("url not found"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/listing.rs:67:14 [INFO] [stderr] | [INFO] [stderr] 67 | .ok_or(format_err!("price not found"))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("price not found"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/listing.rs:74:14 [INFO] [stderr] | [INFO] [stderr] 74 | .ok_or(format_err!("name not found"))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("name not found"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/listing.rs:80:14 [INFO] [stderr] | [INFO] [stderr] 80 | .ok_or(format_err!("location not found"))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("location not found"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/listing.rs:87:14 [INFO] [stderr] | [INFO] [stderr] 87 | .ok_or(format_err!("map not found"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("map not found"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/listing.rs:90:14 [INFO] [stderr] | [INFO] [stderr] 90 | .ok_or(format_err!("latitude not found"))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("latitude not found"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/listing.rs:94:14 [INFO] [stderr] | [INFO] [stderr] 94 | .ok_or(format_err!("longitude not found"))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("longitude not found"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/listing.rs:62:14 [INFO] [stderr] | [INFO] [stderr] 62 | .ok_or(format_err!("url not found"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("url not found"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/listing.rs:60:14 [INFO] [stderr] | [INFO] [stderr] 60 | .ok_or(format_err!("url not found"))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("url not found"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/listing.rs:67:14 [INFO] [stderr] | [INFO] [stderr] 67 | .ok_or(format_err!("price not found"))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("price not found"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/listing.rs:74:14 [INFO] [stderr] | [INFO] [stderr] 74 | .ok_or(format_err!("name not found"))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("name not found"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/listing.rs:80:14 [INFO] [stderr] | [INFO] [stderr] 80 | .ok_or(format_err!("location not found"))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("location not found"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/listing.rs:87:14 [INFO] [stderr] | [INFO] [stderr] 87 | .ok_or(format_err!("map not found"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("map not found"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/listing.rs:90:14 [INFO] [stderr] | [INFO] [stderr] 90 | .ok_or(format_err!("latitude not found"))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("latitude not found"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/listing.rs:94:14 [INFO] [stderr] | [INFO] [stderr] 94 | .ok_or(format_err!("longitude not found"))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("longitude not found"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 55.26s [INFO] running `"docker" "inspect" "780c76c54a713e24f3ca622daff03108b21a21a8586e3ca4a0c4bd8f017ed1a8"` [INFO] running `"docker" "rm" "-f" "780c76c54a713e24f3ca622daff03108b21a21a8586e3ca4a0c4bd8f017ed1a8"` [INFO] [stdout] 780c76c54a713e24f3ca622daff03108b21a21a8586e3ca4a0c4bd8f017ed1a8