[INFO] updating cached repository jdomenechb/rustiegb
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/jdomenechb/rustiegb
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/jdomenechb/rustiegb" "work/ex/clippy-test-run/sources/stable/gh/jdomenechb/rustiegb"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jdomenechb/rustiegb'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/jdomenechb/rustiegb" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jdomenechb/rustiegb"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jdomenechb/rustiegb'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] e067c3b4a32b55de6c06d60596d604c010a46a63
[INFO] sha for GitHub repo jdomenechb/rustiegb: e067c3b4a32b55de6c06d60596d604c010a46a63
[INFO] validating manifest of jdomenechb/rustiegb on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of jdomenechb/rustiegb on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing jdomenechb/rustiegb
[INFO] finished frobbing jdomenechb/rustiegb
[INFO] frobbed toml for jdomenechb/rustiegb written to work/ex/clippy-test-run/sources/stable/gh/jdomenechb/rustiegb/Cargo.toml
[INFO] started frobbing jdomenechb/rustiegb
[INFO] finished frobbing jdomenechb/rustiegb
[INFO] frobbed toml for jdomenechb/rustiegb written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jdomenechb/rustiegb/Cargo.toml
[INFO] crate jdomenechb/rustiegb has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting jdomenechb/rustiegb against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jdomenechb/rustiegb:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] e53cb5444699a9d0ce1429acf2d5b2b1e04a81a8616437a119d4b0d7614f9260
[INFO] running `"docker" "start" "-a" "e53cb5444699a9d0ce1429acf2d5b2b1e04a81a8616437a119d4b0d7614f9260"`
[INFO] [stderr]    Compiling xml-rs v0.8.0
[INFO] [stderr]    Compiling khronos_api v3.0.0
[INFO] [stderr]     Checking nix v0.12.0
[INFO] [stderr]     Checking memmap v0.7.0
[INFO] [stderr]     Checking approx v0.3.0
[INFO] [stderr]     Checking line_drawing v0.7.0
[INFO] [stderr]     Checking wayland-sys v0.21.7
[INFO] [stderr]    Compiling num-derive v0.2.3
[INFO] [stderr]     Checking pistoncore-input v0.23.0
[INFO] [stderr]     Checking wayland-commons v0.21.7
[INFO] [stderr]     Checking rusttype v0.7.3
[INFO] [stderr]     Checking andrew v0.1.4
[INFO] [stderr]     Checking piston2d-graphics v0.28.0
[INFO] [stderr]    Compiling wayland-scanner v0.21.7
[INFO] [stderr]    Compiling gl_generator v0.10.0
[INFO] [stderr]     Checking pistoncore-window v0.34.0
[INFO] [stderr]    Compiling gl v0.11.0
[INFO] [stderr]    Compiling glutin v0.19.0
[INFO] [stderr]    Compiling wayland-client v0.21.7
[INFO] [stderr]    Compiling wayland-protocols v0.21.7
[INFO] [stderr]     Checking tiff v0.2.1
[INFO] [stderr]     Checking pistoncore-event_loop v0.39.0
[INFO] [stderr]     Checking image v0.20.1
[INFO] [stderr]     Checking piston v0.39.0
[INFO] [stderr]     Checking piston2d-opengl_graphics v0.57.0
[INFO] [stderr]     Checking smithay-client-toolkit v0.4.3
[INFO] [stderr]     Checking winit v0.18.0
[INFO] [stderr]     Checking pistoncore-glutin_window v0.51.1
[INFO] [stderr]     Checking rustiegb v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]  --> src/memory/read_only_memory_sector.rs:8:13
[INFO] [stderr]   |
[INFO] [stderr] 8 |             data: data
[INFO] [stderr]   |             ^^^^^^^^^^ help: replace it with: `data`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/gpu/gpu.rs:15:13
[INFO] [stderr]    |
[INFO] [stderr] 15 |             gl: gl,
[INFO] [stderr]    |             ^^^^^^ help: replace it with: `gl`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]  --> src/memory/read_only_memory_sector.rs:8:13
[INFO] [stderr]   |
[INFO] [stderr] 8 |             data: data
[INFO] [stderr]   |             ^^^^^^^^^^ help: replace it with: `data`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/gpu/gpu.rs:15:13
[INFO] [stderr]    |
[INFO] [stderr] 15 |             gl: gl,
[INFO] [stderr]    |             ^^^^^^ help: replace it with: `gl`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]  --> src/cpu/mod.rs:1:1
[INFO] [stderr]   |
[INFO] [stderr] 1 | pub mod cpu;
[INFO] [stderr]   | ^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::module_inception)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cpu/cpu.rs:21:9
[INFO] [stderr]    |
[INFO] [stderr] 21 | /         return CPU {
[INFO] [stderr] 22 | |             registers: CPURegisters::new(),
[INFO] [stderr] 23 | |             alu: ALU {},
[INFO] [stderr] 24 | |             trace: false,
[INFO] [stderr] ...  |
[INFO] [stderr] 28 | |             last_instruction_ccycles: -1
[INFO] [stderr] 29 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 21 |         CPU {
[INFO] [stderr] 22 |             registers: CPURegisters::new(),
[INFO] [stderr] 23 |             alu: ALU {},
[INFO] [stderr] 24 |             trace: false,
[INFO] [stderr] 25 |             available_cycles: CPU::AVAILABLE_CCYCLES_PER_FRAME,
[INFO] [stderr] 26 | 
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cpu/cpu.rs:37:9
[INFO] [stderr]    |
[INFO] [stderr] 37 |         return self.available_cycles > 0;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.available_cycles > 0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cpu/cpu.rs:43:9
[INFO] [stderr]    |
[INFO] [stderr] 43 |         return self.last_instruction_ccycles as u8;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.last_instruction_ccycles as u8`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/cpu/cpu.rs:443:22
[INFO] [stderr]     |
[INFO] [stderr] 443 |             new_a |= 0b10000000; 
[INFO] [stderr]     |                      ^^^^^^^^^^ help: consider: `0b1000_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/cpu/cpu.rs:445:23
[INFO] [stderr]     |
[INFO] [stderr] 445 |             new_a &= !0b10000000;
[INFO] [stderr]     |                       ^^^^^^^^^^ help: consider: `0b1000_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]     --> src/cpu/cpu.rs:1478:55
[INFO] [stderr]      |
[INFO] [stderr] 1478 |         let msf : u8 = if self.registers.is_flag_c() {0b10000000} else {0};
[INFO] [stderr]      |                                                       ^^^^^^^^^^ help: consider: `0b1000_0000`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]     --> src/cpu/cpu.rs:1480:61
[INFO] [stderr]      |
[INFO] [stderr] 1480 |         self.registers.c = msf | ((self.registers.c >> 1) & 0b01111111);
[INFO] [stderr]      |                                                             ^^^^^^^^^^ help: consider: `0b0111_1111`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]     --> src/cpu/cpu.rs:1499:55
[INFO] [stderr]      |
[INFO] [stderr] 1499 |         let msf : u8 = if self.registers.is_flag_c() {0b10000000} else {0};
[INFO] [stderr]      |                                                       ^^^^^^^^^^ help: consider: `0b1000_0000`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]     --> src/cpu/cpu.rs:1501:61
[INFO] [stderr]      |
[INFO] [stderr] 1501 |         self.registers.d = msf | ((self.registers.d >> 1) & 0b01111111);
[INFO] [stderr]      |                                                             ^^^^^^^^^^ help: consider: `0b0111_1111`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]     --> src/cpu/cpu.rs:1520:43
[INFO] [stderr]      |
[INFO] [stderr] 1520 |         let msf : u8 = self.registers.b & 0b10000000;
[INFO] [stderr]      |                                           ^^^^^^^^^^ help: consider: `0b1000_0000`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]     --> src/cpu/cpu.rs:1522:61
[INFO] [stderr]      |
[INFO] [stderr] 1522 |         self.registers.b = msf | ((self.registers.b >> 1) & 0b01111111);
[INFO] [stderr]      |                                                             ^^^^^^^^^^ help: consider: `0b0111_1111`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]     --> src/cpu/cpu.rs:1561:9
[INFO] [stderr]      |
[INFO] [stderr] 1561 |         return value;
[INFO] [stderr]      |         ^^^^^^^^^^^^^ help: remove `return` as shown: `value`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cpu/registers.rs:18:9
[INFO] [stderr]    |
[INFO] [stderr] 18 | /         return CPURegisters {
[INFO] [stderr] 19 | |             a: 0x01,
[INFO] [stderr] 20 | |             b: 0x0,
[INFO] [stderr] 21 | |             c: 0x13,
[INFO] [stderr] ...  |
[INFO] [stderr] 40 | |             // flags: 0xB0,
[INFO] [stderr] 41 | |         };
[INFO] [stderr]    | |__________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 18 |         CPURegisters {
[INFO] [stderr] 19 |             a: 0x01,
[INFO] [stderr] 20 |             b: 0x0,
[INFO] [stderr] 21 |             c: 0x13,
[INFO] [stderr] 22 |             d: 0x0,
[INFO] [stderr] 23 |             e: 0xd8,
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cpu/registers.rs:48:9
[INFO] [stderr]    |
[INFO] [stderr] 48 |         return ::math::two_u8_to_u16(self.a, self.f);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `::math::two_u8_to_u16(self.a, self.f)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cpu/registers.rs:61:9
[INFO] [stderr]    |
[INFO] [stderr] 61 |         return ::math::two_u8_to_u16(self.b, self.c);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `::math::two_u8_to_u16(self.b, self.c)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cpu/registers.rs:74:9
[INFO] [stderr]    |
[INFO] [stderr] 74 |         return ::math::two_u8_to_u16(self.d, self.e);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `::math::two_u8_to_u16(self.d, self.e)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cpu/registers.rs:87:9
[INFO] [stderr]    |
[INFO] [stderr] 87 |         return ::math::two_u8_to_u16(self.h, self.l);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `::math::two_u8_to_u16(self.h, self.l)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/cpu/registers.rs:124:9
[INFO] [stderr]     |
[INFO] [stderr] 124 |         return self.flags & 0b10000000 == 0b10000000;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.flags & 0b10000000 == 0b10000000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/cpu/registers.rs:124:29
[INFO] [stderr]     |
[INFO] [stderr] 124 |         return self.flags & 0b10000000 == 0b10000000;
[INFO] [stderr]     |                             ^^^^^^^^^^ help: consider: `0b1000_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/cpu/registers.rs:124:43
[INFO] [stderr]     |
[INFO] [stderr] 124 |         return self.flags & 0b10000000 == 0b10000000;
[INFO] [stderr]     |                                           ^^^^^^^^^^ help: consider: `0b1000_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/cpu/registers.rs:128:9
[INFO] [stderr]     |
[INFO] [stderr] 128 |         return self.flags & 0b00010000 == 0b00010000;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.flags & 0b00010000 == 0b00010000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/cpu/registers.rs:128:29
[INFO] [stderr]     |
[INFO] [stderr] 128 |         return self.flags & 0b00010000 == 0b00010000;
[INFO] [stderr]     |                             ^^^^^^^^^^ help: consider: `0b0001_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/cpu/registers.rs:128:43
[INFO] [stderr]     |
[INFO] [stderr] 128 |         return self.flags & 0b00010000 == 0b00010000;
[INFO] [stderr]     |                                           ^^^^^^^^^^ help: consider: `0b0001_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cpu/alu.rs:25:9
[INFO] [stderr]    |
[INFO] [stderr] 25 |         return value;
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: remove `return` as shown: `value`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cpu/alu.rs:45:9
[INFO] [stderr]    |
[INFO] [stderr] 45 |         return value;
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: remove `return` as shown: `value`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cpu/alu.rs:58:9
[INFO] [stderr]    |
[INFO] [stderr] 58 |         return result;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cpu/alu.rs:70:9
[INFO] [stderr]    |
[INFO] [stderr] 70 |         return result;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cpu/alu.rs:92:9
[INFO] [stderr]    |
[INFO] [stderr] 92 |         return value;
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: remove `return` as shown: `value`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/cpu/alu.rs:101:9
[INFO] [stderr]     |
[INFO] [stderr] 101 |         return value;
[INFO] [stderr]     |         ^^^^^^^^^^^^^ help: remove `return` as shown: `value`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]  --> src/memory/mod.rs:1:1
[INFO] [stderr]   |
[INFO] [stderr] 1 | pub mod memory;
[INFO] [stderr]   | ^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/memory/memory.rs:57:9
[INFO] [stderr]    |
[INFO] [stderr] 57 | /         return Memory {
[INFO] [stderr] 58 | |             rom: ReadOnlyMemorySector::new(data),
[INFO] [stderr] 59 | |             video_ram: VideoRam8kMemorySector::new(),
[INFO] [stderr] 60 | |             internal_ram_8k: InternalRam8kMemorySector::new(),
[INFO] [stderr] ...  |
[INFO] [stderr] 77 | |             interrupt_enable: InterruptFlag::new()
[INFO] [stderr] 78 | |         };
[INFO] [stderr]    | |__________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 57 |         Memory {
[INFO] [stderr] 58 |             rom: ReadOnlyMemorySector::new(data),
[INFO] [stderr] 59 |             video_ram: VideoRam8kMemorySector::new(),
[INFO] [stderr] 60 |             internal_ram_8k: InternalRam8kMemorySector::new(),
[INFO] [stderr] 61 |             serial_transfer_data: 0,
[INFO] [stderr] 62 |             sio_control: 0,
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/memory/memory.rs:164:9
[INFO] [stderr]     |
[INFO] [stderr] 164 |         return 0;
[INFO] [stderr]     |         ^^^^^^^^^ help: remove `return` as shown: `0`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/memory/memory.rs:170:9
[INFO] [stderr]     |
[INFO] [stderr] 170 |         return value as i8;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `value as i8`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/memory/memory.rs:196:9
[INFO] [stderr]     |
[INFO] [stderr] 196 |         return 0;
[INFO] [stderr]     |         ^^^^^^^^^ help: remove `return` as shown: `0`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/memory/internal_ram_memory_sector.rs:7:9
[INFO] [stderr]   |
[INFO] [stderr] 7 | /         return InternalRamMemorySector {
[INFO] [stderr] 8 | |             data: [0; 0x7F]
[INFO] [stderr] 9 | |         };
[INFO] [stderr]   | |__________^
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]   |
[INFO] [stderr] 7 |         InternalRamMemorySector {
[INFO] [stderr] 8 |             data: [0; 0x7F]
[INFO] [stderr] 9 |         }
[INFO] [stderr]   |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/memory/internal_ram_memory_sector.rs:16:9
[INFO] [stderr]    |
[INFO] [stderr] 16 |         return self.data[position as usize];
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.data[position as usize]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/memory/internal_ram_memory_sector.rs:26:9
[INFO] [stderr]    |
[INFO] [stderr] 26 |         return result;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/memory/internal_ram_8k_memory_sector.rs:7:9
[INFO] [stderr]   |
[INFO] [stderr] 7 | /         return InternalRam8kMemorySector {
[INFO] [stderr] 8 | |             data: [0; 0x2000]
[INFO] [stderr] 9 | |         };
[INFO] [stderr]   | |__________^
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]   |
[INFO] [stderr] 7 |         InternalRam8kMemorySector {
[INFO] [stderr] 8 |             data: [0; 0x2000]
[INFO] [stderr] 9 |         }
[INFO] [stderr]   |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/memory/internal_ram_8k_memory_sector.rs:16:9
[INFO] [stderr]    |
[INFO] [stderr] 16 |         return self.data[position as usize];
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.data[position as usize]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/memory/internal_ram_8k_memory_sector.rs:26:9
[INFO] [stderr]    |
[INFO] [stderr] 26 |         return result;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/memory/video_ram_8k_memory_sector.rs:7:9
[INFO] [stderr]   |
[INFO] [stderr] 7 | /         return VideoRam8kMemorySector {
[INFO] [stderr] 8 | |             data: [0; 0x2000]
[INFO] [stderr] 9 | |         };
[INFO] [stderr]   | |__________^
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]   |
[INFO] [stderr] 7 |         VideoRam8kMemorySector {
[INFO] [stderr] 8 |             data: [0; 0x2000]
[INFO] [stderr] 9 |         }
[INFO] [stderr]   |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/memory/video_ram_8k_memory_sector.rs:16:9
[INFO] [stderr]    |
[INFO] [stderr] 16 |         return self.data[position as usize];
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.data[position as usize]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/memory/video_ram_8k_memory_sector.rs:26:9
[INFO] [stderr]    |
[INFO] [stderr] 26 |         return result;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/memory/read_only_memory_sector.rs:7:9
[INFO] [stderr]   |
[INFO] [stderr] 7 | /         return ReadOnlyMemorySector {
[INFO] [stderr] 8 | |             data: data
[INFO] [stderr] 9 | |         };
[INFO] [stderr]   | |__________^
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]   |
[INFO] [stderr] 7 |         ReadOnlyMemorySector {
[INFO] [stderr] 8 |             data: data
[INFO] [stderr] 9 |         }
[INFO] [stderr]   |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/memory/read_only_memory_sector.rs:16:9
[INFO] [stderr]    |
[INFO] [stderr] 16 |         return self.data[position as usize];
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.data[position as usize]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/memory/read_only_memory_sector.rs:26:9
[INFO] [stderr]    |
[INFO] [stderr] 26 |         return result;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/memory/timer_control.rs:9:9
[INFO] [stderr]    |
[INFO] [stderr] 9  | /         return TimerControl {
[INFO] [stderr] 10 | |             started: false,
[INFO] [stderr] 11 | |             period_microseconds: 0.0,
[INFO] [stderr] 12 | |             frecuency_option: 0
[INFO] [stderr] 13 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 9  |         TimerControl {
[INFO] [stderr] 10 |             started: false,
[INFO] [stderr] 11 |             period_microseconds: 0.0,
[INFO] [stderr] 12 |             frecuency_option: 0
[INFO] [stderr] 13 |         }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/memory/timer_control.rs:21:60
[INFO] [stderr]    |
[INFO] [stderr] 21 |             0 => self.period_microseconds = 1.0 / 4096.0 * 1000000.0,
[INFO] [stderr]    |                                                            ^^^^^^^^^ help: consider: `1_000_000.0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/memory/timer_control.rs:22:51
[INFO] [stderr]    |
[INFO] [stderr] 22 |             1 => self.period_microseconds = 1.0 / 262144.0 * 1000000.0,
[INFO] [stderr]    |                                                   ^^^^^^^^ help: consider: `262_144.0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/memory/timer_control.rs:22:62
[INFO] [stderr]    |
[INFO] [stderr] 22 |             1 => self.period_microseconds = 1.0 / 262144.0 * 1000000.0,
[INFO] [stderr]    |                                                              ^^^^^^^^^ help: consider: `1_000_000.0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/memory/timer_control.rs:23:61
[INFO] [stderr]    |
[INFO] [stderr] 23 |             2 => self.period_microseconds = 1.0 / 65536.0 * 1000000.0,
[INFO] [stderr]    |                                                             ^^^^^^^^^ help: consider: `1_000_000.0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/memory/timer_control.rs:24:61
[INFO] [stderr]    |
[INFO] [stderr] 24 |             3 => self.period_microseconds = 1.0 / 16384.0 * 1000000.0,
[INFO] [stderr]    |                                                             ^^^^^^^^^ help: consider: `1_000_000.0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/memory/interrupt_flag.rs:11:9
[INFO] [stderr]    |
[INFO] [stderr] 11 | /         return InterruptFlag {
[INFO] [stderr] 12 | |             p10_13_transition: false,
[INFO] [stderr] 13 | |             serial_io_transfer_complete: false,
[INFO] [stderr] 14 | |             timer_overflow: false,
[INFO] [stderr] 15 | |             lcdc: false,
[INFO] [stderr] 16 | |             vblank: false
[INFO] [stderr] 17 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 11 |         InterruptFlag {
[INFO] [stderr] 12 |             p10_13_transition: false,
[INFO] [stderr] 13 |             serial_io_transfer_complete: false,
[INFO] [stderr] 14 |             timer_overflow: false,
[INFO] [stderr] 15 |             lcdc: false,
[INFO] [stderr] 16 |             vblank: false
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/memory/lcdc.rs:37:9
[INFO] [stderr]    |
[INFO] [stderr] 37 | /         return LCDC {
[INFO] [stderr] 38 | |             lcd_control_operation: false,
[INFO] [stderr] 39 | |             window_tile_map_display_select: true,
[INFO] [stderr] 40 | |             window_display: false,
[INFO] [stderr] ...  |
[INFO] [stderr] 45 | |             bg_and_window_display: true,
[INFO] [stderr] 46 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 37 |         LCDC {
[INFO] [stderr] 38 |             lcd_control_operation: false,
[INFO] [stderr] 39 |             window_tile_map_display_select: true,
[INFO] [stderr] 40 |             window_display: false,
[INFO] [stderr] 41 |             bg_and_window_tile_data_select: true,
[INFO] [stderr] 42 |             bg_tile_map_display_select: true,
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/memory/lcdc.rs:50:46
[INFO] [stderr]    |
[INFO] [stderr] 50 |         self.lcd_control_operation = value & 0b10000000 == 0b10000000;
[INFO] [stderr]    |                                              ^^^^^^^^^^ help: consider: `0b1000_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/memory/lcdc.rs:50:60
[INFO] [stderr]    |
[INFO] [stderr] 50 |         self.lcd_control_operation = value & 0b10000000 == 0b10000000;
[INFO] [stderr]    |                                                            ^^^^^^^^^^ help: consider: `0b1000_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/memory/lcdc.rs:51:55
[INFO] [stderr]    |
[INFO] [stderr] 51 |         self.window_tile_map_display_select = value & 0b01000000 == 0b01000000;
[INFO] [stderr]    |                                                       ^^^^^^^^^^ help: consider: `0b0100_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/memory/lcdc.rs:51:69
[INFO] [stderr]    |
[INFO] [stderr] 51 |         self.window_tile_map_display_select = value & 0b01000000 == 0b01000000;
[INFO] [stderr]    |                                                                     ^^^^^^^^^^ help: consider: `0b0100_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/memory/lcdc.rs:52:39
[INFO] [stderr]    |
[INFO] [stderr] 52 |         self.window_display = value & 0b00100000 == 0b00100000;
[INFO] [stderr]    |                                       ^^^^^^^^^^ help: consider: `0b0010_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/memory/lcdc.rs:52:53
[INFO] [stderr]    |
[INFO] [stderr] 52 |         self.window_display = value & 0b00100000 == 0b00100000;
[INFO] [stderr]    |                                                     ^^^^^^^^^^ help: consider: `0b0010_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/memory/stat.rs:13:9
[INFO] [stderr]    |
[INFO] [stderr] 13 | /         return STAT {
[INFO] [stderr] 14 | |             mode: 0,
[INFO] [stderr] 15 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 13 |         STAT {
[INFO] [stderr] 14 |             mode: 0,
[INFO] [stderr] 15 |         }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/memory/stat.rs:23:9
[INFO] [stderr]    |
[INFO] [stderr] 23 |         return self.mode;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.mode`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/math/mod.rs:3:5
[INFO] [stderr]   |
[INFO] [stderr] 3 |     return(result << 8) + (l as u16);
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(result << 8) + (l as u16)`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/math/mod.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 |     return (high, low);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(high, low)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]  --> src/gpu/mod.rs:1:1
[INFO] [stderr]   |
[INFO] [stderr] 1 | pub mod gpu;
[INFO] [stderr]   | ^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/gpu/gpu.rs:14:9
[INFO] [stderr]    |
[INFO] [stderr] 14 | /         return GPU {
[INFO] [stderr] 15 | |             gl: gl,
[INFO] [stderr] 16 | |             cycles_acumulated: 0,
[INFO] [stderr] 17 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 14 |         GPU {
[INFO] [stderr] 15 |             gl: gl,
[INFO] [stderr] 16 |             cycles_acumulated: 0,
[INFO] [stderr] 17 |         }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::thread::sleep`
[INFO] [stderr]   --> src/main.rs:14:5
[INFO] [stderr]    |
[INFO] [stderr] 14 | use std::thread::sleep;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::time::Duration`
[INFO] [stderr]   --> src/main.rs:15:5
[INFO] [stderr]    |
[INFO] [stderr] 15 | use std::time::Duration;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unreachable statement
[INFO] [stderr]    --> src/memory/memory.rs:164:9
[INFO] [stderr]     |
[INFO] [stderr] 164 |         return 0;
[INFO] [stderr]     |         ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unreachable_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unreachable statement
[INFO] [stderr]    --> src/memory/memory.rs:196:9
[INFO] [stderr]     |
[INFO] [stderr] 196 |         return 0;
[INFO] [stderr]     |         ^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `args`
[INFO] [stderr]   --> src/gpu/gpu.rs:93:30
[INFO] [stderr]    |
[INFO] [stderr] 93 |     pub fn update(&mut self, args: &UpdateArgs) {
[INFO] [stderr]    |                              ^^^^ help: consider using `_args` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: associated const is never used: `DARK_GRAY`
[INFO] [stderr]  --> src/gpu/color.rs:6:5
[INFO] [stderr]   |
[INFO] [stderr] 6 |     pub const DARK_GRAY:  [f32; 4] = [0.3333, 0.3333, 0.3333, 1.0];
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: associated const is never used: `GRAY`
[INFO] [stderr]  --> src/gpu/color.rs:7:5
[INFO] [stderr]   |
[INFO] [stderr] 7 |     pub const GRAY:  [f32; 4] = [0.6667, 0.6667, 0.6667, 1.0];
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu/cpu.rs:170:34
[INFO] [stderr]     |
[INFO] [stderr] 170 |         self.available_cycles -= self.last_instruction_ccycles as i32;
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.last_instruction_ccycles)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] error: equal expressions as operands to `^`
[INFO] [stderr]    --> src/cpu/cpu.rs:460:28
[INFO] [stderr]     |
[INFO] [stderr] 460 |         self.registers.a = self.registers.a ^ self.registers.a;
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::eq_op)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/cpu/cpu.rs:479:9
[INFO] [stderr]     |
[INFO] [stderr] 479 |         self.registers.a = self.registers.c ^ self.registers.a;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.registers.a ^= self.registers.c`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/cpu/cpu.rs:499:9
[INFO] [stderr]     |
[INFO] [stderr] 499 |         self.registers.a = value ^ self.registers.a;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.registers.a ^= value`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/cpu/cpu.rs:519:9
[INFO] [stderr]     |
[INFO] [stderr] 519 |         self.registers.a = value ^ self.registers.a;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.registers.a ^= value`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu/cpu.rs:937:27
[INFO] [stderr]     |
[INFO] [stderr] 937 |         let to_sum: u16 = memory.read_8(self.registers.pc + 1) as u16;
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(memory.read_8(self.registers.pc + 1))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu/cpu.rs:953:27
[INFO] [stderr]     |
[INFO] [stderr] 953 |         let to_sum: u16 = memory.read_8(self.registers.pc + 1) as u16;
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(memory.read_8(self.registers.pc + 1))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change
[INFO] [stderr]     --> src/cpu/cpu.rs:1160:61
[INFO] [stderr]      |
[INFO] [stderr] 1160 |             self.registers.pc = (self.registers.pc as i16 + possible_value as i16) as u16;
[INFO] [stderr]      |                                                             ^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(possible_value)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change
[INFO] [stderr]     --> src/cpu/cpu.rs:1180:61
[INFO] [stderr]      |
[INFO] [stderr] 1180 |             self.registers.pc = (self.registers.pc as i16 + possible_value as i16) as u16;
[INFO] [stderr]      |                                                             ^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(possible_value)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change
[INFO] [stderr]     --> src/cpu/cpu.rs:1200:61
[INFO] [stderr]      |
[INFO] [stderr] 1200 |             self.registers.pc = (self.registers.pc as i16 + possible_value as i16) as u16;
[INFO] [stderr]      |                                                             ^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(possible_value)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change
[INFO] [stderr]     --> src/cpu/cpu.rs:1220:61
[INFO] [stderr]      |
[INFO] [stderr] 1220 |             self.registers.pc = (self.registers.pc as i16 + possible_value as i16) as u16;
[INFO] [stderr]      |                                                             ^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(possible_value)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]     --> src/cpu/cpu.rs:1554:9
[INFO] [stderr]      |
[INFO] [stderr] 1554 |         self.registers.sp = self.registers.sp - 2;
[INFO] [stderr]      |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.registers.sp -= 2`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/alu.rs:14:28
[INFO] [stderr]    |
[INFO] [stderr] 14 |         let carry: bool = (a as u16 + b as u16) & 0x100 == 0x100;
[INFO] [stderr]    |                            ^^^^^^^^ help: try: `u16::from(a)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/alu.rs:14:39
[INFO] [stderr]    |
[INFO] [stderr] 14 |         let carry: bool = (a as u16 + b as u16) & 0x100 == 0x100;
[INFO] [stderr]    |                                       ^^^^^^^^ help: try: `u16::from(b)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/memory/internal_ram_memory_sector.rs:24:31
[INFO] [stderr]    |
[INFO] [stderr] 24 |         let mut result: u16 = self.data[position] as u16;
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.data[position])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/memory/internal_ram_memory_sector.rs:25:19
[INFO] [stderr]    |
[INFO] [stderr] 25 |         result += (self.data[position + 1] as u16) << 8;
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.data[position + 1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/memory/internal_ram_8k_memory_sector.rs:24:31
[INFO] [stderr]    |
[INFO] [stderr] 24 |         let mut result: u16 = self.data[position] as u16;
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.data[position])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/memory/internal_ram_8k_memory_sector.rs:25:19
[INFO] [stderr]    |
[INFO] [stderr] 25 |         result += (self.data[position + 1] as u16) << 8;
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.data[position + 1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/memory/video_ram_8k_memory_sector.rs:24:31
[INFO] [stderr]    |
[INFO] [stderr] 24 |         let mut result: u16 = self.data[position] as u16;
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.data[position])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/memory/video_ram_8k_memory_sector.rs:25:19
[INFO] [stderr]    |
[INFO] [stderr] 25 |         result += (self.data[position + 1] as u16) << 8;
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.data[position + 1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/memory/read_only_memory_sector.rs:24:31
[INFO] [stderr]    |
[INFO] [stderr] 24 |         let mut result: u16 = self.data[position] as u16;
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.data[position])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/memory/read_only_memory_sector.rs:25:19
[INFO] [stderr]    |
[INFO] [stderr] 25 |         result += (self.data[position + 1] as u16) << 8;
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.data[position + 1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/memory/timer_control.rs:16:20
[INFO] [stderr]    |
[INFO] [stderr] 16 |     pub fn from_u8(&mut self, value: u8) {
[INFO] [stderr]    |                    ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/memory/interrupt_flag.rs:20:20
[INFO] [stderr]    |
[INFO] [stderr] 20 |     pub fn from_u8(&mut self, value: u8) {
[INFO] [stderr]    |                    ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/memory/lcdc.rs:49:20
[INFO] [stderr]    |
[INFO] [stderr] 49 |     pub fn from_u8(&mut self, value: u8) {
[INFO] [stderr]    |                    ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/memory/stat.rs:18:20
[INFO] [stderr]    |
[INFO] [stderr] 18 |     pub fn from_u8(&mut self, value: u8) {
[INFO] [stderr]    |                    ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]  --> src/math/mod.rs:2:22
[INFO] [stderr]   |
[INFO] [stderr] 2 |     let result:u16 = h as u16;
[INFO] [stderr]   |                      ^^^^^^^^ help: try: `u16::from(h)`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]  --> src/math/mod.rs:3:27
[INFO] [stderr]   |
[INFO] [stderr] 3 |     return(result << 8) + (l as u16);
[INFO] [stderr]   |                           ^^^^^^^^^^ help: try: `u16::from(l)`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/gpu/gpu.rs:22:35
[INFO] [stderr]    |
[INFO] [stderr] 22 |         self.cycles_acumulated += last_instruction_cycles as u16;
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(last_instruction_cycles)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/gpu/gpu.rs:93:36
[INFO] [stderr]    |
[INFO] [stderr] 93 |     pub fn update(&mut self, args: &UpdateArgs) {
[INFO] [stderr]    |                                    ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] error: any number modulo 1 will be 0
[INFO] [stderr]   --> src/main.rs:56:25
[INFO] [stderr]    |
[INFO] [stderr] 56 |             if debug && i % 1 == 0 {
[INFO] [stderr]    |                         ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::modulo_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#modulo_one
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `rustiegb`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]  --> src/cpu/mod.rs:1:1
[INFO] [stderr]   |
[INFO] [stderr] 1 | pub mod cpu;
[INFO] [stderr]   | ^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::module_inception)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cpu/cpu.rs:21:9
[INFO] [stderr]    |
[INFO] [stderr] 21 | /         return CPU {
[INFO] [stderr] 22 | |             registers: CPURegisters::new(),
[INFO] [stderr] 23 | |             alu: ALU {},
[INFO] [stderr] 24 | |             trace: false,
[INFO] [stderr] ...  |
[INFO] [stderr] 28 | |             last_instruction_ccycles: -1
[INFO] [stderr] 29 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 21 |         CPU {
[INFO] [stderr] 22 |             registers: CPURegisters::new(),
[INFO] [stderr] 23 |             alu: ALU {},
[INFO] [stderr] 24 |             trace: false,
[INFO] [stderr] 25 |             available_cycles: CPU::AVAILABLE_CCYCLES_PER_FRAME,
[INFO] [stderr] 26 | 
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cpu/cpu.rs:37:9
[INFO] [stderr]    |
[INFO] [stderr] 37 |         return self.available_cycles > 0;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.available_cycles > 0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cpu/cpu.rs:43:9
[INFO] [stderr]    |
[INFO] [stderr] 43 |         return self.last_instruction_ccycles as u8;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.last_instruction_ccycles as u8`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/cpu/cpu.rs:443:22
[INFO] [stderr]     |
[INFO] [stderr] 443 |             new_a |= 0b10000000; 
[INFO] [stderr]     |                      ^^^^^^^^^^ help: consider: `0b1000_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/cpu/cpu.rs:445:23
[INFO] [stderr]     |
[INFO] [stderr] 445 |             new_a &= !0b10000000;
[INFO] [stderr]     |                       ^^^^^^^^^^ help: consider: `0b1000_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]     --> src/cpu/cpu.rs:1478:55
[INFO] [stderr]      |
[INFO] [stderr] 1478 |         let msf : u8 = if self.registers.is_flag_c() {0b10000000} else {0};
[INFO] [stderr]      |                                                       ^^^^^^^^^^ help: consider: `0b1000_0000`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]     --> src/cpu/cpu.rs:1480:61
[INFO] [stderr]      |
[INFO] [stderr] 1480 |         self.registers.c = msf | ((self.registers.c >> 1) & 0b01111111);
[INFO] [stderr]      |                                                             ^^^^^^^^^^ help: consider: `0b0111_1111`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]     --> src/cpu/cpu.rs:1499:55
[INFO] [stderr]      |
[INFO] [stderr] 1499 |         let msf : u8 = if self.registers.is_flag_c() {0b10000000} else {0};
[INFO] [stderr]      |                                                       ^^^^^^^^^^ help: consider: `0b1000_0000`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]     --> src/cpu/cpu.rs:1501:61
[INFO] [stderr]      |
[INFO] [stderr] 1501 |         self.registers.d = msf | ((self.registers.d >> 1) & 0b01111111);
[INFO] [stderr]      |                                                             ^^^^^^^^^^ help: consider: `0b0111_1111`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]     --> src/cpu/cpu.rs:1520:43
[INFO] [stderr]      |
[INFO] [stderr] 1520 |         let msf : u8 = self.registers.b & 0b10000000;
[INFO] [stderr]      |                                           ^^^^^^^^^^ help: consider: `0b1000_0000`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]     --> src/cpu/cpu.rs:1522:61
[INFO] [stderr]      |
[INFO] [stderr] 1522 |         self.registers.b = msf | ((self.registers.b >> 1) & 0b01111111);
[INFO] [stderr]      |                                                             ^^^^^^^^^^ help: consider: `0b0111_1111`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]     --> src/cpu/cpu.rs:1561:9
[INFO] [stderr]      |
[INFO] [stderr] 1561 |         return value;
[INFO] [stderr]      |         ^^^^^^^^^^^^^ help: remove `return` as shown: `value`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cpu/registers.rs:18:9
[INFO] [stderr]    |
[INFO] [stderr] 18 | /         return CPURegisters {
[INFO] [stderr] 19 | |             a: 0x01,
[INFO] [stderr] 20 | |             b: 0x0,
[INFO] [stderr] 21 | |             c: 0x13,
[INFO] [stderr] ...  |
[INFO] [stderr] 40 | |             // flags: 0xB0,
[INFO] [stderr] 41 | |         };
[INFO] [stderr]    | |__________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 18 |         CPURegisters {
[INFO] [stderr] 19 |             a: 0x01,
[INFO] [stderr] 20 |             b: 0x0,
[INFO] [stderr] 21 |             c: 0x13,
[INFO] [stderr] 22 |             d: 0x0,
[INFO] [stderr] 23 |             e: 0xd8,
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cpu/registers.rs:48:9
[INFO] [stderr]    |
[INFO] [stderr] 48 |         return ::math::two_u8_to_u16(self.a, self.f);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `::math::two_u8_to_u16(self.a, self.f)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cpu/registers.rs:61:9
[INFO] [stderr]    |
[INFO] [stderr] 61 |         return ::math::two_u8_to_u16(self.b, self.c);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `::math::two_u8_to_u16(self.b, self.c)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cpu/registers.rs:74:9
[INFO] [stderr]    |
[INFO] [stderr] 74 |         return ::math::two_u8_to_u16(self.d, self.e);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `::math::two_u8_to_u16(self.d, self.e)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cpu/registers.rs:87:9
[INFO] [stderr]    |
[INFO] [stderr] 87 |         return ::math::two_u8_to_u16(self.h, self.l);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `::math::two_u8_to_u16(self.h, self.l)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/cpu/registers.rs:124:9
[INFO] [stderr]     |
[INFO] [stderr] 124 |         return self.flags & 0b10000000 == 0b10000000;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.flags & 0b10000000 == 0b10000000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/cpu/registers.rs:124:29
[INFO] [stderr]     |
[INFO] [stderr] 124 |         return self.flags & 0b10000000 == 0b10000000;
[INFO] [stderr]     |                             ^^^^^^^^^^ help: consider: `0b1000_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/cpu/registers.rs:124:43
[INFO] [stderr]     |
[INFO] [stderr] 124 |         return self.flags & 0b10000000 == 0b10000000;
[INFO] [stderr]     |                                           ^^^^^^^^^^ help: consider: `0b1000_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/cpu/registers.rs:128:9
[INFO] [stderr]     |
[INFO] [stderr] 128 |         return self.flags & 0b00010000 == 0b00010000;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.flags & 0b00010000 == 0b00010000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/cpu/registers.rs:128:29
[INFO] [stderr]     |
[INFO] [stderr] 128 |         return self.flags & 0b00010000 == 0b00010000;
[INFO] [stderr]     |                             ^^^^^^^^^^ help: consider: `0b0001_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/cpu/registers.rs:128:43
[INFO] [stderr]     |
[INFO] [stderr] 128 |         return self.flags & 0b00010000 == 0b00010000;
[INFO] [stderr]     |                                           ^^^^^^^^^^ help: consider: `0b0001_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cpu/alu.rs:25:9
[INFO] [stderr]    |
[INFO] [stderr] 25 |         return value;
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: remove `return` as shown: `value`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cpu/alu.rs:45:9
[INFO] [stderr]    |
[INFO] [stderr] 45 |         return value;
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: remove `return` as shown: `value`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cpu/alu.rs:58:9
[INFO] [stderr]    |
[INFO] [stderr] 58 |         return result;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cpu/alu.rs:70:9
[INFO] [stderr]    |
[INFO] [stderr] 70 |         return result;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cpu/alu.rs:92:9
[INFO] [stderr]    |
[INFO] [stderr] 92 |         return value;
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: remove `return` as shown: `value`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/cpu/alu.rs:101:9
[INFO] [stderr]     |
[INFO] [stderr] 101 |         return value;
[INFO] [stderr]     |         ^^^^^^^^^^^^^ help: remove `return` as shown: `value`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]  --> src/memory/mod.rs:1:1
[INFO] [stderr]   |
[INFO] [stderr] 1 | pub mod memory;
[INFO] [stderr]   | ^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/memory/memory.rs:57:9
[INFO] [stderr]    |
[INFO] [stderr] 57 | /         return Memory {
[INFO] [stderr] 58 | |             rom: ReadOnlyMemorySector::new(data),
[INFO] [stderr] 59 | |             video_ram: VideoRam8kMemorySector::new(),
[INFO] [stderr] 60 | |             internal_ram_8k: InternalRam8kMemorySector::new(),
[INFO] [stderr] ...  |
[INFO] [stderr] 77 | |             interrupt_enable: InterruptFlag::new()
[INFO] [stderr] 78 | |         };
[INFO] [stderr]    | |__________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 57 |         Memory {
[INFO] [stderr] 58 |             rom: ReadOnlyMemorySector::new(data),
[INFO] [stderr] 59 |             video_ram: VideoRam8kMemorySector::new(),
[INFO] [stderr] 60 |             internal_ram_8k: InternalRam8kMemorySector::new(),
[INFO] [stderr] 61 |             serial_transfer_data: 0,
[INFO] [stderr] 62 |             sio_control: 0,
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/memory/memory.rs:164:9
[INFO] [stderr]     |
[INFO] [stderr] 164 |         return 0;
[INFO] [stderr]     |         ^^^^^^^^^ help: remove `return` as shown: `0`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/memory/memory.rs:170:9
[INFO] [stderr]     |
[INFO] [stderr] 170 |         return value as i8;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `value as i8`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/memory/memory.rs:196:9
[INFO] [stderr]     |
[INFO] [stderr] 196 |         return 0;
[INFO] [stderr]     |         ^^^^^^^^^ help: remove `return` as shown: `0`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/memory/internal_ram_memory_sector.rs:7:9
[INFO] [stderr]   |
[INFO] [stderr] 7 | /         return InternalRamMemorySector {
[INFO] [stderr] 8 | |             data: [0; 0x7F]
[INFO] [stderr] 9 | |         };
[INFO] [stderr]   | |__________^
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]   |
[INFO] [stderr] 7 |         InternalRamMemorySector {
[INFO] [stderr] 8 |             data: [0; 0x7F]
[INFO] [stderr] 9 |         }
[INFO] [stderr]   |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/memory/internal_ram_memory_sector.rs:16:9
[INFO] [stderr]    |
[INFO] [stderr] 16 |         return self.data[position as usize];
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.data[position as usize]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/memory/internal_ram_memory_sector.rs:26:9
[INFO] [stderr]    |
[INFO] [stderr] 26 |         return result;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/memory/internal_ram_8k_memory_sector.rs:7:9
[INFO] [stderr]   |
[INFO] [stderr] 7 | /         return InternalRam8kMemorySector {
[INFO] [stderr] 8 | |             data: [0; 0x2000]
[INFO] [stderr] 9 | |         };
[INFO] [stderr]   | |__________^
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]   |
[INFO] [stderr] 7 |         InternalRam8kMemorySector {
[INFO] [stderr] 8 |             data: [0; 0x2000]
[INFO] [stderr] 9 |         }
[INFO] [stderr]   |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/memory/internal_ram_8k_memory_sector.rs:16:9
[INFO] [stderr]    |
[INFO] [stderr] 16 |         return self.data[position as usize];
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.data[position as usize]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/memory/internal_ram_8k_memory_sector.rs:26:9
[INFO] [stderr]    |
[INFO] [stderr] 26 |         return result;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/memory/video_ram_8k_memory_sector.rs:7:9
[INFO] [stderr]   |
[INFO] [stderr] 7 | /         return VideoRam8kMemorySector {
[INFO] [stderr] 8 | |             data: [0; 0x2000]
[INFO] [stderr] 9 | |         };
[INFO] [stderr]   | |__________^
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]   |
[INFO] [stderr] 7 |         VideoRam8kMemorySector {
[INFO] [stderr] 8 |             data: [0; 0x2000]
[INFO] [stderr] 9 |         }
[INFO] [stderr]   |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/memory/video_ram_8k_memory_sector.rs:16:9
[INFO] [stderr]    |
[INFO] [stderr] 16 |         return self.data[position as usize];
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.data[position as usize]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/memory/video_ram_8k_memory_sector.rs:26:9
[INFO] [stderr]    |
[INFO] [stderr] 26 |         return result;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/memory/read_only_memory_sector.rs:7:9
[INFO] [stderr]   |
[INFO] [stderr] 7 | /         return ReadOnlyMemorySector {
[INFO] [stderr] 8 | |             data: data
[INFO] [stderr] 9 | |         };
[INFO] [stderr]   | |__________^
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]   |
[INFO] [stderr] 7 |         ReadOnlyMemorySector {
[INFO] [stderr] 8 |             data: data
[INFO] [stderr] 9 |         }
[INFO] [stderr]   |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/memory/read_only_memory_sector.rs:16:9
[INFO] [stderr]    |
[INFO] [stderr] 16 |         return self.data[position as usize];
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.data[position as usize]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/memory/read_only_memory_sector.rs:26:9
[INFO] [stderr]    |
[INFO] [stderr] 26 |         return result;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/memory/timer_control.rs:9:9
[INFO] [stderr]    |
[INFO] [stderr] 9  | /         return TimerControl {
[INFO] [stderr] 10 | |             started: false,
[INFO] [stderr] 11 | |             period_microseconds: 0.0,
[INFO] [stderr] 12 | |             frecuency_option: 0
[INFO] [stderr] 13 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 9  |         TimerControl {
[INFO] [stderr] 10 |             started: false,
[INFO] [stderr] 11 |             period_microseconds: 0.0,
[INFO] [stderr] 12 |             frecuency_option: 0
[INFO] [stderr] 13 |         }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/memory/timer_control.rs:21:60
[INFO] [stderr]    |
[INFO] [stderr] 21 |             0 => self.period_microseconds = 1.0 / 4096.0 * 1000000.0,
[INFO] [stderr]    |                                                            ^^^^^^^^^ help: consider: `1_000_000.0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/memory/timer_control.rs:22:51
[INFO] [stderr]    |
[INFO] [stderr] 22 |             1 => self.period_microseconds = 1.0 / 262144.0 * 1000000.0,
[INFO] [stderr]    |                                                   ^^^^^^^^ help: consider: `262_144.0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/memory/timer_control.rs:22:62
[INFO] [stderr]    |
[INFO] [stderr] 22 |             1 => self.period_microseconds = 1.0 / 262144.0 * 1000000.0,
[INFO] [stderr]    |                                                              ^^^^^^^^^ help: consider: `1_000_000.0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/memory/timer_control.rs:23:61
[INFO] [stderr]    |
[INFO] [stderr] 23 |             2 => self.period_microseconds = 1.0 / 65536.0 * 1000000.0,
[INFO] [stderr]    |                                                             ^^^^^^^^^ help: consider: `1_000_000.0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/memory/timer_control.rs:24:61
[INFO] [stderr]    |
[INFO] [stderr] 24 |             3 => self.period_microseconds = 1.0 / 16384.0 * 1000000.0,
[INFO] [stderr]    |                                                             ^^^^^^^^^ help: consider: `1_000_000.0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/memory/interrupt_flag.rs:11:9
[INFO] [stderr]    |
[INFO] [stderr] 11 | /         return InterruptFlag {
[INFO] [stderr] 12 | |             p10_13_transition: false,
[INFO] [stderr] 13 | |             serial_io_transfer_complete: false,
[INFO] [stderr] 14 | |             timer_overflow: false,
[INFO] [stderr] 15 | |             lcdc: false,
[INFO] [stderr] 16 | |             vblank: false
[INFO] [stderr] 17 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 11 |         InterruptFlag {
[INFO] [stderr] 12 |             p10_13_transition: false,
[INFO] [stderr] 13 |             serial_io_transfer_complete: false,
[INFO] [stderr] 14 |             timer_overflow: false,
[INFO] [stderr] 15 |             lcdc: false,
[INFO] [stderr] 16 |             vblank: false
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/memory/lcdc.rs:37:9
[INFO] [stderr]    |
[INFO] [stderr] 37 | /         return LCDC {
[INFO] [stderr] 38 | |             lcd_control_operation: false,
[INFO] [stderr] 39 | |             window_tile_map_display_select: true,
[INFO] [stderr] 40 | |             window_display: false,
[INFO] [stderr] ...  |
[INFO] [stderr] 45 | |             bg_and_window_display: true,
[INFO] [stderr] 46 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 37 |         LCDC {
[INFO] [stderr] 38 |             lcd_control_operation: false,
[INFO] [stderr] 39 |             window_tile_map_display_select: true,
[INFO] [stderr] 40 |             window_display: false,
[INFO] [stderr] 41 |             bg_and_window_tile_data_select: true,
[INFO] [stderr] 42 |             bg_tile_map_display_select: true,
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/memory/lcdc.rs:50:46
[INFO] [stderr]    |
[INFO] [stderr] 50 |         self.lcd_control_operation = value & 0b10000000 == 0b10000000;
[INFO] [stderr]    |                                              ^^^^^^^^^^ help: consider: `0b1000_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/memory/lcdc.rs:50:60
[INFO] [stderr]    |
[INFO] [stderr] 50 |         self.lcd_control_operation = value & 0b10000000 == 0b10000000;
[INFO] [stderr]    |                                                            ^^^^^^^^^^ help: consider: `0b1000_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/memory/lcdc.rs:51:55
[INFO] [stderr]    |
[INFO] [stderr] 51 |         self.window_tile_map_display_select = value & 0b01000000 == 0b01000000;
[INFO] [stderr]    |                                                       ^^^^^^^^^^ help: consider: `0b0100_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/memory/lcdc.rs:51:69
[INFO] [stderr]    |
[INFO] [stderr] 51 |         self.window_tile_map_display_select = value & 0b01000000 == 0b01000000;
[INFO] [stderr]    |                                                                     ^^^^^^^^^^ help: consider: `0b0100_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/memory/lcdc.rs:52:39
[INFO] [stderr]    |
[INFO] [stderr] 52 |         self.window_display = value & 0b00100000 == 0b00100000;
[INFO] [stderr]    |                                       ^^^^^^^^^^ help: consider: `0b0010_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/memory/lcdc.rs:52:53
[INFO] [stderr]    |
[INFO] [stderr] 52 |         self.window_display = value & 0b00100000 == 0b00100000;
[INFO] [stderr]    |                                                     ^^^^^^^^^^ help: consider: `0b0010_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/memory/stat.rs:13:9
[INFO] [stderr]    |
[INFO] [stderr] 13 | /         return STAT {
[INFO] [stderr] 14 | |             mode: 0,
[INFO] [stderr] 15 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 13 |         STAT {
[INFO] [stderr] 14 |             mode: 0,
[INFO] [stderr] 15 |         }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/memory/stat.rs:23:9
[INFO] [stderr]    |
[INFO] [stderr] 23 |         return self.mode;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.mode`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/math/mod.rs:3:5
[INFO] [stderr]   |
[INFO] [stderr] 3 |     return(result << 8) + (l as u16);
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(result << 8) + (l as u16)`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/math/mod.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 |     return (high, low);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(high, low)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]  --> src/gpu/mod.rs:1:1
[INFO] [stderr]   |
[INFO] [stderr] 1 | pub mod gpu;
[INFO] [stderr]   | ^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/gpu/gpu.rs:14:9
[INFO] [stderr]    |
[INFO] [stderr] 14 | /         return GPU {
[INFO] [stderr] 15 | |             gl: gl,
[INFO] [stderr] 16 | |             cycles_acumulated: 0,
[INFO] [stderr] 17 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 14 |         GPU {
[INFO] [stderr] 15 |             gl: gl,
[INFO] [stderr] 16 |             cycles_acumulated: 0,
[INFO] [stderr] 17 |         }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::thread::sleep`
[INFO] [stderr]   --> src/main.rs:14:5
[INFO] [stderr]    |
[INFO] [stderr] 14 | use std::thread::sleep;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::time::Duration`
[INFO] [stderr]   --> src/main.rs:15:5
[INFO] [stderr]    |
[INFO] [stderr] 15 | use std::time::Duration;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unreachable statement
[INFO] [stderr]    --> src/memory/memory.rs:164:9
[INFO] [stderr]     |
[INFO] [stderr] 164 |         return 0;
[INFO] [stderr]     |         ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unreachable_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unreachable statement
[INFO] [stderr]    --> src/memory/memory.rs:196:9
[INFO] [stderr]     |
[INFO] [stderr] 196 |         return 0;
[INFO] [stderr]     |         ^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `args`
[INFO] [stderr]   --> src/gpu/gpu.rs:93:30
[INFO] [stderr]    |
[INFO] [stderr] 93 |     pub fn update(&mut self, args: &UpdateArgs) {
[INFO] [stderr]    |                              ^^^^ help: consider using `_args` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: associated const is never used: `DARK_GRAY`
[INFO] [stderr]  --> src/gpu/color.rs:6:5
[INFO] [stderr]   |
[INFO] [stderr] 6 |     pub const DARK_GRAY:  [f32; 4] = [0.3333, 0.3333, 0.3333, 1.0];
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: associated const is never used: `GRAY`
[INFO] [stderr]  --> src/gpu/color.rs:7:5
[INFO] [stderr]   |
[INFO] [stderr] 7 |     pub const GRAY:  [f32; 4] = [0.6667, 0.6667, 0.6667, 1.0];
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu/cpu.rs:170:34
[INFO] [stderr]     |
[INFO] [stderr] 170 |         self.available_cycles -= self.last_instruction_ccycles as i32;
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.last_instruction_ccycles)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] error: equal expressions as operands to `^`
[INFO] [stderr]    --> src/cpu/cpu.rs:460:28
[INFO] [stderr]     |
[INFO] [stderr] 460 |         self.registers.a = self.registers.a ^ self.registers.a;
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::eq_op)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/cpu/cpu.rs:479:9
[INFO] [stderr]     |
[INFO] [stderr] 479 |         self.registers.a = self.registers.c ^ self.registers.a;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.registers.a ^= self.registers.c`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/cpu/cpu.rs:499:9
[INFO] [stderr]     |
[INFO] [stderr] 499 |         self.registers.a = value ^ self.registers.a;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.registers.a ^= value`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/cpu/cpu.rs:519:9
[INFO] [stderr]     |
[INFO] [stderr] 519 |         self.registers.a = value ^ self.registers.a;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.registers.a ^= value`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu/cpu.rs:937:27
[INFO] [stderr]     |
[INFO] [stderr] 937 |         let to_sum: u16 = memory.read_8(self.registers.pc + 1) as u16;
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(memory.read_8(self.registers.pc + 1))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu/cpu.rs:953:27
[INFO] [stderr]     |
[INFO] [stderr] 953 |         let to_sum: u16 = memory.read_8(self.registers.pc + 1) as u16;
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(memory.read_8(self.registers.pc + 1))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change
[INFO] [stderr]     --> src/cpu/cpu.rs:1160:61
[INFO] [stderr]      |
[INFO] [stderr] 1160 |             self.registers.pc = (self.registers.pc as i16 + possible_value as i16) as u16;
[INFO] [stderr]      |                                                             ^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(possible_value)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change
[INFO] [stderr]     --> src/cpu/cpu.rs:1180:61
[INFO] [stderr]      |
[INFO] [stderr] 1180 |             self.registers.pc = (self.registers.pc as i16 + possible_value as i16) as u16;
[INFO] [stderr]      |                                                             ^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(possible_value)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change
[INFO] [stderr]     --> src/cpu/cpu.rs:1200:61
[INFO] [stderr]      |
[INFO] [stderr] 1200 |             self.registers.pc = (self.registers.pc as i16 + possible_value as i16) as u16;
[INFO] [stderr]      |                                                             ^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(possible_value)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change
[INFO] [stderr]     --> src/cpu/cpu.rs:1220:61
[INFO] [stderr]      |
[INFO] [stderr] 1220 |             self.registers.pc = (self.registers.pc as i16 + possible_value as i16) as u16;
[INFO] [stderr]      |                                                             ^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(possible_value)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]     --> src/cpu/cpu.rs:1554:9
[INFO] [stderr]      |
[INFO] [stderr] 1554 |         self.registers.sp = self.registers.sp - 2;
[INFO] [stderr]      |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.registers.sp -= 2`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/alu.rs:14:28
[INFO] [stderr]    |
[INFO] [stderr] 14 |         let carry: bool = (a as u16 + b as u16) & 0x100 == 0x100;
[INFO] [stderr]    |                            ^^^^^^^^ help: try: `u16::from(a)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/alu.rs:14:39
[INFO] [stderr]    |
[INFO] [stderr] 14 |         let carry: bool = (a as u16 + b as u16) & 0x100 == 0x100;
[INFO] [stderr]    |                                       ^^^^^^^^ help: try: `u16::from(b)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/memory/internal_ram_memory_sector.rs:24:31
[INFO] [stderr]    |
[INFO] [stderr] 24 |         let mut result: u16 = self.data[position] as u16;
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.data[position])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/memory/internal_ram_memory_sector.rs:25:19
[INFO] [stderr]    |
[INFO] [stderr] 25 |         result += (self.data[position + 1] as u16) << 8;
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.data[position + 1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/memory/internal_ram_8k_memory_sector.rs:24:31
[INFO] [stderr]    |
[INFO] [stderr] 24 |         let mut result: u16 = self.data[position] as u16;
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.data[position])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/memory/internal_ram_8k_memory_sector.rs:25:19
[INFO] [stderr]    |
[INFO] [stderr] 25 |         result += (self.data[position + 1] as u16) << 8;
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.data[position + 1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/memory/video_ram_8k_memory_sector.rs:24:31
[INFO] [stderr]    |
[INFO] [stderr] 24 |         let mut result: u16 = self.data[position] as u16;
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.data[position])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/memory/video_ram_8k_memory_sector.rs:25:19
[INFO] [stderr]    |
[INFO] [stderr] 25 |         result += (self.data[position + 1] as u16) << 8;
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.data[position + 1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/memory/read_only_memory_sector.rs:24:31
[INFO] [stderr]    |
[INFO] [stderr] 24 |         let mut result: u16 = self.data[position] as u16;
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.data[position])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/memory/read_only_memory_sector.rs:25:19
[INFO] [stderr]    |
[INFO] [stderr] 25 |         result += (self.data[position + 1] as u16) << 8;
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.data[position + 1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/memory/timer_control.rs:16:20
[INFO] [stderr]    |
[INFO] [stderr] 16 |     pub fn from_u8(&mut self, value: u8) {
[INFO] [stderr]    |                    ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/memory/interrupt_flag.rs:20:20
[INFO] [stderr]    |
[INFO] [stderr] 20 |     pub fn from_u8(&mut self, value: u8) {
[INFO] [stderr]    |                    ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/memory/lcdc.rs:49:20
[INFO] [stderr]    |
[INFO] [stderr] 49 |     pub fn from_u8(&mut self, value: u8) {
[INFO] [stderr]    |                    ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/memory/stat.rs:18:20
[INFO] [stderr]    |
[INFO] [stderr] 18 |     pub fn from_u8(&mut self, value: u8) {
[INFO] [stderr]    |                    ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]  --> src/math/mod.rs:2:22
[INFO] [stderr]   |
[INFO] [stderr] 2 |     let result:u16 = h as u16;
[INFO] [stderr]   |                      ^^^^^^^^ help: try: `u16::from(h)`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]  --> src/math/mod.rs:3:27
[INFO] [stderr]   |
[INFO] [stderr] 3 |     return(result << 8) + (l as u16);
[INFO] [stderr]   |                           ^^^^^^^^^^ help: try: `u16::from(l)`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/gpu/gpu.rs:22:35
[INFO] [stderr]    |
[INFO] [stderr] 22 |         self.cycles_acumulated += last_instruction_cycles as u16;
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(last_instruction_cycles)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/gpu/gpu.rs:93:36
[INFO] [stderr]    |
[INFO] [stderr] 93 |     pub fn update(&mut self, args: &UpdateArgs) {
[INFO] [stderr]    |                                    ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] error: any number modulo 1 will be 0
[INFO] [stderr]   --> src/main.rs:56:25
[INFO] [stderr]    |
[INFO] [stderr] 56 |             if debug && i % 1 == 0 {
[INFO] [stderr]    |                         ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::modulo_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#modulo_one
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `rustiegb`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "e53cb5444699a9d0ce1429acf2d5b2b1e04a81a8616437a119d4b0d7614f9260"`
[INFO] running `"docker" "rm" "-f" "e53cb5444699a9d0ce1429acf2d5b2b1e04a81a8616437a119d4b0d7614f9260"`
[INFO] [stdout] e53cb5444699a9d0ce1429acf2d5b2b1e04a81a8616437a119d4b0d7614f9260