[INFO] updating cached repository jdhorwitz/mandelbrot [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jdhorwitz/mandelbrot [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jdhorwitz/mandelbrot" "work/ex/clippy-test-run/sources/stable/gh/jdhorwitz/mandelbrot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jdhorwitz/mandelbrot'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jdhorwitz/mandelbrot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jdhorwitz/mandelbrot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jdhorwitz/mandelbrot'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b5e9f6c9c25abf500e11c1ff13d49b1ce8e5f7f1 [INFO] sha for GitHub repo jdhorwitz/mandelbrot: b5e9f6c9c25abf500e11c1ff13d49b1ce8e5f7f1 [INFO] validating manifest of jdhorwitz/mandelbrot on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jdhorwitz/mandelbrot on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jdhorwitz/mandelbrot [INFO] finished frobbing jdhorwitz/mandelbrot [INFO] frobbed toml for jdhorwitz/mandelbrot written to work/ex/clippy-test-run/sources/stable/gh/jdhorwitz/mandelbrot/Cargo.toml [INFO] started frobbing jdhorwitz/mandelbrot [INFO] finished frobbing jdhorwitz/mandelbrot [INFO] frobbed toml for jdhorwitz/mandelbrot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jdhorwitz/mandelbrot/Cargo.toml [INFO] crate jdhorwitz/mandelbrot has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jdhorwitz/mandelbrot against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jdhorwitz/mandelbrot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a94b13ada056a10ff82f006e2eea3e2d3a49549980de1616e9e3864ae1481cf6 [INFO] running `"docker" "start" "-a" "a94b13ada056a10ff82f006e2eea3e2d3a49549980de1616e9e3864ae1481cf6"` [INFO] [stderr] Compiling miniz-sys v0.1.9 [INFO] [stderr] Checking enum_primitive v0.1.1 [INFO] [stderr] Checking flate2 v0.2.17 [INFO] [stderr] Checking png v0.4.3 [INFO] [stderr] Checking image v0.6.1 [INFO] [stderr] Checking mandelbrot v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | / writeln!(std::io::stderr(), [INFO] [stderr] 145 | | "Usage: mandelbrot FILE PIXELS UPPERLEFT LOWERRIGHT") [INFO] [stderr] 146 | | .unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:147:9 [INFO] [stderr] | [INFO] [stderr] 147 | / writeln!(std::io::stderr(), [INFO] [stderr] 148 | | "Example: {} mandel.png 1000x750 -1.20,0.35 -1,0.20", [INFO] [stderr] 149 | | args[0]) [INFO] [stderr] 150 | | .unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | / writeln!(std::io::stderr(), [INFO] [stderr] 145 | | "Usage: mandelbrot FILE PIXELS UPPERLEFT LOWERRIGHT") [INFO] [stderr] 146 | | .unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:147:9 [INFO] [stderr] | [INFO] [stderr] 147 | / writeln!(std::io::stderr(), [INFO] [stderr] 148 | | "Example: {} mandel.png 1000x750 -1.20,0.35 -1,0.20", [INFO] [stderr] 149 | | args[0]) [INFO] [stderr] 150 | | .unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.88s [INFO] running `"docker" "inspect" "a94b13ada056a10ff82f006e2eea3e2d3a49549980de1616e9e3864ae1481cf6"` [INFO] running `"docker" "rm" "-f" "a94b13ada056a10ff82f006e2eea3e2d3a49549980de1616e9e3864ae1481cf6"` [INFO] [stdout] a94b13ada056a10ff82f006e2eea3e2d3a49549980de1616e9e3864ae1481cf6