[INFO] updating cached repository jdferreira/following-thebennybox-tutorial [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jdferreira/following-thebennybox-tutorial [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jdferreira/following-thebennybox-tutorial" "work/ex/clippy-test-run/sources/stable/gh/jdferreira/following-thebennybox-tutorial"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jdferreira/following-thebennybox-tutorial'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jdferreira/following-thebennybox-tutorial" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jdferreira/following-thebennybox-tutorial"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jdferreira/following-thebennybox-tutorial'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5e66183a4dfdabd6a13383b5577d5ee41ba26a2e [INFO] sha for GitHub repo jdferreira/following-thebennybox-tutorial: 5e66183a4dfdabd6a13383b5577d5ee41ba26a2e [INFO] validating manifest of jdferreira/following-thebennybox-tutorial on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jdferreira/following-thebennybox-tutorial on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jdferreira/following-thebennybox-tutorial [INFO] finished frobbing jdferreira/following-thebennybox-tutorial [INFO] frobbed toml for jdferreira/following-thebennybox-tutorial written to work/ex/clippy-test-run/sources/stable/gh/jdferreira/following-thebennybox-tutorial/Cargo.toml [INFO] started frobbing jdferreira/following-thebennybox-tutorial [INFO] finished frobbing jdferreira/following-thebennybox-tutorial [INFO] frobbed toml for jdferreira/following-thebennybox-tutorial written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jdferreira/following-thebennybox-tutorial/Cargo.toml [INFO] crate jdferreira/following-thebennybox-tutorial has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jdferreira/following-thebennybox-tutorial against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jdferreira/following-thebennybox-tutorial:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0606d0eb9f24d40e5336b1d476660c7899f00a63144364f40fb0feff4af31e47 [INFO] running `"docker" "start" "-a" "0606d0eb9f24d40e5336b1d476660c7899f00a63144364f40fb0feff4af31e47"` [INFO] [stderr] Checking shared_library v0.1.7 [INFO] [stderr] Compiling phf_generator v0.7.21 [INFO] [stderr] Checking tempfile v2.2.0 [INFO] [stderr] Checking cgmath v0.15.0 [INFO] [stderr] Compiling glium v0.17.1 [INFO] [stderr] Checking x11-dl v2.15.0 [INFO] [stderr] Checking backtrace-sys v0.1.14 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Checking backtrace v0.3.3 [INFO] [stderr] Compiling phf_codegen v0.7.21 [INFO] [stderr] Checking memmap v0.4.0 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.9.10 [INFO] [stderr] Checking wayland-client v0.9.10 [INFO] [stderr] Checking wayland-protocols v0.9.10 [INFO] [stderr] Checking wayland-kbd v0.9.1 [INFO] [stderr] Checking wayland-window v0.7.0 [INFO] [stderr] Checking winit v0.7.6 [INFO] [stderr] Checking glutin v0.9.2 [INFO] [stderr] Checking following-thebennybox-tutorial v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine/window.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | display: display, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `display` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine/mesh.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | shader: shader [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `shader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine/main_component.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | events_loop: events_loop, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `events_loop` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine/main_component.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | window: window, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine/main_component.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | game: game, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `game` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine/window.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | display: display, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `display` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine/mesh.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | shader: shader [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `shader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine/main_component.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | events_loop: events_loop, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `events_loop` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine/main_component.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | window: window, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine/main_component.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | game: game, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `game` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/engine/main_component.rs:11:15 [INFO] [stderr] | [INFO] [stderr] 11 | const TITLE: &'static str = "3D engine"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/engine/main_component.rs:11:15 [INFO] [stderr] | [INFO] [stderr] 11 | const TITLE: &'static str = "3D engine"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: method is never used: `key_is_down` [INFO] [stderr] --> src/engine/input.rs:110:5 [INFO] [stderr] | [INFO] [stderr] 110 | pub fn key_is_down(&self, keycode: VirtualKeyCode) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `mouse_is_down` [INFO] [stderr] --> src/engine/input.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | pub fn mouse_is_down(&self, button: MouseButton) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/engine/input.rs:36:38 [INFO] [stderr] | [INFO] [stderr] 36 | events_loop.poll_events(|ev| match ev { [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 37 | | Event::WindowEvent { event, .. } => self.window_event(event), [INFO] [stderr] 38 | | _ => (), [INFO] [stderr] 39 | | // Event::Awakened => new_state.awakened(), [INFO] [stderr] 40 | | // Event::DeviceEvent { event, .. } => new_state.device_event(event), [INFO] [stderr] 41 | | }); [INFO] [stderr] | |_________^ help: try this: `if let Event::WindowEvent { event, .. } = ev { self.window_event(event) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::forget` with a value that implements Copy. Forgetting a copy leaves the original intact. [INFO] [stderr] --> src/engine/mesh.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | implement_vertex!(Vertex, position); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::forget_copy)] on by default [INFO] [stderr] note: argument has type engine::mesh::Vertex [INFO] [stderr] --> src/engine/mesh.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | implement_vertex!(Vertex, position); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#forget_copy [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `following-thebennybox-tutorial`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: method is never used: `key_is_down` [INFO] [stderr] --> src/engine/input.rs:110:5 [INFO] [stderr] | [INFO] [stderr] 110 | pub fn key_is_down(&self, keycode: VirtualKeyCode) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `mouse_is_down` [INFO] [stderr] --> src/engine/input.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | pub fn mouse_is_down(&self, button: MouseButton) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/engine/input.rs:36:38 [INFO] [stderr] | [INFO] [stderr] 36 | events_loop.poll_events(|ev| match ev { [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 37 | | Event::WindowEvent { event, .. } => self.window_event(event), [INFO] [stderr] 38 | | _ => (), [INFO] [stderr] 39 | | // Event::Awakened => new_state.awakened(), [INFO] [stderr] 40 | | // Event::DeviceEvent { event, .. } => new_state.device_event(event), [INFO] [stderr] 41 | | }); [INFO] [stderr] | |_________^ help: try this: `if let Event::WindowEvent { event, .. } = ev { self.window_event(event) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::forget` with a value that implements Copy. Forgetting a copy leaves the original intact. [INFO] [stderr] --> src/engine/mesh.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | implement_vertex!(Vertex, position); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::forget_copy)] on by default [INFO] [stderr] note: argument has type engine::mesh::Vertex [INFO] [stderr] --> src/engine/mesh.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | implement_vertex!(Vertex, position); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#forget_copy [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `following-thebennybox-tutorial`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "0606d0eb9f24d40e5336b1d476660c7899f00a63144364f40fb0feff4af31e47"` [INFO] running `"docker" "rm" "-f" "0606d0eb9f24d40e5336b1d476660c7899f00a63144364f40fb0feff4af31e47"` [INFO] [stdout] 0606d0eb9f24d40e5336b1d476660c7899f00a63144364f40fb0feff4af31e47