[INFO] updating cached repository jdburnet/fii [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jdburnet/fii [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jdburnet/fii" "work/ex/clippy-test-run/sources/stable/gh/jdburnet/fii"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jdburnet/fii'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jdburnet/fii" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jdburnet/fii"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jdburnet/fii'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a9b6d40bfb362a2fa156d40c7e8157c3565b824f [INFO] sha for GitHub repo jdburnet/fii: a9b6d40bfb362a2fa156d40c7e8157c3565b824f [INFO] validating manifest of jdburnet/fii on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jdburnet/fii on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jdburnet/fii [INFO] finished frobbing jdburnet/fii [INFO] frobbed toml for jdburnet/fii written to work/ex/clippy-test-run/sources/stable/gh/jdburnet/fii/Cargo.toml [INFO] started frobbing jdburnet/fii [INFO] finished frobbing jdburnet/fii [INFO] frobbed toml for jdburnet/fii written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jdburnet/fii/Cargo.toml [INFO] crate jdburnet/fii has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jdburnet/fii against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jdburnet/fii:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ef9552cafdddae8c36722088fcb843fd7dc6e3c85b803dd550fda4a51a2ddcf3 [INFO] running `"docker" "start" "-a" "ef9552cafdddae8c36722088fcb843fd7dc6e3c85b803dd550fda4a51a2ddcf3"` [INFO] [stderr] Checking app_dirs v1.2.1 [INFO] [stderr] Checking fii v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `core::History` [INFO] [stderr] --> src/core.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | / pub fn new() -> History { [INFO] [stderr] 71 | | History{ years: Vec::new() } [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 65 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `core::History` [INFO] [stderr] --> src/core.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | / pub fn new() -> History { [INFO] [stderr] 71 | | History{ years: Vec::new() } [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 65 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/core.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | assert_eq!(invinc, exp) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/core.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | assert_eq!(invinc, exp) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/data.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | APP.name; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::no_effect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `fii`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/bin/fii.rs:40:22 [INFO] [stderr] | [INFO] [stderr] 40 | Ok(ref s) if *s == String::from("") => start_new(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ try implementing the comparison without allocating [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "ef9552cafdddae8c36722088fcb843fd7dc6e3c85b803dd550fda4a51a2ddcf3"` [INFO] running `"docker" "rm" "-f" "ef9552cafdddae8c36722088fcb843fd7dc6e3c85b803dd550fda4a51a2ddcf3"` [INFO] [stdout] ef9552cafdddae8c36722088fcb843fd7dc6e3c85b803dd550fda4a51a2ddcf3