[INFO] updating cached repository jdansev/Life [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jdansev/Life [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jdansev/Life" "work/ex/clippy-test-run/sources/stable/gh/jdansev/Life"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jdansev/Life'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jdansev/Life" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jdansev/Life"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jdansev/Life'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7ac48a4e0b923735cba52fc669ba325003ead9af [INFO] sha for GitHub repo jdansev/Life: 7ac48a4e0b923735cba52fc669ba325003ead9af [INFO] validating manifest of jdansev/Life on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jdansev/Life on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jdansev/Life [INFO] finished frobbing jdansev/Life [INFO] frobbed toml for jdansev/Life written to work/ex/clippy-test-run/sources/stable/gh/jdansev/Life/Cargo.toml [INFO] started frobbing jdansev/Life [INFO] finished frobbing jdansev/Life [INFO] frobbed toml for jdansev/Life written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jdansev/Life/Cargo.toml [INFO] crate jdansev/Life has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jdansev/Life against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jdansev/Life:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9528f980e635d0c68f2ba9f9d2669ac0731bc54e9bd0d9105644c8317ba94791 [INFO] running `"docker" "start" "-a" "9528f980e635d0c68f2ba9f9d2669ac0731bc54e9bd0d9105644c8317ba94791"` [INFO] [stderr] Compiling wayland-scanner v0.21.7 [INFO] [stderr] Checking smallvec v0.6.7 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Compiling glutin v0.18.0 [INFO] [stderr] Checking wayland-sys v0.21.7 [INFO] [stderr] Checking piston2d-graphics v0.28.0 [INFO] [stderr] Checking rusttype v0.4.3 [INFO] [stderr] Checking pistoncore-input v0.21.0 [INFO] [stderr] Checking wayland-client v0.20.12 [INFO] [stderr] Checking wayland-commons v0.21.7 [INFO] [stderr] Checking parking_lot_core v0.3.1 [INFO] [stderr] Checking piston2d-opengl_graphics v0.57.0 [INFO] [stderr] Checking piston2d-graphics v0.26.0 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Compiling wayland-client v0.21.7 [INFO] [stderr] Compiling wayland-protocols v0.21.7 [INFO] [stderr] Checking wayland-protocols v0.20.12 [INFO] [stderr] Checking pistoncore-window v0.32.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.52.0 [INFO] [stderr] Checking pistoncore-event_loop v0.37.0 [INFO] [stderr] Checking piston v0.37.0 [INFO] [stderr] Checking smithay-client-toolkit v0.3.0 [INFO] [stderr] Checking winit v0.17.2 [INFO] [stderr] Checking smithay-client-toolkit v0.4.3 [INFO] [stderr] Checking pistoncore-glutin_window v0.48.0 [INFO] [stderr] Checking winit v0.18.0 [INFO] [stderr] Checking piston_window v0.81.0 [INFO] [stderr] Checking glutin v0.19.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.51.1 [INFO] [stderr] Checking gol v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/decoder.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | return RleDecoder::decode("#C no data\nx = 0, y = 0\n!"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `RleDecoder::decode("#C no data\nx = 0, y = 0\n!")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/decoder.rs:29:31 [INFO] [stderr] | [INFO] [stderr] 29 | let lines = rle.split("\n").collect::>(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `lines`. [INFO] [stderr] --> src/decoder.rs:33:18 [INFO] [stderr] | [INFO] [stderr] 33 | for i in 0..lines.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 33 | for in &lines { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/decoder.rs:61:45 [INFO] [stderr] | [INFO] [stderr] 61 | let header = line.split(","); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/decoder.rs:63:48 [INFO] [stderr] | [INFO] [stderr] 63 | x = header[0].trim().split("=").collect::>()[1].trim(); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/decoder.rs:64:48 [INFO] [stderr] | [INFO] [stderr] 64 | y = header[1].trim().split("=").collect::>()[1].trim(); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `lines`. [INFO] [stderr] --> src/decoder.rs:83:18 [INFO] [stderr] | [INFO] [stderr] 83 | for i in 0..lines.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 83 | for in &lines { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:103:52 [INFO] [stderr] | [INFO] [stderr] 103 | run_length = run_length * 10 + ch.to_digit(10).unwrap() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(ch.to_digit(10).unwrap())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/decoder.rs:163:24 [INFO] [stderr] | [INFO] [stderr] 163 | fn parse_pattern(path: &String) -> Pattern { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 163 | fn parse_pattern(path: &str) -> Pattern { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `path.as_str()` to [INFO] [stderr] | [INFO] [stderr] 164 | let rle_path = "./patterns/".to_owned() + path; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/decoder.rs:183:38 [INFO] [stderr] | [INFO] [stderr] 183 | .and_then(|n| n.to_str().map(|s| String::from(s))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/life.rs:64:24 [INFO] [stderr] | [INFO] [stderr] 64 | let mut next = self.board.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.board` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/life.rs:68:17 [INFO] [stderr] | [INFO] [stderr] 68 | / match self.test_bit(x, y) { [INFO] [stderr] 69 | | true => { [INFO] [stderr] 70 | | if n > 1 && n < 4 { [INFO] [stderr] 71 | | self.set_bit(&mut next, x, y); [INFO] [stderr] ... | [INFO] [stderr] 78 | | }, [INFO] [stderr] 79 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 68 | if self.test_bit(x, y) { [INFO] [stderr] 69 | if n > 1 && n < 4 { [INFO] [stderr] 70 | self.set_bit(&mut next, x, y); [INFO] [stderr] 71 | } else { [INFO] [stderr] 72 | self.clear_bit(&mut next, x, y); [INFO] [stderr] 73 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/life.rs:92:17 [INFO] [stderr] | [INFO] [stderr] 92 | / match p.structure[RleDecoder::index(y, x, p.width)] { [INFO] [stderr] 93 | | 1 => self.seed(y+offset_y, x+offset_x), [INFO] [stderr] 94 | | _ => (), [INFO] [stderr] 95 | | } [INFO] [stderr] | |_________________^ help: try this: `if let 1 = p.structure[RleDecoder::index(y, x, p.width)] { self.seed(y+offset_y, x+offset_x) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | let ref font = assets.join("Meslo-LG.ttf"); [INFO] [stderr] | ----^^^^^^^^------------------------------- help: try: `let font = &assets.join("Meslo-LG.ttf");` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:55:16 [INFO] [stderr] | [INFO] [stderr] 55 | if let Some(_) = e.render_args() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 56 | | texture.update(&mut window.encoder, &canvas).unwrap(); [INFO] [stderr] 57 | | [INFO] [stderr] 58 | | window.draw_2d(&e, |c, g| { [INFO] [stderr] ... | [INFO] [stderr] 86 | | }); [INFO] [stderr] 87 | | } [INFO] [stderr] | |_________- help: try this: `if e.render_args().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/decoder.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | return RleDecoder::decode("#C no data\nx = 0, y = 0\n!"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `RleDecoder::decode("#C no data\nx = 0, y = 0\n!")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/decoder.rs:29:31 [INFO] [stderr] | [INFO] [stderr] 29 | let lines = rle.split("\n").collect::>(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `lines`. [INFO] [stderr] --> src/decoder.rs:33:18 [INFO] [stderr] | [INFO] [stderr] 33 | for i in 0..lines.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 33 | for in &lines { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/decoder.rs:61:45 [INFO] [stderr] | [INFO] [stderr] 61 | let header = line.split(","); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/decoder.rs:63:48 [INFO] [stderr] | [INFO] [stderr] 63 | x = header[0].trim().split("=").collect::>()[1].trim(); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/decoder.rs:64:48 [INFO] [stderr] | [INFO] [stderr] 64 | y = header[1].trim().split("=").collect::>()[1].trim(); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `lines`. [INFO] [stderr] --> src/decoder.rs:83:18 [INFO] [stderr] | [INFO] [stderr] 83 | for i in 0..lines.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 83 | for in &lines { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:103:52 [INFO] [stderr] | [INFO] [stderr] 103 | run_length = run_length * 10 + ch.to_digit(10).unwrap() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(ch.to_digit(10).unwrap())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/decoder.rs:163:24 [INFO] [stderr] | [INFO] [stderr] 163 | fn parse_pattern(path: &String) -> Pattern { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 163 | fn parse_pattern(path: &str) -> Pattern { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `path.as_str()` to [INFO] [stderr] | [INFO] [stderr] 164 | let rle_path = "./patterns/".to_owned() + path; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/decoder.rs:183:38 [INFO] [stderr] | [INFO] [stderr] 183 | .and_then(|n| n.to_str().map(|s| String::from(s))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/life.rs:64:24 [INFO] [stderr] | [INFO] [stderr] 64 | let mut next = self.board.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.board` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/life.rs:68:17 [INFO] [stderr] | [INFO] [stderr] 68 | / match self.test_bit(x, y) { [INFO] [stderr] 69 | | true => { [INFO] [stderr] 70 | | if n > 1 && n < 4 { [INFO] [stderr] 71 | | self.set_bit(&mut next, x, y); [INFO] [stderr] ... | [INFO] [stderr] 78 | | }, [INFO] [stderr] 79 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 68 | if self.test_bit(x, y) { [INFO] [stderr] 69 | if n > 1 && n < 4 { [INFO] [stderr] 70 | self.set_bit(&mut next, x, y); [INFO] [stderr] 71 | } else { [INFO] [stderr] 72 | self.clear_bit(&mut next, x, y); [INFO] [stderr] 73 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/life.rs:92:17 [INFO] [stderr] | [INFO] [stderr] 92 | / match p.structure[RleDecoder::index(y, x, p.width)] { [INFO] [stderr] 93 | | 1 => self.seed(y+offset_y, x+offset_x), [INFO] [stderr] 94 | | _ => (), [INFO] [stderr] 95 | | } [INFO] [stderr] | |_________________^ help: try this: `if let 1 = p.structure[RleDecoder::index(y, x, p.width)] { self.seed(y+offset_y, x+offset_x) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | let ref font = assets.join("Meslo-LG.ttf"); [INFO] [stderr] | ----^^^^^^^^------------------------------- help: try: `let font = &assets.join("Meslo-LG.ttf");` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:55:16 [INFO] [stderr] | [INFO] [stderr] 55 | if let Some(_) = e.render_args() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 56 | | texture.update(&mut window.encoder, &canvas).unwrap(); [INFO] [stderr] 57 | | [INFO] [stderr] 58 | | window.draw_2d(&e, |c, g| { [INFO] [stderr] ... | [INFO] [stderr] 86 | | }); [INFO] [stderr] 87 | | } [INFO] [stderr] | |_________- help: try this: `if e.render_args().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 49.20s [INFO] running `"docker" "inspect" "9528f980e635d0c68f2ba9f9d2669ac0731bc54e9bd0d9105644c8317ba94791"` [INFO] running `"docker" "rm" "-f" "9528f980e635d0c68f2ba9f9d2669ac0731bc54e9bd0d9105644c8317ba94791"` [INFO] [stdout] 9528f980e635d0c68f2ba9f9d2669ac0731bc54e9bd0d9105644c8317ba94791