[INFO] updating cached repository jdanford/scrubjay [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jdanford/scrubjay [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jdanford/scrubjay" "work/ex/clippy-test-run/sources/stable/gh/jdanford/scrubjay"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jdanford/scrubjay'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jdanford/scrubjay" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jdanford/scrubjay"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jdanford/scrubjay'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8641e2ee45eb34bbc1a1d853d4ed020541bd86ca [INFO] sha for GitHub repo jdanford/scrubjay: 8641e2ee45eb34bbc1a1d853d4ed020541bd86ca [INFO] validating manifest of jdanford/scrubjay on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jdanford/scrubjay on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jdanford/scrubjay [INFO] finished frobbing jdanford/scrubjay [INFO] frobbed toml for jdanford/scrubjay written to work/ex/clippy-test-run/sources/stable/gh/jdanford/scrubjay/Cargo.toml [INFO] started frobbing jdanford/scrubjay [INFO] finished frobbing jdanford/scrubjay [INFO] frobbed toml for jdanford/scrubjay written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jdanford/scrubjay/Cargo.toml [INFO] crate jdanford/scrubjay has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jdanford/scrubjay against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jdanford/scrubjay:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 748b56e7207c535cfe86b5cff4eb29e0bd50d871e1c1b7812408fd3a8863a060 [INFO] running `"docker" "start" "-a" "748b56e7207c535cfe86b5cff4eb29e0bd50d871e1c1b7812408fd3a8863a060"` [INFO] [stderr] Checking shellexpand v1.0.0 [INFO] [stderr] Checking memchr v1.0.1 [INFO] [stderr] Checking toml v0.4.2 [INFO] [stderr] Checking clap v2.25.0 [INFO] [stderr] Compiling serde_derive v1.0.9 [INFO] [stderr] Checking aho-corasick v0.6.3 [INFO] [stderr] Checking regex v0.2.2 [INFO] [stderr] Checking globset v0.2.0 [INFO] [stderr] Checking ignore v0.2.0 [INFO] [stderr] Checking scrubjay v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | action: action, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `action` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/package/links.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | package: package, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `package` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/package/links.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | walker: walker, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `walker` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/package/links.rs:41:29 [INFO] [stderr] | [INFO] [stderr] 41 | entry: entry, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `entry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/package/links.rs:42:29 [INFO] [stderr] | [INFO] [stderr] 42 | target_path: target_path, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `target_path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/package/mod.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/package/mod.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/package/mod.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | program_config: program_config, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `program_config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | action: action, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `action` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/package/links.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | package: package, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `package` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/package/links.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | walker: walker, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `walker` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/package/links.rs:41:29 [INFO] [stderr] | [INFO] [stderr] 41 | entry: entry, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `entry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/package/links.rs:42:29 [INFO] [stderr] | [INFO] [stderr] 42 | target_path: target_path, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `target_path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/package/mod.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/package/mod.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/package/mod.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | program_config: program_config, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `program_config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config.rs:11:21 [INFO] [stderr] | [INFO] [stderr] 11 | const ARG_DRY_RUN: &'static str = "dry-run"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config.rs:12:19 [INFO] [stderr] | [INFO] [stderr] 12 | const ARG_FORCE: &'static str = "force"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config.rs:13:22 [INFO] [stderr] | [INFO] [stderr] 13 | const ARG_PACKAGES: &'static str = "packages"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config.rs:14:21 [INFO] [stderr] | [INFO] [stderr] 14 | const ARG_VERBOSE: &'static str = "verbose"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/package/config.rs:9:30 [INFO] [stderr] | [INFO] [stderr] 9 | pub const DEFAULT_FILENAME: &'static str = ".scrubjay.toml"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/package/mod.rs:22:24 [INFO] [stderr] | [INFO] [stderr] 22 | const DEFAULT_TARGET: &'static str = "~"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/package/mod.rs:23:25 [INFO] [stderr] | [INFO] [stderr] 23 | const IGNORE_FILENAME: &'static str = ".ignore"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/package/mod.rs:24:16 [INFO] [stderr] | [INFO] [stderr] 24 | const INDENT: &'static str = "‣ "; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config.rs:11:21 [INFO] [stderr] | [INFO] [stderr] 11 | const ARG_DRY_RUN: &'static str = "dry-run"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config.rs:12:19 [INFO] [stderr] | [INFO] [stderr] 12 | const ARG_FORCE: &'static str = "force"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config.rs:13:22 [INFO] [stderr] | [INFO] [stderr] 13 | const ARG_PACKAGES: &'static str = "packages"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config.rs:14:21 [INFO] [stderr] | [INFO] [stderr] 14 | const ARG_VERBOSE: &'static str = "verbose"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/package/config.rs:9:30 [INFO] [stderr] | [INFO] [stderr] 9 | pub const DEFAULT_FILENAME: &'static str = ".scrubjay.toml"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/package/mod.rs:22:24 [INFO] [stderr] | [INFO] [stderr] 22 | const DEFAULT_TARGET: &'static str = "~"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/package/mod.rs:23:25 [INFO] [stderr] | [INFO] [stderr] 23 | const IGNORE_FILENAME: &'static str = ".ignore"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/package/mod.rs:24:16 [INFO] [stderr] | [INFO] [stderr] 24 | const INDENT: &'static str = "‣ "; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/package/config.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | / pub fn from_str(toml_str: &str) -> Result { [INFO] [stderr] 45 | | toml::from_str(toml_str).map_err(Error::from) [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/package/links.rs:36:20 [INFO] [stderr] | [INFO] [stderr] 36 | if entry.path() == &self.package.path { [INFO] [stderr] | ^^^^^^^^^^^^^^^^------------------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `self.package.path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/package/mod.rs:347:31 [INFO] [stderr] | [INFO] [stderr] 347 | let safe_str = if let Some(_) = raw_str.find(char::is_whitespace) { [INFO] [stderr] | ________________________- ^^^^^^^ [INFO] [stderr] 348 | | format!("`{}`", raw_str) [INFO] [stderr] 349 | | } else { [INFO] [stderr] 350 | | raw_str.to_string() [INFO] [stderr] 351 | | }; [INFO] [stderr] | |_________- help: try this: `if raw_str.find(char::is_whitespace).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/package/mod.rs:370:12 [INFO] [stderr] | [INFO] [stderr] 370 | Ok(fs::remove_dir_all(path)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 370 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/package/mod.rs:372:12 [INFO] [stderr] | [INFO] [stderr] 372 | Ok(fs::remove_file(path)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 372 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/package/config.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | / pub fn from_str(toml_str: &str) -> Result { [INFO] [stderr] 45 | | toml::from_str(toml_str).map_err(Error::from) [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/package/links.rs:36:20 [INFO] [stderr] | [INFO] [stderr] 36 | if entry.path() == &self.package.path { [INFO] [stderr] | ^^^^^^^^^^^^^^^^------------------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `self.package.path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/package/mod.rs:347:31 [INFO] [stderr] | [INFO] [stderr] 347 | let safe_str = if let Some(_) = raw_str.find(char::is_whitespace) { [INFO] [stderr] | ________________________- ^^^^^^^ [INFO] [stderr] 348 | | format!("`{}`", raw_str) [INFO] [stderr] 349 | | } else { [INFO] [stderr] 350 | | raw_str.to_string() [INFO] [stderr] 351 | | }; [INFO] [stderr] | |_________- help: try this: `if raw_str.find(char::is_whitespace).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/package/mod.rs:370:12 [INFO] [stderr] | [INFO] [stderr] 370 | Ok(fs::remove_dir_all(path)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 370 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/package/mod.rs:372:12 [INFO] [stderr] | [INFO] [stderr] 372 | Ok(fs::remove_file(path)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 372 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 18.27s [INFO] running `"docker" "inspect" "748b56e7207c535cfe86b5cff4eb29e0bd50d871e1c1b7812408fd3a8863a060"` [INFO] running `"docker" "rm" "-f" "748b56e7207c535cfe86b5cff4eb29e0bd50d871e1c1b7812408fd3a8863a060"` [INFO] [stdout] 748b56e7207c535cfe86b5cff4eb29e0bd50d871e1c1b7812408fd3a8863a060