[INFO] updating cached repository jchristgit/rusday [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jchristgit/rusday [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jchristgit/rusday" "work/ex/clippy-test-run/sources/stable/gh/jchristgit/rusday"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jchristgit/rusday'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jchristgit/rusday" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jchristgit/rusday"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jchristgit/rusday'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 51fe7f32fa687a69071f87538df6f5e850500614 [INFO] sha for GitHub repo jchristgit/rusday: 51fe7f32fa687a69071f87538df6f5e850500614 [INFO] validating manifest of jchristgit/rusday on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jchristgit/rusday on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jchristgit/rusday [INFO] finished frobbing jchristgit/rusday [INFO] frobbed toml for jchristgit/rusday written to work/ex/clippy-test-run/sources/stable/gh/jchristgit/rusday/Cargo.toml [INFO] started frobbing jchristgit/rusday [INFO] finished frobbing jchristgit/rusday [INFO] frobbed toml for jchristgit/rusday written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jchristgit/rusday/Cargo.toml [INFO] crate jchristgit/rusday has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jchristgit/rusday against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jchristgit/rusday:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c9a839ab0a948a1e91a836a7d5c6cbb68491d5d54f56903edc75ff8d67a976a7 [INFO] running `"docker" "start" "-a" "c9a839ab0a948a1e91a836a7d5c6cbb68491d5d54f56903edc75ff8d67a976a7"` [INFO] [stderr] Compiling libsqlite3-sys v0.9.3 [INFO] [stderr] Checking isatty v0.1.9 [INFO] [stderr] Checking clap v2.29.4 [INFO] [stderr] Checking rusqlite v0.13.0 [INFO] [stderr] Checking rusday v0.6.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | date: date, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `date` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | date: date, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `date` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/add.rs:33:12 [INFO] [stderr] | [INFO] [stderr] 33 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 34 | | if color { [INFO] [stderr] 35 | | Err(format!( [INFO] [stderr] 36 | | "{}: Failed to add `{}` due to a date parsing error. Are you sure it's formatted correctly?", [INFO] [stderr] ... | [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 33 | } else if color { [INFO] [stderr] 34 | Err(format!( [INFO] [stderr] 35 | "{}: Failed to add `{}` due to a date parsing error. Are you sure it's formatted correctly?", [INFO] [stderr] 36 | Red.paint("error"), [INFO] [stderr] 37 | Style::new().bold().paint(name) [INFO] [stderr] 38 | )) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/add.rs:33:12 [INFO] [stderr] | [INFO] [stderr] 33 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 34 | | if color { [INFO] [stderr] 35 | | Err(format!( [INFO] [stderr] 36 | | "{}: Failed to add `{}` due to a date parsing error. Are you sure it's formatted correctly?", [INFO] [stderr] ... | [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 33 | } else if color { [INFO] [stderr] 34 | Err(format!( [INFO] [stderr] 35 | "{}: Failed to add `{}` due to a date parsing error. Are you sure it's formatted correctly?", [INFO] [stderr] 36 | Red.paint("error"), [INFO] [stderr] 37 | Style::new().bold().paint(name) [INFO] [stderr] 38 | )) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/add.rs:57:52 [INFO] [stderr] | [INFO] [stderr] 57 | let birth_date = NaiveDate::from_ymd(1990, 01, 01); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 57 | let birth_date = NaiveDate::from_ymd(1990, 1, 01); [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 57 | let birth_date = NaiveDate::from_ymd(1990, 0o1, 01); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/add.rs:57:56 [INFO] [stderr] | [INFO] [stderr] 57 | let birth_date = NaiveDate::from_ymd(1990, 01, 01); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 57 | let birth_date = NaiveDate::from_ymd(1990, 01, 1); [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 57 | let birth_date = NaiveDate::from_ymd(1990, 01, 0o1); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/dashboard.rs:32:8 [INFO] [stderr] | [INFO] [stderr] 32 | Ok(format!("")) [INFO] [stderr] | ^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/list.rs:33:8 [INFO] [stderr] | [INFO] [stderr] 33 | Ok(format!("")) [INFO] [stderr] | ^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/dashboard.rs:32:8 [INFO] [stderr] | [INFO] [stderr] 32 | Ok(format!("")) [INFO] [stderr] | ^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/list.rs:33:8 [INFO] [stderr] | [INFO] [stderr] 33 | Ok(format!("")) [INFO] [stderr] | ^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.93s [INFO] running `"docker" "inspect" "c9a839ab0a948a1e91a836a7d5c6cbb68491d5d54f56903edc75ff8d67a976a7"` [INFO] running `"docker" "rm" "-f" "c9a839ab0a948a1e91a836a7d5c6cbb68491d5d54f56903edc75ff8d67a976a7"` [INFO] [stdout] c9a839ab0a948a1e91a836a7d5c6cbb68491d5d54f56903edc75ff8d67a976a7