[INFO] updating cached repository jaysonsantos/bad-encryption-example [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jaysonsantos/bad-encryption-example [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jaysonsantos/bad-encryption-example" "work/ex/clippy-test-run/sources/stable/gh/jaysonsantos/bad-encryption-example"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jaysonsantos/bad-encryption-example'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jaysonsantos/bad-encryption-example" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jaysonsantos/bad-encryption-example"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jaysonsantos/bad-encryption-example'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 175f0ca058de91bc3052b66c3406f861ea64bf65 [INFO] sha for GitHub repo jaysonsantos/bad-encryption-example: 175f0ca058de91bc3052b66c3406f861ea64bf65 [INFO] validating manifest of jaysonsantos/bad-encryption-example on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jaysonsantos/bad-encryption-example on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jaysonsantos/bad-encryption-example [INFO] finished frobbing jaysonsantos/bad-encryption-example [INFO] frobbed toml for jaysonsantos/bad-encryption-example written to work/ex/clippy-test-run/sources/stable/gh/jaysonsantos/bad-encryption-example/Cargo.toml [INFO] started frobbing jaysonsantos/bad-encryption-example [INFO] finished frobbing jaysonsantos/bad-encryption-example [INFO] frobbed toml for jaysonsantos/bad-encryption-example written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jaysonsantos/bad-encryption-example/Cargo.toml [INFO] crate jaysonsantos/bad-encryption-example has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jaysonsantos/bad-encryption-example against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jaysonsantos/bad-encryption-example:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 446619792cc0bb4897feeb94142ee9615c2357a455edb81a16c426e7dede36a0 [INFO] running `"docker" "start" "-a" "446619792cc0bb4897feeb94142ee9615c2357a455edb81a16c426e7dede36a0"` [INFO] [stderr] Compiling deque v0.3.2 [INFO] [stderr] Compiling num_cpus v1.4.0 [INFO] [stderr] Checking num-complex v0.1.37 [INFO] [stderr] Checking deflate v0.7.7 [INFO] [stderr] Checking num-bigint v0.1.37 [INFO] [stderr] Checking rayon-core v1.0.0 [INFO] [stderr] Checking rayon v0.7.0 [INFO] [stderr] Checking num-rational v0.1.36 [INFO] [stderr] Checking png v0.6.2 [INFO] [stderr] Checking num v0.1.37 [INFO] [stderr] Checking jpeg-decoder v0.1.12 [INFO] [stderr] Compiling ring v0.7.5 [INFO] [stderr] Checking image v0.12.4 [INFO] [stderr] Checking bad-encryption-example v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:64:17 [INFO] [stderr] | [INFO] [stderr] 64 | let mut imgbuf = img.as_mut_rgb8().unwrap(); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:64:17 [INFO] [stderr] | [INFO] [stderr] 64 | let mut imgbuf = img.as_mut_rgb8().unwrap(); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/main.rs:80:39 [INFO] [stderr] | [INFO] [stderr] 80 | for channel_number in 0..channels.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try replacing the loop by: `channels.clone_from_slice(&in_out[..channels.len()])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/main.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | / let _ = ImageRgb8(imgbuf.clone()) [INFO] [stderr] 89 | | .save(&mut out_file, ImageFormat::JPEG) [INFO] [stderr] 90 | | .unwrap(); [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:64:17 [INFO] [stderr] | [INFO] [stderr] 64 | let mut imgbuf = img.as_mut_rgb8().unwrap(); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:64:17 [INFO] [stderr] | [INFO] [stderr] 64 | let mut imgbuf = img.as_mut_rgb8().unwrap(); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/main.rs:80:39 [INFO] [stderr] | [INFO] [stderr] 80 | for channel_number in 0..channels.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try replacing the loop by: `channels.clone_from_slice(&in_out[..channels.len()])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/main.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | / let _ = ImageRgb8(imgbuf.clone()) [INFO] [stderr] 89 | | .save(&mut out_file, ImageFormat::JPEG) [INFO] [stderr] 90 | | .unwrap(); [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.10s [INFO] running `"docker" "inspect" "446619792cc0bb4897feeb94142ee9615c2357a455edb81a16c426e7dede36a0"` [INFO] running `"docker" "rm" "-f" "446619792cc0bb4897feeb94142ee9615c2357a455edb81a16c426e7dede36a0"` [INFO] [stdout] 446619792cc0bb4897feeb94142ee9615c2357a455edb81a16c426e7dede36a0