[INFO] updating cached repository jay-tyler/rust_toy_raytracer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jay-tyler/rust_toy_raytracer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jay-tyler/rust_toy_raytracer" "work/ex/clippy-test-run/sources/stable/gh/jay-tyler/rust_toy_raytracer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jay-tyler/rust_toy_raytracer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jay-tyler/rust_toy_raytracer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jay-tyler/rust_toy_raytracer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jay-tyler/rust_toy_raytracer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0d513f7aa2732c3248e89421b72675fe95ec76cb [INFO] sha for GitHub repo jay-tyler/rust_toy_raytracer: 0d513f7aa2732c3248e89421b72675fe95ec76cb [INFO] validating manifest of jay-tyler/rust_toy_raytracer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jay-tyler/rust_toy_raytracer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jay-tyler/rust_toy_raytracer [INFO] finished frobbing jay-tyler/rust_toy_raytracer [INFO] frobbed toml for jay-tyler/rust_toy_raytracer written to work/ex/clippy-test-run/sources/stable/gh/jay-tyler/rust_toy_raytracer/Cargo.toml [INFO] started frobbing jay-tyler/rust_toy_raytracer [INFO] finished frobbing jay-tyler/rust_toy_raytracer [INFO] frobbed toml for jay-tyler/rust_toy_raytracer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jay-tyler/rust_toy_raytracer/Cargo.toml [INFO] crate jay-tyler/rust_toy_raytracer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jay-tyler/rust_toy_raytracer against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jay-tyler/rust_toy_raytracer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c93870d2624bb6ee85a48ed47d4209361a90e4a22550e03728ede812eec71b58 [INFO] running `"docker" "start" "-a" "c93870d2624bb6ee85a48ed47d4209361a90e4a22550e03728ede812eec71b58"` [INFO] [stderr] Checking ray_tracer v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hitable.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | return hit_anything; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `hit_anything` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/camera.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / return Ray{ [INFO] [stderr] 14 | | origin: self.origin, [INFO] [stderr] 15 | | direction: self.lower_left_corner + self.horizontal * u + self.vertical * v - self.origin, [INFO] [stderr] 16 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 13 | Ray{ [INFO] [stderr] 14 | origin: self.origin, [INFO] [stderr] 15 | direction: self.lower_left_corner + self.horizontal * u + self.vertical * v - self.origin, [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hitable.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | return hit_anything; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `hit_anything` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/camera.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / return Ray{ [INFO] [stderr] 14 | | origin: self.origin, [INFO] [stderr] 15 | | direction: self.lower_left_corner + self.horizontal * u + self.vertical * v - self.origin, [INFO] [stderr] 16 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 13 | Ray{ [INFO] [stderr] 14 | origin: self.origin, [INFO] [stderr] 15 | direction: self.lower_left_corner + self.horizontal * u + self.vertical * v - self.origin, [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | assert_eq!(v1.0, 1.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | assert_eq!(v1.0, 1.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | assert_eq!(vsum.0, 6.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | assert_eq!(vsum.0, 6.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | assert_eq!(vsum.1, 9.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | assert_eq!(vsum.1, 9.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | assert_eq!(vsum.2, 11.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | assert_eq!(vsum.2, 11.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | assert_eq!(vdiff.0, 4.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | assert_eq!(vdiff.0, 4.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | assert_eq!(vdiff.1, 5.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | assert_eq!(vdiff.1, 5.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | assert_eq!(vdiff.2, 5.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | assert_eq!(vdiff.2, 5.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | assert_eq!(vdiff.0, -0.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | assert_eq!(vdiff.0, -0.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | assert_eq!(vdiff.1, 0.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | assert_eq!(vdiff.1, 0.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | assert_eq!(vdiff.2, 1.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | assert_eq!(vdiff.2, 1.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | assert_eq!(vdot, 43. as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | assert_eq!(vdot, 43. as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | assert_eq!(v.magnitude(), expected); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | assert_eq!(v.magnitude(), expected); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | assert_eq!(h.t, 4.5_f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | assert_eq!(h.t, 4.5_f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 13 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `ray_tracer`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused import: `ray_tracer::rays::Ray` [INFO] [stderr] --> src/main.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use ray_tracer::rays::Ray; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | / return ThreeVector( [INFO] [stderr] 18 | | rec.normal.0 + 1., [INFO] [stderr] 19 | | rec.normal.1 + 1., [INFO] [stderr] 20 | | rec.normal.2 + 1., [INFO] [stderr] 21 | | ) * 0.5; [INFO] [stderr] | |________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 17 | ThreeVector( [INFO] [stderr] 18 | rec.normal.0 + 1., [INFO] [stderr] 19 | rec.normal.1 + 1., [INFO] [stderr] 20 | rec.normal.2 + 1., [INFO] [stderr] 21 | ) * 0.5 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | / return ThreeVector(1.0, 1.0, 1.0) * (1.0 - t) + [INFO] [stderr] 26 | | ThreeVector(0.5, 0.7, 1.0) * t; [INFO] [stderr] | |______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 25 | ThreeVector(1.0, 1.0, 1.0) * (1.0 - t) + [INFO] [stderr] 26 | ThreeVector(0.5, 0.7, 1.0) * t [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `lower_left_corner` [INFO] [stderr] --> src/main.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | let lower_left_corner = ray_tracer::vectors::ThreeVector(-2.,-1., -1.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using `_lower_left_corner` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `horizontal` [INFO] [stderr] --> src/main.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | let horizontal = ray_tracer::vectors::ThreeVector(4., 0., 0.); [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_horizontal` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `vertical` [INFO] [stderr] --> src/main.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | let vertical = ray_tracer::vectors::ThreeVector(0.,2., 0.); [INFO] [stderr] | ^^^^^^^^ help: consider using `_vertical` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `origin` [INFO] [stderr] --> src/main.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | let origin = ray_tracer::vectors::ThreeVector(0.,0.,0.); [INFO] [stderr] | ^^^^^^ help: consider using `_origin` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `p` [INFO] [stderr] --> src/main.rs:71:25 [INFO] [stderr] | [INFO] [stderr] 71 | let p = r.point_at_parameter(2.0); [INFO] [stderr] | ^ help: consider using `_p` instead [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `array`. [INFO] [stderr] --> src/main.rs:32:14 [INFO] [stderr] | [INFO] [stderr] 32 | for i in 0..100 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 32 | for in &mut array { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `ray_tracer::rays::Ray` [INFO] [stderr] --> src/main.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use ray_tracer::rays::Ray; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | / return ThreeVector( [INFO] [stderr] 18 | | rec.normal.0 + 1., [INFO] [stderr] 19 | | rec.normal.1 + 1., [INFO] [stderr] 20 | | rec.normal.2 + 1., [INFO] [stderr] 21 | | ) * 0.5; [INFO] [stderr] | |________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 17 | ThreeVector( [INFO] [stderr] 18 | rec.normal.0 + 1., [INFO] [stderr] 19 | rec.normal.1 + 1., [INFO] [stderr] 20 | rec.normal.2 + 1., [INFO] [stderr] 21 | ) * 0.5 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | / return ThreeVector(1.0, 1.0, 1.0) * (1.0 - t) + [INFO] [stderr] 26 | | ThreeVector(0.5, 0.7, 1.0) * t; [INFO] [stderr] | |______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 25 | ThreeVector(1.0, 1.0, 1.0) * (1.0 - t) + [INFO] [stderr] 26 | ThreeVector(0.5, 0.7, 1.0) * t [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:68:26 [INFO] [stderr] | [INFO] [stderr] 68 | u = (i as f64 + u) / nx as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:68:42 [INFO] [stderr] | [INFO] [stderr] 68 | u = (i as f64 + u) / nx as f64; [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(nx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:69:26 [INFO] [stderr] | [INFO] [stderr] 69 | v = (j as f64 + v) / ny as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(j)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:69:42 [INFO] [stderr] | [INFO] [stderr] 69 | v = (j as f64 + v) / ny as f64; [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(ny)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused variable: `lower_left_corner` [INFO] [stderr] --> src/main.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | let lower_left_corner = ray_tracer::vectors::ThreeVector(-2.,-1., -1.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using `_lower_left_corner` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `horizontal` [INFO] [stderr] --> src/main.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | let horizontal = ray_tracer::vectors::ThreeVector(4., 0., 0.); [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_horizontal` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `vertical` [INFO] [stderr] --> src/main.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | let vertical = ray_tracer::vectors::ThreeVector(0.,2., 0.); [INFO] [stderr] | ^^^^^^^^ help: consider using `_vertical` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `origin` [INFO] [stderr] --> src/main.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | let origin = ray_tracer::vectors::ThreeVector(0.,0.,0.); [INFO] [stderr] | ^^^^^^ help: consider using `_origin` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `p` [INFO] [stderr] --> src/main.rs:71:25 [INFO] [stderr] | [INFO] [stderr] 71 | let p = r.point_at_parameter(2.0); [INFO] [stderr] | ^ help: consider using `_p` instead [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `array`. [INFO] [stderr] --> src/main.rs:32:14 [INFO] [stderr] | [INFO] [stderr] 32 | for i in 0..100 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 32 | for in &mut array { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:68:26 [INFO] [stderr] | [INFO] [stderr] 68 | u = (i as f64 + u) / nx as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:68:42 [INFO] [stderr] | [INFO] [stderr] 68 | u = (i as f64 + u) / nx as f64; [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(nx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:69:26 [INFO] [stderr] | [INFO] [stderr] 69 | v = (j as f64 + v) / ny as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(j)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:69:42 [INFO] [stderr] | [INFO] [stderr] 69 | v = (j as f64 + v) / ny as f64; [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(ny)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "c93870d2624bb6ee85a48ed47d4209361a90e4a22550e03728ede812eec71b58"` [INFO] running `"docker" "rm" "-f" "c93870d2624bb6ee85a48ed47d4209361a90e4a22550e03728ede812eec71b58"` [INFO] [stdout] c93870d2624bb6ee85a48ed47d4209361a90e4a22550e03728ede812eec71b58