[INFO] updating cached repository jasonwhite/button-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jasonwhite/button-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jasonwhite/button-rs" "work/ex/clippy-test-run/sources/stable/gh/jasonwhite/button-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jasonwhite/button-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jasonwhite/button-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jasonwhite/button-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jasonwhite/button-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 31567ec08aa213d567691721fc672da92f7beee4 [INFO] sha for GitHub repo jasonwhite/button-rs: 31567ec08aa213d567691721fc672da92f7beee4 [INFO] validating manifest of jasonwhite/button-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jasonwhite/button-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jasonwhite/button-rs [INFO] finished frobbing jasonwhite/button-rs [INFO] frobbed toml for jasonwhite/button-rs written to work/ex/clippy-test-run/sources/stable/gh/jasonwhite/button-rs/Cargo.toml [INFO] started frobbing jasonwhite/button-rs [INFO] finished frobbing jasonwhite/button-rs [INFO] frobbed toml for jasonwhite/button-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jasonwhite/button-rs/Cargo.toml [INFO] crate jasonwhite/button-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jasonwhite/button-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jasonwhite/button-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3c7c88e5957acb9f8e28893db48e31165614a8da844fece50140eabf927802bf [INFO] running `"docker" "start" "-a" "3c7c88e5957acb9f8e28893db48e31165614a8da844fece50140eabf927802bf"` [INFO] [stderr] Checking holyhashmap v0.1.1 [INFO] [stderr] Checking generic-array v0.9.0 [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Checking os_pipe v0.8.0 [INFO] [stderr] Checking nom v4.1.1 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking crossbeam-channel v0.3.2 [INFO] [stderr] Checking tokio-threadpool v0.1.9 [INFO] [stderr] Checking tempfile v3.0.5 [INFO] [stderr] Checking digest v0.7.6 [INFO] [stderr] Checking sha2 v0.7.1 [INFO] [stderr] Checking tokio-fs v0.1.4 [INFO] [stderr] Checking crossbeam v0.5.0 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking tokio-reactor v0.1.7 [INFO] [stderr] Checking tokio-uds v0.2.4 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio v0.1.13 [INFO] [stderr] Checking hyper v0.12.16 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking reqwest v0.9.5 [INFO] [stderr] Checking button v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/button/build_graph.rs:634:45 [INFO] [stderr] | [INFO] [stderr] 634 | Error::Cycles(CyclesError { graph: _, cycles }) => cycles, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `CyclesError { cycles, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/button/build_graph.rs:579:13 [INFO] [stderr] | [INFO] [stderr] 579 | let foo = File::from("foo.o").into(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/button/build_graph.rs:580:13 [INFO] [stderr] | [INFO] [stderr] 580 | let bar = File::from("bar.o").into(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/button/rules.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | / pub fn from_str(s: &str) -> Result { [INFO] [stderr] 90 | | Ok(Self::new(json::from_str(s)?)) [INFO] [stderr] 91 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 43.87s [INFO] running `"docker" "inspect" "3c7c88e5957acb9f8e28893db48e31165614a8da844fece50140eabf927802bf"` [INFO] running `"docker" "rm" "-f" "3c7c88e5957acb9f8e28893db48e31165614a8da844fece50140eabf927802bf"` [INFO] [stdout] 3c7c88e5957acb9f8e28893db48e31165614a8da844fece50140eabf927802bf