[INFO] updating cached repository jaroslaw-weber/vote-for-rust-idea [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jaroslaw-weber/vote-for-rust-idea [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jaroslaw-weber/vote-for-rust-idea" "work/ex/clippy-test-run/sources/stable/gh/jaroslaw-weber/vote-for-rust-idea"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jaroslaw-weber/vote-for-rust-idea'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jaroslaw-weber/vote-for-rust-idea" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jaroslaw-weber/vote-for-rust-idea"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jaroslaw-weber/vote-for-rust-idea'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6c01152a62536ccd1ece3774323c47fd135cac6b [INFO] sha for GitHub repo jaroslaw-weber/vote-for-rust-idea: 6c01152a62536ccd1ece3774323c47fd135cac6b [INFO] validating manifest of jaroslaw-weber/vote-for-rust-idea on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jaroslaw-weber/vote-for-rust-idea on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jaroslaw-weber/vote-for-rust-idea [INFO] finished frobbing jaroslaw-weber/vote-for-rust-idea [INFO] frobbed toml for jaroslaw-weber/vote-for-rust-idea written to work/ex/clippy-test-run/sources/stable/gh/jaroslaw-weber/vote-for-rust-idea/Cargo.toml [INFO] started frobbing jaroslaw-weber/vote-for-rust-idea [INFO] finished frobbing jaroslaw-weber/vote-for-rust-idea [INFO] frobbed toml for jaroslaw-weber/vote-for-rust-idea written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jaroslaw-weber/vote-for-rust-idea/Cargo.toml [INFO] crate jaroslaw-weber/vote-for-rust-idea has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jaroslaw-weber/vote-for-rust-idea against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jaroslaw-weber/vote-for-rust-idea:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2c39768eda16b98eed55da45f30ff10e8f88b523517d9006ab91f55d5c332466 [INFO] running `"docker" "start" "-a" "2c39768eda16b98eed55da45f30ff10e8f88b523517d9006ab91f55d5c332466"` [INFO] [stderr] Checking csv v0.15.0 [INFO] [stderr] Checking regex v0.2.2 [INFO] [stderr] Checking handlebars v0.29.1 [INFO] [stderr] Checking slime v0.2.0 [INFO] [stderr] Checking vote-for-rust-idea v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:58:43 [INFO] [stderr] | [INFO] [stderr] 58 | let splitted = file_content.split(","); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:103:47 [INFO] [stderr] | [INFO] [stderr] 103 | votes.iter().map(|(k, v)| (k.clone(), v.clone())).collect(); [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*v` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:115:22 [INFO] [stderr] | [INFO] [stderr] 115 | .expect(&format!("failed to find idea with this name! name: {}", &k)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("failed to find idea with this name! name: {}", &k))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:151:31 [INFO] [stderr] | [INFO] [stderr] 151 | let splitted = path.split("/"); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:153:44 [INFO] [stderr] | [INFO] [stderr] 153 | let mut without_extension = last.split("."); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:58:43 [INFO] [stderr] | [INFO] [stderr] 58 | let splitted = file_content.split(","); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:103:47 [INFO] [stderr] | [INFO] [stderr] 103 | votes.iter().map(|(k, v)| (k.clone(), v.clone())).collect(); [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*v` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:115:22 [INFO] [stderr] | [INFO] [stderr] 115 | .expect(&format!("failed to find idea with this name! name: {}", &k)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("failed to find idea with this name! name: {}", &k))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:151:31 [INFO] [stderr] | [INFO] [stderr] 151 | let splitted = path.split("/"); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:153:44 [INFO] [stderr] | [INFO] [stderr] 153 | let mut without_extension = last.split("."); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.59s [INFO] running `"docker" "inspect" "2c39768eda16b98eed55da45f30ff10e8f88b523517d9006ab91f55d5c332466"` [INFO] running `"docker" "rm" "-f" "2c39768eda16b98eed55da45f30ff10e8f88b523517d9006ab91f55d5c332466"` [INFO] [stdout] 2c39768eda16b98eed55da45f30ff10e8f88b523517d9006ab91f55d5c332466