[INFO] updating cached repository jaroslaw-weber/github_autogen [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jaroslaw-weber/github_autogen [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jaroslaw-weber/github_autogen" "work/ex/clippy-test-run/sources/stable/gh/jaroslaw-weber/github_autogen"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jaroslaw-weber/github_autogen'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jaroslaw-weber/github_autogen" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jaroslaw-weber/github_autogen"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jaroslaw-weber/github_autogen'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d2b436a609133e2c9ee3d4944732861416cf6cfb [INFO] sha for GitHub repo jaroslaw-weber/github_autogen: d2b436a609133e2c9ee3d4944732861416cf6cfb [INFO] validating manifest of jaroslaw-weber/github_autogen on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jaroslaw-weber/github_autogen on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jaroslaw-weber/github_autogen [INFO] finished frobbing jaroslaw-weber/github_autogen [INFO] frobbed toml for jaroslaw-weber/github_autogen written to work/ex/clippy-test-run/sources/stable/gh/jaroslaw-weber/github_autogen/Cargo.toml [INFO] started frobbing jaroslaw-weber/github_autogen [INFO] finished frobbing jaroslaw-weber/github_autogen [INFO] frobbed toml for jaroslaw-weber/github_autogen written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jaroslaw-weber/github_autogen/Cargo.toml [INFO] crate jaroslaw-weber/github_autogen has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jaroslaw-weber/github_autogen against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jaroslaw-weber/github_autogen:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cce373504fa14a2b2f3c375bc9f9461b6d91b4301cbc464456992f55e9edacfa [INFO] running `"docker" "start" "-a" "cce373504fa14a2b2f3c375bc9f9461b6d91b4301cbc464456992f55e9edacfa"` [INFO] [stderr] Compiling ring v0.12.1 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking hyper v0.11.17 [INFO] [stderr] Checking webpki v0.17.0 [INFO] [stderr] Checking sct v0.2.0 [INFO] [stderr] Checking ct-logs v0.2.0 [INFO] [stderr] Checking rustls v0.11.0 [INFO] [stderr] Checking webpki-roots v0.13.0 [INFO] [stderr] Checking tokio-rustls v0.4.0 [INFO] [stderr] Checking hyper-rustls v0.11.0 [INFO] [stderr] Checking github-rs v0.6.1 [INFO] [stderr] Checking github_autogen v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `headers` [INFO] [stderr] --> src/utils.rs:9:13 [INFO] [stderr] | [INFO] [stderr] 9 | Ok((headers, status, json)) => json, [INFO] [stderr] | ^^^^^^^ help: consider using `_headers` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `status` [INFO] [stderr] --> src/utils.rs:9:22 [INFO] [stderr] | [INFO] [stderr] 9 | Ok((headers, status, json)) => json, [INFO] [stderr] | ^^^^^^ help: consider using `_status` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/utils.rs:10:13 [INFO] [stderr] | [INFO] [stderr] 10 | Err(e) => None, [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `headers` [INFO] [stderr] --> src/utils.rs:9:13 [INFO] [stderr] | [INFO] [stderr] 9 | Ok((headers, status, json)) => json, [INFO] [stderr] | ^^^^^^^ help: consider using `_headers` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `status` [INFO] [stderr] --> src/utils.rs:9:22 [INFO] [stderr] | [INFO] [stderr] 9 | Ok((headers, status, json)) => json, [INFO] [stderr] | ^^^^^^ help: consider using `_status` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/utils.rs:10:13 [INFO] [stderr] | [INFO] [stderr] 10 | Err(e) => None, [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | write_all("src/lib.rs", &output); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | / match part.is_arg { [INFO] [stderr] 37 | | true => { [INFO] [stderr] 38 | | endpoint.push_str("{}"); [INFO] [stderr] 39 | | args.push_str(","); [INFO] [stderr] ... | [INFO] [stderr] 44 | | } [INFO] [stderr] 45 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 36 | if part.is_arg { [INFO] [stderr] 37 | endpoint.push_str("{}"); [INFO] [stderr] 38 | args.push_str(","); [INFO] [stderr] 39 | args.push_str(&part.content); [INFO] [stderr] 40 | } else { [INFO] [stderr] 41 | endpoint.push_str(&part.content); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | / match part.is_arg { [INFO] [stderr] 67 | | true => {} [INFO] [stderr] 68 | | false => { [INFO] [stderr] 69 | | signature.push_str("_"); [INFO] [stderr] 70 | | signature.push_str(&part.content); [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 66 | if !part.is_arg { [INFO] [stderr] 67 | signature.push_str("_"); [INFO] [stderr] 68 | signature.push_str(&part.content); [INFO] [stderr] 69 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:93:47 [INFO] [stderr] | [INFO] [stderr] 93 | let splited_once: Vec<&str> = input.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:98:29 [INFO] [stderr] | [INFO] [stderr] 98 | for part in parts.split("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | / match part.starts_with(":") { [INFO] [stderr] 100 | | true => { [INFO] [stderr] 101 | | let mut cloned = part.to_owned(); [INFO] [stderr] 102 | | cloned.drain(..1); [INFO] [stderr] ... | [INFO] [stderr] 115 | | } [INFO] [stderr] 116 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 99 | if part.starts_with(":") { [INFO] [stderr] 100 | let mut cloned = part.to_owned(); [INFO] [stderr] 101 | cloned.drain(..1); [INFO] [stderr] 102 | let p = ApiPart { [INFO] [stderr] 103 | content: cloned, [INFO] [stderr] 104 | is_arg: true, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:99:32 [INFO] [stderr] | [INFO] [stderr] 99 | match part.starts_with(":") { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | write_all("src/lib.rs", &output); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | / match part.is_arg { [INFO] [stderr] 37 | | true => { [INFO] [stderr] 38 | | endpoint.push_str("{}"); [INFO] [stderr] 39 | | args.push_str(","); [INFO] [stderr] ... | [INFO] [stderr] 44 | | } [INFO] [stderr] 45 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 36 | if part.is_arg { [INFO] [stderr] 37 | endpoint.push_str("{}"); [INFO] [stderr] 38 | args.push_str(","); [INFO] [stderr] 39 | args.push_str(&part.content); [INFO] [stderr] 40 | } else { [INFO] [stderr] 41 | endpoint.push_str(&part.content); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | / match part.is_arg { [INFO] [stderr] 67 | | true => {} [INFO] [stderr] 68 | | false => { [INFO] [stderr] 69 | | signature.push_str("_"); [INFO] [stderr] 70 | | signature.push_str(&part.content); [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 66 | if !part.is_arg { [INFO] [stderr] 67 | signature.push_str("_"); [INFO] [stderr] 68 | signature.push_str(&part.content); [INFO] [stderr] 69 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:93:47 [INFO] [stderr] | [INFO] [stderr] 93 | let splited_once: Vec<&str> = input.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:98:29 [INFO] [stderr] | [INFO] [stderr] 98 | for part in parts.split("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | / match part.starts_with(":") { [INFO] [stderr] 100 | | true => { [INFO] [stderr] 101 | | let mut cloned = part.to_owned(); [INFO] [stderr] 102 | | cloned.drain(..1); [INFO] [stderr] ... | [INFO] [stderr] 115 | | } [INFO] [stderr] 116 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 99 | if part.starts_with(":") { [INFO] [stderr] 100 | let mut cloned = part.to_owned(); [INFO] [stderr] 101 | cloned.drain(..1); [INFO] [stderr] 102 | let p = ApiPart { [INFO] [stderr] 103 | content: cloned, [INFO] [stderr] 104 | is_arg: true, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:99:32 [INFO] [stderr] | [INFO] [stderr] 99 | match part.starts_with(":") { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 30.58s [INFO] running `"docker" "inspect" "cce373504fa14a2b2f3c375bc9f9461b6d91b4301cbc464456992f55e9edacfa"` [INFO] running `"docker" "rm" "-f" "cce373504fa14a2b2f3c375bc9f9461b6d91b4301cbc464456992f55e9edacfa"` [INFO] [stdout] cce373504fa14a2b2f3c375bc9f9461b6d91b4301cbc464456992f55e9edacfa