[INFO] updating cached repository jaroslaw-weber/cookbook_data_parser [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jaroslaw-weber/cookbook_data_parser [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jaroslaw-weber/cookbook_data_parser" "work/ex/clippy-test-run/sources/stable/gh/jaroslaw-weber/cookbook_data_parser"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jaroslaw-weber/cookbook_data_parser'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jaroslaw-weber/cookbook_data_parser" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jaroslaw-weber/cookbook_data_parser"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jaroslaw-weber/cookbook_data_parser'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3ab1b51c3ffab5a25a8c1d1a0b93fda9b04e492e [INFO] sha for GitHub repo jaroslaw-weber/cookbook_data_parser: 3ab1b51c3ffab5a25a8c1d1a0b93fda9b04e492e [INFO] validating manifest of jaroslaw-weber/cookbook_data_parser on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jaroslaw-weber/cookbook_data_parser on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jaroslaw-weber/cookbook_data_parser [INFO] finished frobbing jaroslaw-weber/cookbook_data_parser [INFO] frobbed toml for jaroslaw-weber/cookbook_data_parser written to work/ex/clippy-test-run/sources/stable/gh/jaroslaw-weber/cookbook_data_parser/Cargo.toml [INFO] started frobbing jaroslaw-weber/cookbook_data_parser [INFO] finished frobbing jaroslaw-weber/cookbook_data_parser [INFO] frobbed toml for jaroslaw-weber/cookbook_data_parser written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jaroslaw-weber/cookbook_data_parser/Cargo.toml [INFO] crate jaroslaw-weber/cookbook_data_parser has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jaroslaw-weber/cookbook_data_parser against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jaroslaw-weber/cookbook_data_parser:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0b4eee95bd8a1f4e9c79998fad0ea1f8863a32ec08dd29cdcff200f2ed176020 [INFO] running `"docker" "start" "-a" "0b4eee95bd8a1f4e9c79998fad0ea1f8863a32ec08dd29cdcff200f2ed176020"` [INFO] [stderr] Checking fs_extra v1.0.0 [INFO] [stderr] Checking serde_json v1.0.5 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking cookbook_data_parser v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | recipes: recipes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `recipes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | link: link, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `link` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | meta: meta, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `meta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | content: content, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | recipes: recipes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `recipes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | link: link, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `link` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | meta: meta, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `meta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | content: content, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:79:24 [INFO] [stderr] | [INFO] [stderr] 79 | let name: String = match name_val { [INFO] [stderr] | ________________________^ [INFO] [stderr] 80 | | &DirEntryValue::String(ref name) => name.clone(), [INFO] [stderr] 81 | | _ => "failed to get folder name".to_string(), [INFO] [stderr] 82 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 79 | let name: String = match *name_val { [INFO] [stderr] 80 | DirEntryValue::String(ref name) => name.clone(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:79:24 [INFO] [stderr] | [INFO] [stderr] 79 | let name: String = match name_val { [INFO] [stderr] | ________________________^ [INFO] [stderr] 80 | | &DirEntryValue::String(ref name) => name.clone(), [INFO] [stderr] 81 | | _ => "failed to get folder name".to_string(), [INFO] [stderr] 82 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 79 | let name: String = match *name_val { [INFO] [stderr] 80 | DirEntryValue::String(ref name) => name.clone(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.37s [INFO] running `"docker" "inspect" "0b4eee95bd8a1f4e9c79998fad0ea1f8863a32ec08dd29cdcff200f2ed176020"` [INFO] running `"docker" "rm" "-f" "0b4eee95bd8a1f4e9c79998fad0ea1f8863a32ec08dd29cdcff200f2ed176020"` [INFO] [stdout] 0b4eee95bd8a1f4e9c79998fad0ea1f8863a32ec08dd29cdcff200f2ed176020