[INFO] updating cached repository jarhill0/rusty_euler [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jarhill0/rusty_euler [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jarhill0/rusty_euler" "work/ex/clippy-test-run/sources/stable/gh/jarhill0/rusty_euler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jarhill0/rusty_euler'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jarhill0/rusty_euler" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jarhill0/rusty_euler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jarhill0/rusty_euler'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f45512de86ad26810dacf1e1d5059bbf6f1826f5 [INFO] sha for GitHub repo jarhill0/rusty_euler: f45512de86ad26810dacf1e1d5059bbf6f1826f5 [INFO] validating manifest of jarhill0/rusty_euler on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jarhill0/rusty_euler on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jarhill0/rusty_euler [INFO] finished frobbing jarhill0/rusty_euler [INFO] frobbed toml for jarhill0/rusty_euler written to work/ex/clippy-test-run/sources/stable/gh/jarhill0/rusty_euler/Cargo.toml [INFO] started frobbing jarhill0/rusty_euler [INFO] finished frobbing jarhill0/rusty_euler [INFO] frobbed toml for jarhill0/rusty_euler written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jarhill0/rusty_euler/Cargo.toml [INFO] crate jarhill0/rusty_euler has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jarhill0/rusty_euler against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jarhill0/rusty_euler:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0ec29ab2a2ef07a76df44bbdbb38d374f0ce08b0aa1a92d5c4751402ea1fe75a [INFO] running `"docker" "start" "-a" "0ec29ab2a2ef07a76df44bbdbb38d374f0ce08b0aa1a92d5c4751402ea1fe75a"` [INFO] [stderr] Checking rusty_euler v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interface/p_003.rs:13:22 [INFO] [stderr] | [INFO] [stderr] 13 | largest_p_factor(600851475143) [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `600_851_475_143` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/interface/p_005.rs:7:23 [INFO] [stderr] | [INFO] [stderr] 7 | for mut factor in 2..(num + 1) { [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `2..=num` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/interface/p_005.rs:14:30 [INFO] [stderr] | [INFO] [stderr] 14 | fn factors(mut f: u32, &num: &u32) -> u32 { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/interface/p_005.rs:16:14 [INFO] [stderr] | [INFO] [stderr] 16 | for x in 2..(f + 1) { [INFO] [stderr] | ^^^^^^^^^^ help: use: `2..=f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/interface/p_006.rs:7:14 [INFO] [stderr] | [INFO] [stderr] 7 | for x in 1..n + 1 { [INFO] [stderr] | ^^^^^^^^ help: use: `1..=n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/interface/p_006.rs:15:14 [INFO] [stderr] | [INFO] [stderr] 15 | for x in 1..n + 1 { [INFO] [stderr] | ^^^^^^^^ help: use: `1..=n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/interface/p_007.rs:16:16 [INFO] [stderr] | [INFO] [stderr] 16 | let sqrt = (n as f64).sqrt() as u32; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/interface/p_007.rs:17:14 [INFO] [stderr] | [INFO] [stderr] 17 | for x in 2..sqrt + 1 { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `2..=sqrt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/interface/p_003.rs:13:22 [INFO] [stderr] | [INFO] [stderr] 13 | largest_p_factor(600851475143) [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `600_851_475_143` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/interface/p_005.rs:7:23 [INFO] [stderr] | [INFO] [stderr] 7 | for mut factor in 2..(num + 1) { [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `2..=num` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/interface/p_005.rs:14:30 [INFO] [stderr] | [INFO] [stderr] 14 | fn factors(mut f: u32, &num: &u32) -> u32 { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/interface/p_005.rs:16:14 [INFO] [stderr] | [INFO] [stderr] 16 | for x in 2..(f + 1) { [INFO] [stderr] | ^^^^^^^^^^ help: use: `2..=f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/interface/p_006.rs:7:14 [INFO] [stderr] | [INFO] [stderr] 7 | for x in 1..n + 1 { [INFO] [stderr] | ^^^^^^^^ help: use: `1..=n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/interface/p_006.rs:15:14 [INFO] [stderr] | [INFO] [stderr] 15 | for x in 1..n + 1 { [INFO] [stderr] | ^^^^^^^^ help: use: `1..=n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/interface/p_007.rs:16:16 [INFO] [stderr] | [INFO] [stderr] 16 | let sqrt = (n as f64).sqrt() as u32; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/interface/p_007.rs:17:14 [INFO] [stderr] | [INFO] [stderr] 17 | for x in 2..sqrt + 1 { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `2..=sqrt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.78s [INFO] running `"docker" "inspect" "0ec29ab2a2ef07a76df44bbdbb38d374f0ce08b0aa1a92d5c4751402ea1fe75a"` [INFO] running `"docker" "rm" "-f" "0ec29ab2a2ef07a76df44bbdbb38d374f0ce08b0aa1a92d5c4751402ea1fe75a"` [INFO] [stdout] 0ec29ab2a2ef07a76df44bbdbb38d374f0ce08b0aa1a92d5c4751402ea1fe75a