[INFO] updating cached repository jaredforth/pds_gen
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/jaredforth/pds_gen
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/jaredforth/pds_gen" "work/ex/clippy-test-run/sources/stable/gh/jaredforth/pds_gen"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jaredforth/pds_gen'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/jaredforth/pds_gen" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jaredforth/pds_gen"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jaredforth/pds_gen'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 4e5971280731cab4fd15c1c8ab649d9b4ddba9ac
[INFO] sha for GitHub repo jaredforth/pds_gen: 4e5971280731cab4fd15c1c8ab649d9b4ddba9ac
[INFO] validating manifest of jaredforth/pds_gen on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of jaredforth/pds_gen on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing jaredforth/pds_gen
[INFO] finished frobbing jaredforth/pds_gen
[INFO] frobbed toml for jaredforth/pds_gen written to work/ex/clippy-test-run/sources/stable/gh/jaredforth/pds_gen/Cargo.toml
[INFO] started frobbing jaredforth/pds_gen
[INFO] finished frobbing jaredforth/pds_gen
[INFO] frobbed toml for jaredforth/pds_gen written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jaredforth/pds_gen/Cargo.toml
[INFO] crate jaredforth/pds_gen has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting jaredforth/pds_gen against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jaredforth/pds_gen:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 66482fc9162c4012a34f806987775ecde797bbf0d0a56a7ab9eb5db3b0015082
[INFO] running `"docker" "start" "-a" "66482fc9162c4012a34f806987775ecde797bbf0d0a56a7ab9eb5db3b0015082"`
[INFO] [stderr]     Checking pds_gen v1.0.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/name.rs:7:9
[INFO] [stderr]   |
[INFO] [stderr] 7 |         return default_name(i);
[INFO] [stderr]   |         ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `default_name(i)`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/name.rs:9:9
[INFO] [stderr]   |
[INFO] [stderr] 9 |         return default;
[INFO] [stderr]   |         ^^^^^^^^^^^^^^^ help: remove `return` as shown: `default`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/name.rs:16:9
[INFO] [stderr]    |
[INFO] [stderr] 16 |         return name.to_string();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `name.to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/name.rs:19:9
[INFO] [stderr]    |
[INFO] [stderr] 19 |         return name.to_string();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `name.to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/dir.rs:80:5
[INFO] [stderr]    |
[INFO] [stderr] 80 |     return index;
[INFO] [stderr]    |     ^^^^^^^^^^^^^ help: remove `return` as shown: `index`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/name.rs:7:9
[INFO] [stderr]   |
[INFO] [stderr] 7 |         return default_name(i);
[INFO] [stderr]   |         ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `default_name(i)`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/name.rs:9:9
[INFO] [stderr]   |
[INFO] [stderr] 9 |         return default;
[INFO] [stderr]   |         ^^^^^^^^^^^^^^^ help: remove `return` as shown: `default`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/name.rs:16:9
[INFO] [stderr]    |
[INFO] [stderr] 16 |         return name.to_string();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `name.to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/name.rs:19:9
[INFO] [stderr]    |
[INFO] [stderr] 19 |         return name.to_string();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `name.to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/dir.rs:80:5
[INFO] [stderr]    |
[INFO] [stderr] 80 |     return index;
[INFO] [stderr]    |     ^^^^^^^^^^^^^ help: remove `return` as shown: `index`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/bin/main.rs:12:16
[INFO] [stderr]    |
[INFO] [stderr] 12 |     let path = format!("{}", name);
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `name.to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/bin/main.rs:12:16
[INFO] [stderr]    |
[INFO] [stderr] 12 |     let path = format!("{}", name);
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `name.to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.99s
[INFO] running `"docker" "inspect" "66482fc9162c4012a34f806987775ecde797bbf0d0a56a7ab9eb5db3b0015082"`
[INFO] running `"docker" "rm" "-f" "66482fc9162c4012a34f806987775ecde797bbf0d0a56a7ab9eb5db3b0015082"`
[INFO] [stdout] 66482fc9162c4012a34f806987775ecde797bbf0d0a56a7ab9eb5db3b0015082