[INFO] updating cached repository jaredforth/drake_equation [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jaredforth/drake_equation [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jaredforth/drake_equation" "work/ex/clippy-test-run/sources/stable/gh/jaredforth/drake_equation"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jaredforth/drake_equation'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jaredforth/drake_equation" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jaredforth/drake_equation"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jaredforth/drake_equation'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 52216454ee23b55d50c4d0a23ac6b3b0e10fe853 [INFO] sha for GitHub repo jaredforth/drake_equation: 52216454ee23b55d50c4d0a23ac6b3b0e10fe853 [INFO] validating manifest of jaredforth/drake_equation on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jaredforth/drake_equation on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jaredforth/drake_equation [INFO] finished frobbing jaredforth/drake_equation [INFO] frobbed toml for jaredforth/drake_equation written to work/ex/clippy-test-run/sources/stable/gh/jaredforth/drake_equation/Cargo.toml [INFO] started frobbing jaredforth/drake_equation [INFO] finished frobbing jaredforth/drake_equation [INFO] frobbed toml for jaredforth/drake_equation written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jaredforth/drake_equation/Cargo.toml [INFO] crate jaredforth/drake_equation has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jaredforth/drake_equation against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jaredforth/drake_equation:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b4f40b21e6ee755999934c4d63f7a29c07cba0e2849da5377039a9807a1dc691 [INFO] running `"docker" "start" "-a" "b4f40b21e6ee755999934c4d63f7a29c07cba0e2849da5377039a9807a1dc691"` [INFO] [stderr] Compiling ryu v0.2.3 [INFO] [stderr] Compiling syn v0.14.8 [INFO] [stderr] Checking serde_json v1.0.26 [INFO] [stderr] Compiling serde_derive v1.0.71 [INFO] [stderr] Checking drake_equation v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | return data; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | return e; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:83:12 [INFO] [stderr] | [INFO] [stderr] 83 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 84 | | if args.len() == 8 { [INFO] [stderr] 85 | | let r: f64 = args[1].trim().parse() [INFO] [stderr] 86 | | .expect("Not a number"); [INFO] [stderr] ... | [INFO] [stderr] 106 | | } [INFO] [stderr] 107 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 83 | } else if args.len() == 8 { [INFO] [stderr] 84 | let r: f64 = args[1].trim().parse() [INFO] [stderr] 85 | .expect("Not a number"); [INFO] [stderr] 86 | let fp: f64 = args[2].trim().parse() [INFO] [stderr] 87 | .expect("Not a number"); [INFO] [stderr] 88 | let ne: f64 = args[3].trim().parse() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | return data; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:127:5 [INFO] [stderr] | [INFO] [stderr] 127 | return n; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | return data; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | return e; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:83:12 [INFO] [stderr] | [INFO] [stderr] 83 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 84 | | if args.len() == 8 { [INFO] [stderr] 85 | | let r: f64 = args[1].trim().parse() [INFO] [stderr] 86 | | .expect("Not a number"); [INFO] [stderr] ... | [INFO] [stderr] 106 | | } [INFO] [stderr] 107 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 83 | } else if args.len() == 8 { [INFO] [stderr] 84 | let r: f64 = args[1].trim().parse() [INFO] [stderr] 85 | .expect("Not a number"); [INFO] [stderr] 86 | let fp: f64 = args[2].trim().parse() [INFO] [stderr] 87 | .expect("Not a number"); [INFO] [stderr] 88 | let ne: f64 = args[3].trim().parse() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | return data; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:127:5 [INFO] [stderr] | [INFO] [stderr] 127 | return n; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 19.98s [INFO] running `"docker" "inspect" "b4f40b21e6ee755999934c4d63f7a29c07cba0e2849da5377039a9807a1dc691"` [INFO] running `"docker" "rm" "-f" "b4f40b21e6ee755999934c4d63f7a29c07cba0e2849da5377039a9807a1dc691"` [INFO] [stdout] b4f40b21e6ee755999934c4d63f7a29c07cba0e2849da5377039a9807a1dc691