[INFO] updating cached repository jared-w/playing-with-ASTs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jared-w/playing-with-ASTs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jared-w/playing-with-ASTs" "work/ex/clippy-test-run/sources/stable/gh/jared-w/playing-with-ASTs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jared-w/playing-with-ASTs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jared-w/playing-with-ASTs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jared-w/playing-with-ASTs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jared-w/playing-with-ASTs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8726a2c6948c81127afffb5d1c9a52f9bc237172 [INFO] sha for GitHub repo jared-w/playing-with-ASTs: 8726a2c6948c81127afffb5d1c9a52f9bc237172 [INFO] validating manifest of jared-w/playing-with-ASTs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jared-w/playing-with-ASTs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jared-w/playing-with-ASTs [INFO] finished frobbing jared-w/playing-with-ASTs [INFO] frobbed toml for jared-w/playing-with-ASTs written to work/ex/clippy-test-run/sources/stable/gh/jared-w/playing-with-ASTs/Cargo.toml [INFO] started frobbing jared-w/playing-with-ASTs [INFO] finished frobbing jared-w/playing-with-ASTs [INFO] frobbed toml for jared-w/playing-with-ASTs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jared-w/playing-with-ASTs/Cargo.toml [INFO] crate jared-w/playing-with-ASTs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jared-w/playing-with-ASTs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jared-w/playing-with-ASTs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 770b1520bd09e0e859254359d13733dff2530c35400ed16532a190edd237f890 [INFO] running `"docker" "start" "-a" "770b1520bd09e0e859254359d13733dff2530c35400ed16532a190edd237f890"` [INFO] [stderr] Checking playing-with-ASTs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:104:21 [INFO] [stderr] | [INFO] [stderr] 104 | let s = self.clone().t_check_red(*a.clone())?; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/main.rs:105:21 [INFO] [stderr] | [INFO] [stderr] 105 | let r = self.clone().extend(x, *a.clone()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/main.rs:106:21 [INFO] [stderr] | [INFO] [stderr] 106 | let t = r.clone().t_check_red(*b)?; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:227:23 [INFO] [stderr] | [INFO] [stderr] 227 | Lam(s, t, e) => if s == *v { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/main.rs:231:25 [INFO] [stderr] | [INFO] [stderr] 231 | let i = s.alpha_rename(&x.free_vars().union(&e.free_vars()).cloned().collect()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:237:22 [INFO] [stderr] | [INFO] [stderr] 237 | Pi(s, k, t) => if s == *v { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/main.rs:241:25 [INFO] [stderr] | [INFO] [stderr] 241 | let i = s.alpha_rename(&x.free_vars().union(&t.free_vars()).cloned().collect()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:104:21 [INFO] [stderr] | [INFO] [stderr] 104 | let s = self.clone().t_check_red(*a.clone())?; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/main.rs:105:21 [INFO] [stderr] | [INFO] [stderr] 105 | let r = self.clone().extend(x, *a.clone()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/main.rs:106:21 [INFO] [stderr] | [INFO] [stderr] 106 | let t = r.clone().t_check_red(*b)?; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:227:23 [INFO] [stderr] | [INFO] [stderr] 227 | Lam(s, t, e) => if s == *v { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/main.rs:231:25 [INFO] [stderr] | [INFO] [stderr] 231 | let i = s.alpha_rename(&x.free_vars().union(&e.free_vars()).cloned().collect()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:237:22 [INFO] [stderr] | [INFO] [stderr] 237 | Pi(s, k, t) => if s == *v { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/main.rs:241:25 [INFO] [stderr] | [INFO] [stderr] 241 | let i = s.alpha_rename(&x.free_vars().union(&t.free_vars()).cloned().collect()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:229:20 [INFO] [stderr] | [INFO] [stderr] 229 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 230 | | if x.free_vars().contains(&s) { [INFO] [stderr] 231 | | let i = s.alpha_rename(&x.free_vars().union(&e.free_vars()).cloned().collect()); [INFO] [stderr] 232 | | lam(i.clone(), t.subst(v, x), e.subst(&i.clone(), &var(i))) [INFO] [stderr] ... | [INFO] [stderr] 235 | | } [INFO] [stderr] 236 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 229 | } else if x.free_vars().contains(&s) { [INFO] [stderr] 230 | let i = s.alpha_rename(&x.free_vars().union(&e.free_vars()).cloned().collect()); [INFO] [stderr] 231 | lam(i.clone(), t.subst(v, x), e.subst(&i.clone(), &var(i))) [INFO] [stderr] 232 | } else { [INFO] [stderr] 233 | lam(s.clone(), t.subst(v, x), e.subst(v, x)) [INFO] [stderr] 234 | }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:239:20 [INFO] [stderr] | [INFO] [stderr] 239 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 240 | | if x.free_vars().contains(&s) { [INFO] [stderr] 241 | | let i = s.alpha_rename(&x.free_vars().union(&t.free_vars()).cloned().collect()); [INFO] [stderr] 242 | | pi(i.clone(), k.subst(v, x), t.subst(&i.clone(), &var(i))) [INFO] [stderr] ... | [INFO] [stderr] 245 | | } [INFO] [stderr] 246 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 239 | } else if x.free_vars().contains(&s) { [INFO] [stderr] 240 | let i = s.alpha_rename(&x.free_vars().union(&t.free_vars()).cloned().collect()); [INFO] [stderr] 241 | pi(i.clone(), k.subst(v, x), t.subst(&i.clone(), &var(i))) [INFO] [stderr] 242 | } else { [INFO] [stderr] 243 | pi(s.clone(), k.subst(v, x), t.subst(v, x)) [INFO] [stderr] 244 | }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:229:20 [INFO] [stderr] | [INFO] [stderr] 229 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 230 | | if x.free_vars().contains(&s) { [INFO] [stderr] 231 | | let i = s.alpha_rename(&x.free_vars().union(&e.free_vars()).cloned().collect()); [INFO] [stderr] 232 | | lam(i.clone(), t.subst(v, x), e.subst(&i.clone(), &var(i))) [INFO] [stderr] ... | [INFO] [stderr] 235 | | } [INFO] [stderr] 236 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 229 | } else if x.free_vars().contains(&s) { [INFO] [stderr] 230 | let i = s.alpha_rename(&x.free_vars().union(&e.free_vars()).cloned().collect()); [INFO] [stderr] 231 | lam(i.clone(), t.subst(v, x), e.subst(&i.clone(), &var(i))) [INFO] [stderr] 232 | } else { [INFO] [stderr] 233 | lam(s.clone(), t.subst(v, x), e.subst(v, x)) [INFO] [stderr] 234 | }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:239:20 [INFO] [stderr] | [INFO] [stderr] 239 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 240 | | if x.free_vars().contains(&s) { [INFO] [stderr] 241 | | let i = s.alpha_rename(&x.free_vars().union(&t.free_vars()).cloned().collect()); [INFO] [stderr] 242 | | pi(i.clone(), k.subst(v, x), t.subst(&i.clone(), &var(i))) [INFO] [stderr] ... | [INFO] [stderr] 245 | | } [INFO] [stderr] 246 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 239 | } else if x.free_vars().contains(&s) { [INFO] [stderr] 240 | let i = s.alpha_rename(&x.free_vars().union(&t.free_vars()).cloned().collect()); [INFO] [stderr] 241 | pi(i.clone(), k.subst(v, x), t.subst(&i.clone(), &var(i))) [INFO] [stderr] 242 | } else { [INFO] [stderr] 243 | pi(s.clone(), k.subst(v, x), t.subst(v, x)) [INFO] [stderr] 244 | }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: crate `playing_with_ASTs` should have a snake case name such as `playing_with_asts` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/main.rs:44:50 [INFO] [stderr] | [INFO] [stderr] 44 | static ref allowedKinds: Vec<(Type, Type)> = [ [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 45 | | (Expr::Kind(Kinds::Star), Expr::Kind(Kinds::Star)), [INFO] [stderr] 46 | | (Expr::Kind(Kinds::Star), Expr::Kind(Kinds::Bawx)), [INFO] [stderr] 47 | | (Expr::Kind(Kinds::Bawx), Expr::Kind(Kinds::Star)), [INFO] [stderr] ... | [INFO] [stderr] 51 | | .cloned() [INFO] [stderr] 52 | | .collect(); [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:194:27 [INFO] [stderr] | [INFO] [stderr] 194 | Var(ref s) => [s].iter().map(|&s| s).collect(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `[s].iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:200:38 [INFO] [stderr] | [INFO] [stderr] 200 | .difference(&[i].iter().map(|&i| i).collect()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `[i].iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:209:38 [INFO] [stderr] | [INFO] [stderr] 209 | .difference(&[i].iter().map(|&i| i).collect()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `[i].iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: crate `playing_with_ASTs` should have a snake case name such as `playing_with_asts` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/main.rs:44:50 [INFO] [stderr] | [INFO] [stderr] 44 | static ref allowedKinds: Vec<(Type, Type)> = [ [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 45 | | (Expr::Kind(Kinds::Star), Expr::Kind(Kinds::Star)), [INFO] [stderr] 46 | | (Expr::Kind(Kinds::Star), Expr::Kind(Kinds::Bawx)), [INFO] [stderr] 47 | | (Expr::Kind(Kinds::Bawx), Expr::Kind(Kinds::Star)), [INFO] [stderr] ... | [INFO] [stderr] 51 | | .cloned() [INFO] [stderr] 52 | | .collect(); [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:194:27 [INFO] [stderr] | [INFO] [stderr] 194 | Var(ref s) => [s].iter().map(|&s| s).collect(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `[s].iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:200:38 [INFO] [stderr] | [INFO] [stderr] 200 | .difference(&[i].iter().map(|&i| i).collect()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `[i].iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:209:38 [INFO] [stderr] | [INFO] [stderr] 209 | .difference(&[i].iter().map(|&i| i).collect()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `[i].iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:458:13 [INFO] [stderr] | [INFO] [stderr] 458 | assert!(var(s).beta_eq(var(eq)) == true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `var(s).beta_eq(var(eq))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.73s [INFO] running `"docker" "inspect" "770b1520bd09e0e859254359d13733dff2530c35400ed16532a190edd237f890"` [INFO] running `"docker" "rm" "-f" "770b1520bd09e0e859254359d13733dff2530c35400ed16532a190edd237f890"` [INFO] [stdout] 770b1520bd09e0e859254359d13733dff2530c35400ed16532a190edd237f890