[INFO] updating cached repository janeq493/Trianglez [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/janeq493/Trianglez [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/janeq493/Trianglez" "work/ex/clippy-test-run/sources/stable/gh/janeq493/Trianglez"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/janeq493/Trianglez'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/janeq493/Trianglez" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/janeq493/Trianglez"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/janeq493/Trianglez'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3eb95bfd3e916eaff07b968a1de3e0b373236add [INFO] sha for GitHub repo janeq493/Trianglez: 3eb95bfd3e916eaff07b968a1de3e0b373236add [INFO] validating manifest of janeq493/Trianglez on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of janeq493/Trianglez on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing janeq493/Trianglez [INFO] finished frobbing janeq493/Trianglez [INFO] frobbed toml for janeq493/Trianglez written to work/ex/clippy-test-run/sources/stable/gh/janeq493/Trianglez/Cargo.toml [INFO] started frobbing janeq493/Trianglez [INFO] finished frobbing janeq493/Trianglez [INFO] frobbed toml for janeq493/Trianglez written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/janeq493/Trianglez/Cargo.toml [INFO] crate janeq493/Trianglez has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting janeq493/Trianglez against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/janeq493/Trianglez:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bbd20e4e22f56eac704de22f1751b3f9a70ee30fe6a74f38f249e02c1313afbd [INFO] running `"docker" "start" "-a" "bbd20e4e22f56eac704de22f1751b3f9a70ee30fe6a74f38f249e02c1313afbd"` [INFO] [stderr] Compiling cmake v0.1.31 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Compiling syn v0.14.2 [INFO] [stderr] Checking num-bigint v0.1.44 [INFO] [stderr] Checking enum_primitive v0.1.1 [INFO] [stderr] Checking cgmath v0.16.1 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Compiling glfw-sys v3.2.2 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking rayon v1.0.1 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Compiling num-derive v0.2.2 [INFO] [stderr] Checking glfw v0.23.0 [INFO] [stderr] Checking jpeg-decoder v0.1.14 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking trianglez v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | dir: dir, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | dir: dir, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `mesh::*` [INFO] [stderr] --> src/main.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | use mesh::*; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `gl` [INFO] [stderr] --> src/model.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use gl; [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `image` [INFO] [stderr] --> src/model.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use image; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `image::DynamicImage::*` [INFO] [stderr] --> src/model.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use image::DynamicImage::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `image::GenericImage` [INFO] [stderr] --> src/model.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use image::GenericImage; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `mesh::*` [INFO] [stderr] --> src/main.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | use mesh::*; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `gl` [INFO] [stderr] --> src/model.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use gl; [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `image` [INFO] [stderr] --> src/model.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use image; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `image::DynamicImage::*` [INFO] [stderr] --> src/model.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use image::DynamicImage::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `image::GenericImage` [INFO] [stderr] --> src/model.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use image::GenericImage; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | let mut tes = Model::new("models/treeman.obj"); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | let mut tes = Model::new("models/treeman.obj"); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/shader.rs:49:31 [INFO] [stderr] | [INFO] [stderr] 49 | let mut success = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/shader.rs:55:27 [INFO] [stderr] | [INFO] [stderr] 55 | if success != gl::TRUE as GLint [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/shader.rs:75:31 [INFO] [stderr] | [INFO] [stderr] 75 | let mut success = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/shader.rs:81:27 [INFO] [stderr] | [INFO] [stderr] 81 | if success != gl::TRUE as GLint [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/shader.rs:49:31 [INFO] [stderr] | [INFO] [stderr] 49 | let mut success = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/shader.rs:55:27 [INFO] [stderr] | [INFO] [stderr] 55 | if success != gl::TRUE as GLint [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/shader.rs:75:31 [INFO] [stderr] | [INFO] [stderr] 75 | let mut success = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] warning: method `loadModel` should have a snake case name such as `load_model` [INFO] [stderr] --> src/model.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / fn loadModel(&mut self,path:&str) [INFO] [stderr] 28 | | { [INFO] [stderr] 29 | | let (models,materials) = tobj::load_obj(Path::new(path)).unwrap(); [INFO] [stderr] 30 | | for model in &models [INFO] [stderr] ... | [INFO] [stderr] 63 | | } [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/shader.rs:81:27 [INFO] [stderr] | [INFO] [stderr] 81 | if success != gl::TRUE as GLint [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: method `loadModel` should have a snake case name such as `load_model` [INFO] [stderr] --> src/model.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / fn loadModel(&mut self,path:&str) [INFO] [stderr] 28 | | { [INFO] [stderr] 29 | | let (models,materials) = tobj::load_obj(Path::new(path)).unwrap(); [INFO] [stderr] 30 | | for model in &models [INFO] [stderr] ... | [INFO] [stderr] 63 | | } [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 32.61s [INFO] running `"docker" "inspect" "bbd20e4e22f56eac704de22f1751b3f9a70ee30fe6a74f38f249e02c1313afbd"` [INFO] running `"docker" "rm" "-f" "bbd20e4e22f56eac704de22f1751b3f9a70ee30fe6a74f38f249e02c1313afbd"` [INFO] [stdout] bbd20e4e22f56eac704de22f1751b3f9a70ee30fe6a74f38f249e02c1313afbd