[INFO] updating cached repository jamwaffles/tokio-stream-test [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jamwaffles/tokio-stream-test [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jamwaffles/tokio-stream-test" "work/ex/clippy-test-run/sources/stable/gh/jamwaffles/tokio-stream-test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jamwaffles/tokio-stream-test'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jamwaffles/tokio-stream-test" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jamwaffles/tokio-stream-test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jamwaffles/tokio-stream-test'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1410592542be03648a70a5eb9d3b4a3946368081 [INFO] sha for GitHub repo jamwaffles/tokio-stream-test: 1410592542be03648a70a5eb9d3b4a3946368081 [INFO] validating manifest of jamwaffles/tokio-stream-test on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jamwaffles/tokio-stream-test on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jamwaffles/tokio-stream-test [INFO] finished frobbing jamwaffles/tokio-stream-test [INFO] frobbed toml for jamwaffles/tokio-stream-test written to work/ex/clippy-test-run/sources/stable/gh/jamwaffles/tokio-stream-test/Cargo.toml [INFO] started frobbing jamwaffles/tokio-stream-test [INFO] finished frobbing jamwaffles/tokio-stream-test [INFO] frobbed toml for jamwaffles/tokio-stream-test written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jamwaffles/tokio-stream-test/Cargo.toml [INFO] crate jamwaffles/tokio-stream-test has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jamwaffles/tokio-stream-test against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jamwaffles/tokio-stream-test:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 750a91ae558df66be3ce1bff840bbc95684ad9e6c059358b582317de9f315043 [INFO] running `"docker" "start" "-a" "750a91ae558df66be3ce1bff840bbc95684ad9e6c059358b582317de9f315043"` [INFO] [stderr] Compiling ucd-util v0.1.2 [INFO] [stderr] Checking sasl v0.4.2 [INFO] [stderr] Compiling memchr v2.1.1 [INFO] [stderr] Checking nom v4.1.1 [INFO] [stderr] Checking handlebars v1.1.0 [INFO] [stderr] Checking pretty_env_logger v0.2.5 [INFO] [stderr] Compiling regex-syntax v0.6.2 [INFO] [stderr] Compiling aho-corasick v0.6.9 [INFO] [stderr] Checking amq-protocol-types v1.0.0 [INFO] [stderr] Checking amq-protocol-codegen v1.0.0 [INFO] [stderr] Compiling regex v1.0.5 [INFO] [stderr] Compiling amq-protocol v0.23.0 [INFO] [stderr] Compiling lapin-async v0.14.0 [INFO] [stderr] Checking lapin-futures v0.14.0 [INFO] [stderr] Checking tokio-stream v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/main.rs:178:25 [INFO] [stderr] | [INFO] [stderr] 178 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:198:9 [INFO] [stderr] | [INFO] [stderr] 198 | join_handle [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:192:27 [INFO] [stderr] | [INFO] [stderr] 192 | let join_handle = thread::spawn(move || { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 193 | | while let Ok(n) = rx.recv() { [INFO] [stderr] 194 | | println!("Received {:?}", n); [INFO] [stderr] 195 | | } [INFO] [stderr] 196 | | }); [INFO] [stderr] | |__________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/main.rs:178:25 [INFO] [stderr] | [INFO] [stderr] 178 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:198:9 [INFO] [stderr] | [INFO] [stderr] 198 | join_handle [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:192:27 [INFO] [stderr] | [INFO] [stderr] 192 | let join_handle = thread::spawn(move || { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 193 | | while let Ok(n) = rx.recv() { [INFO] [stderr] 194 | | println!("Received {:?}", n); [INFO] [stderr] 195 | | } [INFO] [stderr] 196 | | }); [INFO] [stderr] | |__________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 04s [INFO] running `"docker" "inspect" "750a91ae558df66be3ce1bff840bbc95684ad9e6c059358b582317de9f315043"` [INFO] running `"docker" "rm" "-f" "750a91ae558df66be3ce1bff840bbc95684ad9e6c059358b582317de9f315043"` [INFO] [stdout] 750a91ae558df66be3ce1bff840bbc95684ad9e6c059358b582317de9f315043