[INFO] updating cached repository jamwaffles/organisations-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jamwaffles/organisations-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jamwaffles/organisations-rs" "work/ex/clippy-test-run/sources/stable/gh/jamwaffles/organisations-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jamwaffles/organisations-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jamwaffles/organisations-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jamwaffles/organisations-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jamwaffles/organisations-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 86c6bc5309567090927242072c384524831545d8 [INFO] sha for GitHub repo jamwaffles/organisations-rs: 86c6bc5309567090927242072c384524831545d8 [INFO] validating manifest of jamwaffles/organisations-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jamwaffles/organisations-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jamwaffles/organisations-rs [INFO] finished frobbing jamwaffles/organisations-rs [INFO] frobbed toml for jamwaffles/organisations-rs written to work/ex/clippy-test-run/sources/stable/gh/jamwaffles/organisations-rs/Cargo.toml [INFO] started frobbing jamwaffles/organisations-rs [INFO] finished frobbing jamwaffles/organisations-rs [INFO] frobbed toml for jamwaffles/organisations-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jamwaffles/organisations-rs/Cargo.toml [INFO] crate jamwaffles/organisations-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jamwaffles/organisations-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jamwaffles/organisations-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5c957512a786c555b1161000b0d8be7216008ea5779d9e1c612b22aa972146cf [INFO] running `"docker" "start" "-a" "5c957512a786c555b1161000b0d8be7216008ea5779d9e1c612b22aa972146cf"` [INFO] [stderr] Compiling actix-web v0.7.2 [INFO] [stderr] Checking r2d2 v0.8.2 [INFO] [stderr] Checking mio-uds v0.6.6 [INFO] [stderr] Compiling syn v0.14.5 [INFO] [stderr] Checking uuid v0.6.5 [INFO] [stderr] Compiling phf_shared v0.7.21 [INFO] [stderr] Checking cookie v0.11.0 [INFO] [stderr] Compiling phf_generator v0.7.21 [INFO] [stderr] Checking postgres-protocol v0.3.2 [INFO] [stderr] Checking trust-dns-proto v0.4.0 [INFO] [stderr] Compiling ring v0.12.1 [INFO] [stderr] Checking phf v0.7.21 [INFO] [stderr] Checking tokio-signal v0.2.1 [INFO] [stderr] Compiling phf_codegen v0.7.21 [INFO] [stderr] Checking postgres-shared v0.4.1 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.6 [INFO] [stderr] Checking trust-dns-resolver v0.9.0 [INFO] [stderr] Checking postgres v0.15.2 [INFO] [stderr] Checking r2d2_postgres v0.14.0 [INFO] [stderr] Compiling actix_derive v0.3.0 [INFO] [stderr] Compiling serde_derive v1.0.70 [INFO] [stderr] Checking actix v0.7.2 [INFO] [stderr] Checking jsonwebtoken v4.0.1 [INFO] [stderr] Checking organisations v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: function is never used: `hydrate` [INFO] [stderr] --> src/aggregators/get_invite.rs:31:1 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn hydrate(events: &Vec) -> Membership { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `GetOrganisationMembersSuccess` [INFO] [stderr] --> src/responses.rs:33:1 [INFO] [stderr] | [INFO] [stderr] 33 | pub struct GetOrganisationMembersSuccess { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/responses.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn new(users: Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/aggregators/get_invite.rs:31:24 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn hydrate(events: &Vec) -> Membership { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Event]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: function is never used: `hydrate` [INFO] [stderr] --> src/aggregators/get_invite.rs:31:1 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn hydrate(events: &Vec) -> Membership { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `GetOrganisationMembersSuccess` [INFO] [stderr] --> src/responses.rs:33:1 [INFO] [stderr] | [INFO] [stderr] 33 | pub struct GetOrganisationMembersSuccess { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/responses.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn new(users: Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/aggregators/members_by_organisation_id.rs:93:24 [INFO] [stderr] | [INFO] [stderr] 93 | future::ok(members.values().map(|v| v.clone()).collect()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `members.values().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/aggregators/get_invite.rs:31:24 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn hydrate(events: &Vec) -> Membership { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Event]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/enforcement/organisation_member.rs:15:10 [INFO] [stderr] | [INFO] [stderr] 15 | .unwrap_or(FutErr(ErrorUnauthorized("Nope"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| FutErr(ErrorUnauthorized("Nope")))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/aggregators/members_by_organisation_id.rs:93:24 [INFO] [stderr] | [INFO] [stderr] 93 | future::ok(members.values().map(|v| v.clone()).collect()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `members.values().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/enforcement/organisation_member.rs:15:10 [INFO] [stderr] | [INFO] [stderr] 15 | .unwrap_or(FutErr(ErrorUnauthorized("Nope"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| FutErr(ErrorUnauthorized("Nope")))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/operations/update_membership.rs:35:36 [INFO] [stderr] | [INFO] [stderr] 35 | .send::(q.into()) [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `q` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/operations/update_membership.rs:35:36 [INFO] [stderr] | [INFO] [stderr] 35 | .send::(q.into()) [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `q` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 59.57s [INFO] running `"docker" "inspect" "5c957512a786c555b1161000b0d8be7216008ea5779d9e1c612b22aa972146cf"` [INFO] running `"docker" "rm" "-f" "5c957512a786c555b1161000b0d8be7216008ea5779d9e1c612b22aa972146cf"` [INFO] [stdout] 5c957512a786c555b1161000b0d8be7216008ea5779d9e1c612b22aa972146cf