[INFO] updating cached repository jamwaffles/obj-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jamwaffles/obj-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jamwaffles/obj-rs" "work/ex/clippy-test-run/sources/stable/gh/jamwaffles/obj-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jamwaffles/obj-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jamwaffles/obj-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jamwaffles/obj-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jamwaffles/obj-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bc2c68135541334ad9cc03e99b4d8eabcf03c482 [INFO] sha for GitHub repo jamwaffles/obj-rs: bc2c68135541334ad9cc03e99b4d8eabcf03c482 [INFO] validating manifest of jamwaffles/obj-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jamwaffles/obj-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jamwaffles/obj-rs [INFO] finished frobbing jamwaffles/obj-rs [INFO] frobbed toml for jamwaffles/obj-rs written to work/ex/clippy-test-run/sources/stable/gh/jamwaffles/obj-rs/Cargo.toml [INFO] started frobbing jamwaffles/obj-rs [INFO] finished frobbing jamwaffles/obj-rs [INFO] frobbed toml for jamwaffles/obj-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jamwaffles/obj-rs/Cargo.toml [INFO] crate jamwaffles/obj-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jamwaffles/obj-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jamwaffles/obj-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6e7dc786afd1102d0c7c442970f7286cce817916fcdf9f2f6817afae89e09a57 [INFO] running `"docker" "start" "-a" "6e7dc786afd1102d0c7c442970f7286cce817916fcdf9f2f6817afae89e09a57"` [INFO] [stderr] Checking nom v2.1.0 [INFO] [stderr] Checking pistoncore-input v0.17.1 [INFO] [stderr] Checking gfx_core v0.6.0 [INFO] [stderr] Checking arrayvec v0.3.20 [INFO] [stderr] Checking rusttype v0.2.1 [INFO] [stderr] Checking pistoncore-window v0.26.2 [INFO] [stderr] Checking pistoncore-event_loop v0.31.4 [INFO] [stderr] Checking pistoncore-glutin_window v0.35.1 [INFO] [stderr] Checking piston v0.31.4 [INFO] [stderr] Checking gfx v0.14.1 [INFO] [stderr] Checking gfx_device_gl v0.13.0 [INFO] [stderr] Checking piston-gfx_texture v0.22.1 [INFO] [stderr] Checking piston2d-gfx_graphics v0.38.0 [INFO] [stderr] Checking piston_window v0.64.0 [INFO] [stderr] Checking obj-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wavefront/obj.rs:282:5 [INFO] [stderr] | [INFO] [stderr] 282 | vertices: vertices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vertices` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wavefront/obj.rs:283:5 [INFO] [stderr] | [INFO] [stderr] 283 | normals: normals, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `normals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wavefront/obj.rs:284:5 [INFO] [stderr] | [INFO] [stderr] 284 | texcoords: texcoords, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `texcoords` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wavefront/obj.rs:282:5 [INFO] [stderr] | [INFO] [stderr] 282 | vertices: vertices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vertices` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wavefront/obj.rs:283:5 [INFO] [stderr] | [INFO] [stderr] 283 | normals: normals, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `normals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wavefront/obj.rs:284:5 [INFO] [stderr] | [INFO] [stderr] 284 | texcoords: texcoords, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `texcoords` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wavefront/obj.rs:285:5 [INFO] [stderr] | [INFO] [stderr] 285 | objects: objects, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `objects` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wavefront/obj.rs:338:3 [INFO] [stderr] | [INFO] [stderr] 338 | materials: materials, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `materials` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/glium_window.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | context: context, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `context` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wavefront/obj.rs:285:5 [INFO] [stderr] | [INFO] [stderr] 285 | objects: objects, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `objects` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wavefront/obj.rs:338:3 [INFO] [stderr] | [INFO] [stderr] 338 | materials: materials, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `materials` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/glium_window.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | context: context, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `context` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/wavefront/obj.rs:53:56 [INFO] [stderr] | [INFO] [stderr] 53 | let v1 = self.vertices.get(f.vertices[0] as usize).expect(&format!("Could not get v1 {}", f.vertices[0])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Could not get v1 {}", f.vertices[0]))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/wavefront/obj.rs:54:56 [INFO] [stderr] | [INFO] [stderr] 54 | let v2 = self.vertices.get(f.vertices[1] as usize).expect(&format!("Could not get v2 {}", f.vertices[1])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Could not get v2 {}", f.vertices[1]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/wavefront/obj.rs:55:56 [INFO] [stderr] | [INFO] [stderr] 55 | let v3 = self.vertices.get(f.vertices[2] as usize).expect(&format!("Could not get v3 {}", f.vertices[2])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Could not get v3 {}", f.vertices[2]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/wavefront/obj.rs:57:55 [INFO] [stderr] | [INFO] [stderr] 57 | let vn1 = self.normals.get(f.normals[0] as usize).expect(&format!("Could not get vn1 {}", f.normals[0])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Could not get vn1 {}", f.normals[0]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/wavefront/obj.rs:58:55 [INFO] [stderr] | [INFO] [stderr] 58 | let vn2 = self.normals.get(f.normals[1] as usize).expect(&format!("Could not get vn2 {}", f.normals[1])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Could not get vn2 {}", f.normals[1]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/wavefront/obj.rs:59:55 [INFO] [stderr] | [INFO] [stderr] 59 | let vn3 = self.normals.get(f.normals[2] as usize).expect(&format!("Could not get vn3 {}", f.normals[2])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Could not get vn3 {}", f.normals[2]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/wavefront/obj.rs:73:19 [INFO] [stderr] | [INFO] [stderr] 73 | let material = match &self.materials { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 74 | | &Some(ref materials) => { [INFO] [stderr] 75 | | match &materials.get(&mat) { [INFO] [stderr] 76 | | &Some(ref mat) => (*mat).clone(), [INFO] [stderr] ... | [INFO] [stderr] 92 | | } [INFO] [stderr] 93 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 73 | let material = match self.materials { [INFO] [stderr] 74 | Some(ref materials) => { [INFO] [stderr] 75 | match &materials.get(&mat) { [INFO] [stderr] 76 | &Some(ref mat) => (*mat).clone(), [INFO] [stderr] 77 | &None => mtl::WavefrontMaterial { [INFO] [stderr] 78 | name: String::from("Default material"), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/wavefront/obj.rs:75:6 [INFO] [stderr] | [INFO] [stderr] 75 | match &materials.get(&mat) { [INFO] [stderr] | _____________________^ [INFO] [stderr] 76 | | &Some(ref mat) => (*mat).clone(), [INFO] [stderr] 77 | | &None => mtl::WavefrontMaterial { [INFO] [stderr] 78 | | name: String::from("Default material"), [INFO] [stderr] ... | [INFO] [stderr] 83 | | } [INFO] [stderr] 84 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 75 | match materials.get(&mat) { [INFO] [stderr] 76 | Some(ref mat) => (*mat).clone(), [INFO] [stderr] 77 | None => mtl::WavefrontMaterial { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/wavefront/obj.rs:53:56 [INFO] [stderr] | [INFO] [stderr] 53 | let v1 = self.vertices.get(f.vertices[0] as usize).expect(&format!("Could not get v1 {}", f.vertices[0])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Could not get v1 {}", f.vertices[0]))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/wavefront/obj.rs:54:56 [INFO] [stderr] | [INFO] [stderr] 54 | let v2 = self.vertices.get(f.vertices[1] as usize).expect(&format!("Could not get v2 {}", f.vertices[1])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Could not get v2 {}", f.vertices[1]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/wavefront/obj.rs:55:56 [INFO] [stderr] | [INFO] [stderr] 55 | let v3 = self.vertices.get(f.vertices[2] as usize).expect(&format!("Could not get v3 {}", f.vertices[2])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Could not get v3 {}", f.vertices[2]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/wavefront/obj.rs:57:55 [INFO] [stderr] | [INFO] [stderr] 57 | let vn1 = self.normals.get(f.normals[0] as usize).expect(&format!("Could not get vn1 {}", f.normals[0])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Could not get vn1 {}", f.normals[0]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/wavefront/obj.rs:58:55 [INFO] [stderr] | [INFO] [stderr] 58 | let vn2 = self.normals.get(f.normals[1] as usize).expect(&format!("Could not get vn2 {}", f.normals[1])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Could not get vn2 {}", f.normals[1]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/wavefront/obj.rs:59:55 [INFO] [stderr] | [INFO] [stderr] 59 | let vn3 = self.normals.get(f.normals[2] as usize).expect(&format!("Could not get vn3 {}", f.normals[2])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Could not get vn3 {}", f.normals[2]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/wavefront/obj.rs:73:19 [INFO] [stderr] | [INFO] [stderr] 73 | let material = match &self.materials { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 74 | | &Some(ref materials) => { [INFO] [stderr] 75 | | match &materials.get(&mat) { [INFO] [stderr] 76 | | &Some(ref mat) => (*mat).clone(), [INFO] [stderr] ... | [INFO] [stderr] 92 | | } [INFO] [stderr] 93 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 73 | let material = match self.materials { [INFO] [stderr] 74 | Some(ref materials) => { [INFO] [stderr] 75 | match &materials.get(&mat) { [INFO] [stderr] 76 | &Some(ref mat) => (*mat).clone(), [INFO] [stderr] 77 | &None => mtl::WavefrontMaterial { [INFO] [stderr] 78 | name: String::from("Default material"), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/wavefront/obj.rs:75:6 [INFO] [stderr] | [INFO] [stderr] 75 | match &materials.get(&mat) { [INFO] [stderr] | _____________________^ [INFO] [stderr] 76 | | &Some(ref mat) => (*mat).clone(), [INFO] [stderr] 77 | | &None => mtl::WavefrontMaterial { [INFO] [stderr] 78 | | name: String::from("Default material"), [INFO] [stderr] ... | [INFO] [stderr] 83 | | } [INFO] [stderr] 84 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 75 | match materials.get(&mat) { [INFO] [stderr] 76 | Some(ref mat) => (*mat).clone(), [INFO] [stderr] 77 | None => mtl::WavefrontMaterial { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/wavefront/obj.rs:204:10 [INFO] [stderr] | [INFO] [stderr] 204 | (match str::from_utf8(state).unwrap_or("").as_ref() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `str::from_utf8(state).unwrap_or("")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/wavefront/obj.rs:242:43 [INFO] [stderr] | [INFO] [stderr] 242 | object_start => { |o| FileEntity::Object(String::from(o)) } | [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `o` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/wavefront/obj.rs:308:5 [INFO] [stderr] | [INFO] [stderr] 308 | / match file.read_to_string(&mut s) { [INFO] [stderr] 309 | | Err(why) => panic!("couldn't read {}: {}", display, why.description()), [INFO] [stderr] 310 | | Ok(_) => () [INFO] [stderr] 311 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = file.read_to_string(&mut s) { panic!("couldn't read {}: {}", display, why.description()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/wavefront/obj.rs:327:4 [INFO] [stderr] | [INFO] [stderr] 327 | match mtl_file.read_to_string(&mut mtl_s) { [INFO] [stderr] | _____________^ [INFO] [stderr] 328 | | Err(why) => panic!("couldn't read {}: {}", mtl_display, why.description()), [INFO] [stderr] 329 | | Ok(_) => () [INFO] [stderr] 330 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Err(why) = mtl_file.read_to_string(&mut mtl_s) { panic!("couldn't read {}: {}", mtl_display, why.description()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/wavefront/obj.rs:204:10 [INFO] [stderr] | [INFO] [stderr] 204 | (match str::from_utf8(state).unwrap_or("").as_ref() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `str::from_utf8(state).unwrap_or("")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/wavefront/obj.rs:242:43 [INFO] [stderr] | [INFO] [stderr] 242 | object_start => { |o| FileEntity::Object(String::from(o)) } | [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `o` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/wavefront/obj.rs:308:5 [INFO] [stderr] | [INFO] [stderr] 308 | / match file.read_to_string(&mut s) { [INFO] [stderr] 309 | | Err(why) => panic!("couldn't read {}: {}", display, why.description()), [INFO] [stderr] 310 | | Ok(_) => () [INFO] [stderr] 311 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = file.read_to_string(&mut s) { panic!("couldn't read {}: {}", display, why.description()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/wavefront/obj.rs:327:4 [INFO] [stderr] | [INFO] [stderr] 327 | match mtl_file.read_to_string(&mut mtl_s) { [INFO] [stderr] | _____________^ [INFO] [stderr] 328 | | Err(why) => panic!("couldn't read {}: {}", mtl_display, why.description()), [INFO] [stderr] 329 | | Ok(_) => () [INFO] [stderr] 330 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Err(why) = mtl_file.read_to_string(&mut mtl_s) { panic!("couldn't read {}: {}", mtl_display, why.description()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/main.rs:84:56 [INFO] [stderr] | [INFO] [stderr] 84 | let perspective = Perspective3::new(16.0f32 / 9.0, 3.14 / 2.0, 0.1, 1000.0); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:87:19 [INFO] [stderr] | [INFO] [stderr] 87 | let program = program!(&display, [INFO] [stderr] | ___________________^ [INFO] [stderr] 88 | | 140 => { [INFO] [stderr] 89 | | vertex: " [INFO] [stderr] 90 | | #version 330 [INFO] [stderr] ... | [INFO] [stderr] 139 | | }, [INFO] [stderr] 140 | | ).unwrap(); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/main.rs:84:56 [INFO] [stderr] | [INFO] [stderr] 84 | let perspective = Perspective3::new(16.0f32 / 9.0, 3.14 / 2.0, 0.1, 1000.0); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:87:19 [INFO] [stderr] | [INFO] [stderr] 87 | let program = program!(&display, [INFO] [stderr] | ___________________^ [INFO] [stderr] 88 | | 140 => { [INFO] [stderr] 89 | | vertex: " [INFO] [stderr] 90 | | #version 330 [INFO] [stderr] ... | [INFO] [stderr] 139 | | }, [INFO] [stderr] 140 | | ).unwrap(); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: Could not compile `obj-rs`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `obj-rs`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "6e7dc786afd1102d0c7c442970f7286cce817916fcdf9f2f6817afae89e09a57"` [INFO] running `"docker" "rm" "-f" "6e7dc786afd1102d0c7c442970f7286cce817916fcdf9f2f6817afae89e09a57"` [INFO] [stdout] 6e7dc786afd1102d0c7c442970f7286cce817916fcdf9f2f6817afae89e09a57