[INFO] updating cached repository jamwaffles/FusionToolTranslator [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jamwaffles/FusionToolTranslator [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jamwaffles/FusionToolTranslator" "work/ex/clippy-test-run/sources/stable/gh/jamwaffles/FusionToolTranslator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jamwaffles/FusionToolTranslator'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jamwaffles/FusionToolTranslator" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jamwaffles/FusionToolTranslator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jamwaffles/FusionToolTranslator'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4cd8165dd078251b35e3dd8670488011314de25c [INFO] sha for GitHub repo jamwaffles/FusionToolTranslator: 4cd8165dd078251b35e3dd8670488011314de25c [INFO] validating manifest of jamwaffles/FusionToolTranslator on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jamwaffles/FusionToolTranslator on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jamwaffles/FusionToolTranslator [INFO] finished frobbing jamwaffles/FusionToolTranslator [INFO] frobbed toml for jamwaffles/FusionToolTranslator written to work/ex/clippy-test-run/sources/stable/gh/jamwaffles/FusionToolTranslator/Cargo.toml [INFO] started frobbing jamwaffles/FusionToolTranslator [INFO] finished frobbing jamwaffles/FusionToolTranslator [INFO] frobbed toml for jamwaffles/FusionToolTranslator written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jamwaffles/FusionToolTranslator/Cargo.toml [INFO] crate jamwaffles/FusionToolTranslator has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jamwaffles/FusionToolTranslator against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jamwaffles/FusionToolTranslator:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5488cdd6f59c509064883d2687fae9d1118d4f8d3a2e362ae507039b862f119b [INFO] running `"docker" "start" "-a" "5488cdd6f59c509064883d2687fae9d1118d4f8d3a2e362ae507039b862f119b"` [INFO] [stderr] Compiling bzip2-sys v0.1.6 [INFO] [stderr] Checking msdos_time v0.1.5 [INFO] [stderr] Checking bzip2 v0.3.2 [INFO] [stderr] Checking zip v0.1.19 [INFO] [stderr] Checking fusion360_tool_translator v2.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:73:7 [INFO] [stderr] | [INFO] [stderr] 73 | number: number, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `number` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:108:2 [INFO] [stderr] | [INFO] [stderr] 108 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:73:7 [INFO] [stderr] | [INFO] [stderr] 73 | number: number, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `number` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:108:2 [INFO] [stderr] | [INFO] [stderr] 108 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:41:20 [INFO] [stderr] | [INFO] [stderr] 41 | if family == "holder".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"holder"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:155:2 [INFO] [stderr] | [INFO] [stderr] 155 | match output_file.set_len(0) { [INFO] [stderr] | _____^ [INFO] [stderr] 156 | | Err(e) => panic!("Could not reset tool table file: {}", Error::description(&e)), [INFO] [stderr] 157 | | _ => () [INFO] [stderr] 158 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Err(e) = output_file.set_len(0) { panic!("Could not reset tool table file: {}", Error::description(&e)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:163:3 [INFO] [stderr] | [INFO] [stderr] 163 | match output_file.write(String::from(line).as_bytes()) { [INFO] [stderr] | _________^ [INFO] [stderr] 164 | | Err(e) => panic!("Could not write tool table record: {}", Error::description(&e)), [INFO] [stderr] 165 | | _ => () [INFO] [stderr] 166 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = output_file.write(String::from(line).as_bytes()) { panic!("Could not write tool table record: {}", Error::description(&e)) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:163:27 [INFO] [stderr] | [INFO] [stderr] 163 | match output_file.write(String::from(line).as_bytes()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `line` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:41:20 [INFO] [stderr] | [INFO] [stderr] 41 | if family == "holder".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"holder"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:155:2 [INFO] [stderr] | [INFO] [stderr] 155 | match output_file.set_len(0) { [INFO] [stderr] | _____^ [INFO] [stderr] 156 | | Err(e) => panic!("Could not reset tool table file: {}", Error::description(&e)), [INFO] [stderr] 157 | | _ => () [INFO] [stderr] 158 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Err(e) = output_file.set_len(0) { panic!("Could not reset tool table file: {}", Error::description(&e)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:163:3 [INFO] [stderr] | [INFO] [stderr] 163 | match output_file.write(String::from(line).as_bytes()) { [INFO] [stderr] | _________^ [INFO] [stderr] 164 | | Err(e) => panic!("Could not write tool table record: {}", Error::description(&e)), [INFO] [stderr] 165 | | _ => () [INFO] [stderr] 166 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = output_file.write(String::from(line).as_bytes()) { panic!("Could not write tool table record: {}", Error::description(&e)) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:163:27 [INFO] [stderr] | [INFO] [stderr] 163 | match output_file.write(String::from(line).as_bytes()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `line` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.20s [INFO] running `"docker" "inspect" "5488cdd6f59c509064883d2687fae9d1118d4f8d3a2e362ae507039b862f119b"` [INFO] running `"docker" "rm" "-f" "5488cdd6f59c509064883d2687fae9d1118d4f8d3a2e362ae507039b862f119b"` [INFO] [stdout] 5488cdd6f59c509064883d2687fae9d1118d4f8d3a2e362ae507039b862f119b