[INFO] updating cached repository jamiely/connect-four-rust
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/jamiely/connect-four-rust
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/jamiely/connect-four-rust" "work/ex/clippy-test-run/sources/stable/gh/jamiely/connect-four-rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jamiely/connect-four-rust'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/jamiely/connect-four-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jamiely/connect-four-rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jamiely/connect-four-rust'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] bd8b38765af4affc067a7b4235079cbb068fcd9b
[INFO] sha for GitHub repo jamiely/connect-four-rust: bd8b38765af4affc067a7b4235079cbb068fcd9b
[INFO] validating manifest of jamiely/connect-four-rust on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of jamiely/connect-four-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing jamiely/connect-four-rust
[INFO] finished frobbing jamiely/connect-four-rust
[INFO] frobbed toml for jamiely/connect-four-rust written to work/ex/clippy-test-run/sources/stable/gh/jamiely/connect-four-rust/Cargo.toml
[INFO] started frobbing jamiely/connect-four-rust
[INFO] finished frobbing jamiely/connect-four-rust
[INFO] frobbed toml for jamiely/connect-four-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jamiely/connect-four-rust/Cargo.toml
[INFO] crate jamiely/connect-four-rust has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting jamiely/connect-four-rust against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jamiely/connect-four-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 0fabe7bff895eba90ca04c039fc1175f1fd2ca37c576348ff05ece8442649969
[INFO] running `"docker" "start" "-a" "0fabe7bff895eba90ca04c039fc1175f1fd2ca37c576348ff05ece8442649969"`
[INFO] [stderr]     Checking connect_four v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/board.rs:65:13
[INFO] [stderr]    |
[INFO] [stderr] 65 |             rows: rows,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `rows`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/board.rs:66:13
[INFO] [stderr]    |
[INFO] [stderr] 66 |             columns: columns,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `columns`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/board.rs:67:13
[INFO] [stderr]    |
[INFO] [stderr] 67 |             markers: markers
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `markers`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/board.rs:65:13
[INFO] [stderr]    |
[INFO] [stderr] 65 |             rows: rows,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `rows`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/board.rs:66:13
[INFO] [stderr]    |
[INFO] [stderr] 66 |             columns: columns,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `columns`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/board.rs:67:13
[INFO] [stderr]    |
[INFO] [stderr] 67 |             markers: markers
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `markers`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/board.rs:75:65
[INFO] [stderr]    |
[INFO] [stderr] 75 |     pub fn set_marker(&mut self, index: &Index, marker: Marker) -> () {
[INFO] [stderr]    |                                                                 ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/board.rs:75:65
[INFO] [stderr]    |
[INFO] [stderr] 75 |     pub fn set_marker(&mut self, index: &Index, marker: Marker) -> () {
[INFO] [stderr]    |                                                                 ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `board::*`
[INFO] [stderr]   --> src/game.rs:94:9
[INFO] [stderr]    |
[INFO] [stderr] 94 |     use board::*;
[INFO] [stderr]    |         ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/game.rs:102:61
[INFO] [stderr]     |
[INFO] [stderr] 102 |     fn assert_index(opt_index: Option<Index>, index: Index) -> () {
[INFO] [stderr]     |                                                             ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/game.rs:110:46
[INFO] [stderr]     |
[INFO] [stderr] 110 |     fn assert_none(opt_index: Option<Index>) -> () {
[INFO] [stderr]     |                                              ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `board::Board`
[INFO] [stderr]   --> src/board.rs:55:5
[INFO] [stderr]    |
[INFO] [stderr] 55 | /     pub fn new() -> Board {
[INFO] [stderr] 56 | |         let rows = 6;
[INFO] [stderr] 57 | |         let columns = 7;
[INFO] [stderr] 58 | |
[INFO] [stderr] ...  |
[INFO] [stderr] 68 | |         }
[INFO] [stderr] 69 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 25 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/board.rs:80:9
[INFO] [stderr]    |
[INFO] [stderr] 80 |         self.markers.get(&index).map(|r| r.clone())
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.markers.get(&index).cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/board.rs:80:42
[INFO] [stderr]    |
[INFO] [stderr] 80 |         self.markers.get(&index).map(|r| r.clone())
[INFO] [stderr]    |                                          ^^^^^^^^^ help: try dereferencing it: `*r`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `game::Game`
[INFO] [stderr]   --> src/game.rs:9:5
[INFO] [stderr]    |
[INFO] [stderr] 9  | /     pub fn new() -> Game {
[INFO] [stderr] 10 | |         Game {
[INFO] [stderr] 11 | |             board: Board::new(),
[INFO] [stderr] 12 | |             current_marker: Marker::X
[INFO] [stderr] 13 | |         }
[INFO] [stderr] 14 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 8  | impl Default for game::Game {
[INFO] [stderr] 9  |     fn default() -> Self {
[INFO] [stderr] 10 |         Self::new()
[INFO] [stderr] 11 |     }
[INFO] [stderr] 12 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/game.rs:47:70
[INFO] [stderr]    |
[INFO] [stderr] 47 |     fn is_win_in_dir(&self, marker: Marker, index: Index, direction: &(i8, i8), count: i8) -> bool {
[INFO] [stderr]    |                                                                      ^^^^^^^^^ help: consider passing by value instead: `(i8, i8)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/game.rs:60:53
[INFO] [stderr]    |
[INFO] [stderr] 60 |     fn index_in_dir(&self, index: Index, direction: &(i8, i8)) -> Option<Index> {
[INFO] [stderr]    |                                                     ^^^^^^^^^ help: consider passing by value instead: `(i8, i8)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `assert_not_win`
[INFO] [stderr]    --> src/game.rs:153:9
[INFO] [stderr]     |
[INFO] [stderr] 153 |         fn assert_not_win(g: &Game, move_result: Option<Index>) {
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `board::Board`
[INFO] [stderr]   --> src/board.rs:55:5
[INFO] [stderr]    |
[INFO] [stderr] 55 | /     pub fn new() -> Board {
[INFO] [stderr] 56 | |         let rows = 6;
[INFO] [stderr] 57 | |         let columns = 7;
[INFO] [stderr] 58 | |
[INFO] [stderr] ...  |
[INFO] [stderr] 68 | |         }
[INFO] [stderr] 69 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 25 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/board.rs:80:9
[INFO] [stderr]    |
[INFO] [stderr] 80 |         self.markers.get(&index).map(|r| r.clone())
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.markers.get(&index).cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/board.rs:80:42
[INFO] [stderr]    |
[INFO] [stderr] 80 |         self.markers.get(&index).map(|r| r.clone())
[INFO] [stderr]    |                                          ^^^^^^^^^ help: try dereferencing it: `*r`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `game::Game`
[INFO] [stderr]   --> src/game.rs:9:5
[INFO] [stderr]    |
[INFO] [stderr] 9  | /     pub fn new() -> Game {
[INFO] [stderr] 10 | |         Game {
[INFO] [stderr] 11 | |             board: Board::new(),
[INFO] [stderr] 12 | |             current_marker: Marker::X
[INFO] [stderr] 13 | |         }
[INFO] [stderr] 14 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 8  | impl Default for game::Game {
[INFO] [stderr] 9  |     fn default() -> Self {
[INFO] [stderr] 10 |         Self::new()
[INFO] [stderr] 11 |     }
[INFO] [stderr] 12 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/game.rs:47:70
[INFO] [stderr]    |
[INFO] [stderr] 47 |     fn is_win_in_dir(&self, marker: Marker, index: Index, direction: &(i8, i8), count: i8) -> bool {
[INFO] [stderr]    |                                                                      ^^^^^^^^^ help: consider passing by value instead: `(i8, i8)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/game.rs:60:53
[INFO] [stderr]    |
[INFO] [stderr] 60 |     fn index_in_dir(&self, index: Index, direction: &(i8, i8)) -> Option<Index> {
[INFO] [stderr]    |                                                     ^^^^^^^^^ help: consider passing by value instead: `(i8, i8)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
[INFO] [stderr]   --> src/main.rs:15:9
[INFO] [stderr]    |
[INFO] [stderr] 15 | /         io::stdin().read_line(&mut buffer)
[INFO] [stderr] 16 | |             .ok().expect("Failed to read line");
[INFO] [stderr]    | |_______________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ok_expect)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect
[INFO] [stderr] 
[INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
[INFO] [stderr]   --> src/main.rs:15:9
[INFO] [stderr]    |
[INFO] [stderr] 15 | /         io::stdin().read_line(&mut buffer)
[INFO] [stderr] 16 | |             .ok().expect("Failed to read line");
[INFO] [stderr]    | |_______________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ok_expect)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.34s
[INFO] running `"docker" "inspect" "0fabe7bff895eba90ca04c039fc1175f1fd2ca37c576348ff05ece8442649969"`
[INFO] running `"docker" "rm" "-f" "0fabe7bff895eba90ca04c039fc1175f1fd2ca37c576348ff05ece8442649969"`
[INFO] [stdout] 0fabe7bff895eba90ca04c039fc1175f1fd2ca37c576348ff05ece8442649969