[INFO] updating cached repository jameysharp/share-svd [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jameysharp/share-svd [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jameysharp/share-svd" "work/ex/clippy-test-run/sources/stable/gh/jameysharp/share-svd"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jameysharp/share-svd'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jameysharp/share-svd" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jameysharp/share-svd"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jameysharp/share-svd'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8f6621333bbabd17bc258249c41b6532d0f67b00 [INFO] sha for GitHub repo jameysharp/share-svd: 8f6621333bbabd17bc258249c41b6532d0f67b00 [INFO] validating manifest of jameysharp/share-svd on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jameysharp/share-svd on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jameysharp/share-svd [INFO] finished frobbing jameysharp/share-svd [INFO] frobbed toml for jameysharp/share-svd written to work/ex/clippy-test-run/sources/stable/gh/jameysharp/share-svd/Cargo.toml [INFO] started frobbing jameysharp/share-svd [INFO] finished frobbing jameysharp/share-svd [INFO] frobbed toml for jameysharp/share-svd written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jameysharp/share-svd/Cargo.toml [INFO] crate jameysharp/share-svd has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jameysharp/share-svd against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jameysharp/share-svd:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f4631821e2beab8b1d4103b9bdc2202aeaa28453cb51d79f8a5265c7660d40d6 [INFO] running `"docker" "start" "-a" "f4631821e2beab8b1d4103b9bdc2202aeaa28453cb51d79f8a5265c7660d40d6"` [INFO] [stderr] Checking xmltree v0.3.2 [INFO] [stderr] Checking svd-parser v0.5.2 [INFO] [stderr] Checking share-svd v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `BTreeMap` [INFO] [stderr] --> src/main.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | / if !sets.contains_key(&p) { [INFO] [stderr] 40 | | sets.insert(p, vec![v]); [INFO] [stderr] 41 | | continue; [INFO] [stderr] 42 | | } [INFO] [stderr] | |_________^ help: consider using: `sets.entry(p)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `BTreeMap` [INFO] [stderr] --> src/main.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | / if !sets.contains_key(&p) { [INFO] [stderr] 40 | | sets.insert(p, vec![v]); [INFO] [stderr] 41 | | continue; [INFO] [stderr] 42 | | } [INFO] [stderr] | |_________^ help: consider using: `sets.entry(p)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.19s [INFO] running `"docker" "inspect" "f4631821e2beab8b1d4103b9bdc2202aeaa28453cb51d79f8a5265c7660d40d6"` [INFO] running `"docker" "rm" "-f" "f4631821e2beab8b1d4103b9bdc2202aeaa28453cb51d79f8a5265c7660d40d6"` [INFO] [stdout] f4631821e2beab8b1d4103b9bdc2202aeaa28453cb51d79f8a5265c7660d40d6