[INFO] updating cached repository jamesmacaulay/rust-secd
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/jamesmacaulay/rust-secd
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/jamesmacaulay/rust-secd" "work/ex/clippy-test-run/sources/stable/gh/jamesmacaulay/rust-secd"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jamesmacaulay/rust-secd'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/jamesmacaulay/rust-secd" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jamesmacaulay/rust-secd"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jamesmacaulay/rust-secd'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] ce100867f7055de2e17d88bb9b105be326c23945
[INFO] sha for GitHub repo jamesmacaulay/rust-secd: ce100867f7055de2e17d88bb9b105be326c23945
[INFO] validating manifest of jamesmacaulay/rust-secd on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of jamesmacaulay/rust-secd on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing jamesmacaulay/rust-secd
[INFO] finished frobbing jamesmacaulay/rust-secd
[INFO] frobbed toml for jamesmacaulay/rust-secd written to work/ex/clippy-test-run/sources/stable/gh/jamesmacaulay/rust-secd/Cargo.toml
[INFO] started frobbing jamesmacaulay/rust-secd
[INFO] finished frobbing jamesmacaulay/rust-secd
[INFO] frobbed toml for jamesmacaulay/rust-secd written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jamesmacaulay/rust-secd/Cargo.toml
[INFO] crate jamesmacaulay/rust-secd has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting jamesmacaulay/rust-secd against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jamesmacaulay/rust-secd:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 3a8e5c487c676525ab4ac91be7c0da5c6b4b28170cbc2cc8401b2fe7880a397d
[INFO] running `"docker" "start" "-a" "3a8e5c487c676525ab4ac91be7c0da5c6b4b28170cbc2cc8401b2fe7880a397d"`
[INFO] [stderr]     Checking im v4.1.0
[INFO] [stderr]     Checking rust-secd v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:144:33
[INFO] [stderr]     |
[INFO] [stderr] 144 |                                 control: control,
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^ help: replace it with: `control`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:144:33
[INFO] [stderr]     |
[INFO] [stderr] 144 |                                 control: control,
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^ help: replace it with: `control`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: Variant name ends with the enum's name
[INFO] [stderr]   --> src/main.rs:19:5
[INFO] [stderr]    |
[INFO] [stderr] 19 |     ListValue(ConsList<Value>),
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::enum_variant_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `ListValue`
[INFO] [stderr]   --> src/main.rs:19:5
[INFO] [stderr]    |
[INFO] [stderr] 19 |     ListValue(ConsList<Value>),
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `VariableList`
[INFO] [stderr]   --> src/main.rs:25:5
[INFO] [stderr]    |
[INFO] [stderr] 25 |     VariableList(ConsList<String>),
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/main.rs:46:5
[INFO] [stderr]    |
[INFO] [stderr] 46 | /     match bound_vars {
[INFO] [stderr] 47 | |         &BoundVariables::VariableList(ref vars) => {
[INFO] [stderr] 48 | |             match **value {
[INFO] [stderr] 49 | |                 Value::ListValue(ref values) => {
[INFO] [stderr] ...  |
[INFO] [stderr] 62 | |         },
[INFO] [stderr] 63 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 46 |     match *bound_vars {
[INFO] [stderr] 47 |         BoundVariables::VariableList(ref vars) => {
[INFO] [stderr] 48 |             match **value {
[INFO] [stderr] 49 |                 Value::ListValue(ref values) => {
[INFO] [stderr] 50 |                     let pairs = vars.iter().zip(values.iter());
[INFO] [stderr] 51 |                     Ok(pairs.fold(conslist![], |acc, pair| {
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:114:13
[INFO] [stderr]     |
[INFO] [stderr] 114 | /             match hc.as_ref() {
[INFO] [stderr] 115 | |                 &Instruction::AE(ref expression) => {
[INFO] [stderr] 116 | |                     match expression.as_ref() {
[INFO] [stderr] 117 | |                         &Expression::Identifier(ref name) => {
[INFO] [stderr] ...   |
[INFO] [stderr] 174 | |                 }
[INFO] [stderr] 175 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 114 |             match *hc.as_ref() {
[INFO] [stderr] 115 |                 Instruction::AE(ref expression) => {
[INFO] [stderr] 116 |                     match expression.as_ref() {
[INFO] [stderr] 117 |                         &Expression::Identifier(ref name) => {
[INFO] [stderr] 118 |                             let value = location(&self.environment, name).unwrap_or(Arc::new(Value::Atom(name.clone())));
[INFO] [stderr] 119 |                             Ok(SECD {
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:116:21
[INFO] [stderr]     |
[INFO] [stderr] 116 | /                     match expression.as_ref() {
[INFO] [stderr] 117 | |                         &Expression::Identifier(ref name) => {
[INFO] [stderr] 118 | |                             let value = location(&self.environment, name).unwrap_or(Arc::new(Value::Atom(name.clone())));
[INFO] [stderr] 119 | |                             Ok(SECD {
[INFO] [stderr] ...   |
[INFO] [stderr] 147 | |                         }
[INFO] [stderr] 148 | |                     }
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 116 |                     match *expression.as_ref() {
[INFO] [stderr] 117 |                         Expression::Identifier(ref name) => {
[INFO] [stderr] 118 |                             let value = location(&self.environment, name).unwrap_or(Arc::new(Value::Atom(name.clone())));
[INFO] [stderr] 119 |                             Ok(SECD {
[INFO] [stderr] 120 |                                 stack: self.stack.cons(value),
[INFO] [stderr] 121 |                                 environment: self.environment.clone(),
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:118:75
[INFO] [stderr]     |
[INFO] [stderr] 118 |                             let value = location(&self.environment, name).unwrap_or(Arc::new(Value::Atom(name.clone())));
[INFO] [stderr]     |                                                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Arc::new(Value::Atom(name.clone())))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:152:25
[INFO] [stderr]     |
[INFO] [stderr] 152 | /                         if let &Value::Closure((ref closed_over_env, ref bound_vars), ref expression) = fst.as_ref() {
[INFO] [stderr] 153 | |                             assoc(bound_vars, snd).and_then(|bound_vars_env| {
[INFO] [stderr] 154 | |                                 let new_env = derive(&bound_vars_env, closed_over_env);
[INFO] [stderr] 155 | |                                 let dump2 = Some(Arc::new(SECD {
[INFO] [stderr] ...   |
[INFO] [stderr] 169 | |                             Err("invalid state: Ap instruction without Closure and argument at top of stack".to_string())
[INFO] [stderr] 170 | |                         }
[INFO] [stderr]     | |_________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 152 |                         if let Value::Closure((ref closed_over_env, ref bound_vars), ref expression) = *fst.as_ref() {
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: Variant name ends with the enum's name
[INFO] [stderr]   --> src/main.rs:19:5
[INFO] [stderr]    |
[INFO] [stderr] 19 |     ListValue(ConsList<Value>),
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::enum_variant_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `ListValue`
[INFO] [stderr]   --> src/main.rs:19:5
[INFO] [stderr]    |
[INFO] [stderr] 19 |     ListValue(ConsList<Value>),
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `VariableList`
[INFO] [stderr]   --> src/main.rs:25:5
[INFO] [stderr]    |
[INFO] [stderr] 25 |     VariableList(ConsList<String>),
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/main.rs:46:5
[INFO] [stderr]    |
[INFO] [stderr] 46 | /     match bound_vars {
[INFO] [stderr] 47 | |         &BoundVariables::VariableList(ref vars) => {
[INFO] [stderr] 48 | |             match **value {
[INFO] [stderr] 49 | |                 Value::ListValue(ref values) => {
[INFO] [stderr] ...  |
[INFO] [stderr] 62 | |         },
[INFO] [stderr] 63 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 46 |     match *bound_vars {
[INFO] [stderr] 47 |         BoundVariables::VariableList(ref vars) => {
[INFO] [stderr] 48 |             match **value {
[INFO] [stderr] 49 |                 Value::ListValue(ref values) => {
[INFO] [stderr] 50 |                     let pairs = vars.iter().zip(values.iter());
[INFO] [stderr] 51 |                     Ok(pairs.fold(conslist![], |acc, pair| {
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:114:13
[INFO] [stderr]     |
[INFO] [stderr] 114 | /             match hc.as_ref() {
[INFO] [stderr] 115 | |                 &Instruction::AE(ref expression) => {
[INFO] [stderr] 116 | |                     match expression.as_ref() {
[INFO] [stderr] 117 | |                         &Expression::Identifier(ref name) => {
[INFO] [stderr] ...   |
[INFO] [stderr] 174 | |                 }
[INFO] [stderr] 175 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 114 |             match *hc.as_ref() {
[INFO] [stderr] 115 |                 Instruction::AE(ref expression) => {
[INFO] [stderr] 116 |                     match expression.as_ref() {
[INFO] [stderr] 117 |                         &Expression::Identifier(ref name) => {
[INFO] [stderr] 118 |                             let value = location(&self.environment, name).unwrap_or(Arc::new(Value::Atom(name.clone())));
[INFO] [stderr] 119 |                             Ok(SECD {
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:116:21
[INFO] [stderr]     |
[INFO] [stderr] 116 | /                     match expression.as_ref() {
[INFO] [stderr] 117 | |                         &Expression::Identifier(ref name) => {
[INFO] [stderr] 118 | |                             let value = location(&self.environment, name).unwrap_or(Arc::new(Value::Atom(name.clone())));
[INFO] [stderr] 119 | |                             Ok(SECD {
[INFO] [stderr] ...   |
[INFO] [stderr] 147 | |                         }
[INFO] [stderr] 148 | |                     }
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 116 |                     match *expression.as_ref() {
[INFO] [stderr] 117 |                         Expression::Identifier(ref name) => {
[INFO] [stderr] 118 |                             let value = location(&self.environment, name).unwrap_or(Arc::new(Value::Atom(name.clone())));
[INFO] [stderr] 119 |                             Ok(SECD {
[INFO] [stderr] 120 |                                 stack: self.stack.cons(value),
[INFO] [stderr] 121 |                                 environment: self.environment.clone(),
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:118:75
[INFO] [stderr]     |
[INFO] [stderr] 118 |                             let value = location(&self.environment, name).unwrap_or(Arc::new(Value::Atom(name.clone())));
[INFO] [stderr]     |                                                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Arc::new(Value::Atom(name.clone())))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:152:25
[INFO] [stderr]     |
[INFO] [stderr] 152 | /                         if let &Value::Closure((ref closed_over_env, ref bound_vars), ref expression) = fst.as_ref() {
[INFO] [stderr] 153 | |                             assoc(bound_vars, snd).and_then(|bound_vars_env| {
[INFO] [stderr] 154 | |                                 let new_env = derive(&bound_vars_env, closed_over_env);
[INFO] [stderr] 155 | |                                 let dump2 = Some(Arc::new(SECD {
[INFO] [stderr] ...   |
[INFO] [stderr] 169 | |                             Err("invalid state: Ap instruction without Closure and argument at top of stack".to_string())
[INFO] [stderr] 170 | |                         }
[INFO] [stderr]     | |_________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 152 |                         if let Value::Closure((ref closed_over_env, ref bound_vars), ref expression) = *fst.as_ref() {
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.52s
[INFO] running `"docker" "inspect" "3a8e5c487c676525ab4ac91be7c0da5c6b4b28170cbc2cc8401b2fe7880a397d"`
[INFO] running `"docker" "rm" "-f" "3a8e5c487c676525ab4ac91be7c0da5c6b4b28170cbc2cc8401b2fe7880a397d"`
[INFO] [stdout] 3a8e5c487c676525ab4ac91be7c0da5c6b4b28170cbc2cc8401b2fe7880a397d