[INFO] updating cached repository jalexvig/proji [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jalexvig/proji [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jalexvig/proji" "work/ex/clippy-test-run/sources/stable/gh/jalexvig/proji"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jalexvig/proji'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jalexvig/proji" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jalexvig/proji"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jalexvig/proji'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fe1e148a470cf75c988f78e678da98f20ff5dce7 [INFO] sha for GitHub repo jalexvig/proji: fe1e148a470cf75c988f78e678da98f20ff5dce7 [INFO] validating manifest of jalexvig/proji on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jalexvig/proji on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jalexvig/proji [INFO] finished frobbing jalexvig/proji [INFO] frobbed toml for jalexvig/proji written to work/ex/clippy-test-run/sources/stable/gh/jalexvig/proji/Cargo.toml [INFO] started frobbing jalexvig/proji [INFO] finished frobbing jalexvig/proji [INFO] frobbed toml for jalexvig/proji written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jalexvig/proji/Cargo.toml [INFO] crate jalexvig/proji has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jalexvig/proji against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jalexvig/proji:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] eac47fde1c660fe87e0045dbdcd0c2d13e798e1ec688d56fe4327cd10907fa5b [INFO] running `"docker" "start" "-a" "eac47fde1c660fe87e0045dbdcd0c2d13e798e1ec688d56fe4327cd10907fa5b"` [INFO] [stderr] Compiling serde v1.0.59 [INFO] [stderr] Compiling proji v0.1.0 (/opt/crater/workdir) [INFO] [stderr] Checking serde_json v1.0.17 [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:83:23 [INFO] [stderr] | [INFO] [stderr] 83 | let dpath = match std::env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:83:23 [INFO] [stderr] | [INFO] [stderr] 83 | let dpath = match std::env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:97:22 [INFO] [stderr] | [INFO] [stderr] 97 | .expect(&format!("failed to create profile: {}", prof_name)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("failed to create profile: {}", prof_name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:115:40 [INFO] [stderr] | [INFO] [stderr] 115 | fs::File::open(fpath_prof).expect(&format!("could not open profile: {}", &fname)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("could not open profile: {}", &fname))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:117:57 [INFO] [stderr] | [INFO] [stderr] 117 | let json: Value = serde_json::from_reader(file).expect(&format!("error reading profile {}", &fname)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("error reading profile {}", &fname))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:157:38 [INFO] [stderr] | [INFO] [stderr] 157 | let file = fs::File::open(fpath).expect(&format!("could not open profile: {}", fname)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("could not open profile: {}", fname))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:159:53 [INFO] [stderr] | [INFO] [stderr] 159 | let json: Value = serde_json::from_reader(file).expect(&format!("error reading profile {}", &fname)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("error reading profile {}", &fname))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:274:28 [INFO] [stderr] | [INFO] [stderr] 274 | "mpl2" => Some(format!(include_str!("resources/licenses/mpl2"))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `include_str!("resources/licenses/mpl2").to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:97:22 [INFO] [stderr] | [INFO] [stderr] 97 | .expect(&format!("failed to create profile: {}", prof_name)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("failed to create profile: {}", prof_name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:292:5 [INFO] [stderr] | [INFO] [stderr] 292 | / match fs::create_dir(name) { [INFO] [stderr] 293 | | Err(why) => println!("failed to create directory: {:?}", why.kind()), [INFO] [stderr] 294 | | Ok(_) => {} [INFO] [stderr] 295 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = fs::create_dir(name) { println!("failed to create directory: {:?}", why.kind()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:115:40 [INFO] [stderr] | [INFO] [stderr] 115 | fs::File::open(fpath_prof).expect(&format!("could not open profile: {}", &fname)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("could not open profile: {}", &fname))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:117:57 [INFO] [stderr] | [INFO] [stderr] 117 | let json: Value = serde_json::from_reader(file).expect(&format!("error reading profile {}", &fname)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("error reading profile {}", &fname))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:157:38 [INFO] [stderr] | [INFO] [stderr] 157 | let file = fs::File::open(fpath).expect(&format!("could not open profile: {}", fname)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("could not open profile: {}", fname))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:159:53 [INFO] [stderr] | [INFO] [stderr] 159 | let json: Value = serde_json::from_reader(file).expect(&format!("error reading profile {}", &fname)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("error reading profile {}", &fname))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:274:28 [INFO] [stderr] | [INFO] [stderr] 274 | "mpl2" => Some(format!(include_str!("resources/licenses/mpl2"))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `include_str!("resources/licenses/mpl2").to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:292:5 [INFO] [stderr] | [INFO] [stderr] 292 | / match fs::create_dir(name) { [INFO] [stderr] 293 | | Err(why) => println!("failed to create directory: {:?}", why.kind()), [INFO] [stderr] 294 | | Ok(_) => {} [INFO] [stderr] 295 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = fs::create_dir(name) { println!("failed to create directory: {:?}", why.kind()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 16.24s [INFO] running `"docker" "inspect" "eac47fde1c660fe87e0045dbdcd0c2d13e798e1ec688d56fe4327cd10907fa5b"` [INFO] running `"docker" "rm" "-f" "eac47fde1c660fe87e0045dbdcd0c2d13e798e1ec688d56fe4327cd10907fa5b"` [INFO] [stdout] eac47fde1c660fe87e0045dbdcd0c2d13e798e1ec688d56fe4327cd10907fa5b