[INFO] updating cached repository jakubdibala/gf [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jakubdibala/gf [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jakubdibala/gf" "work/ex/clippy-test-run/sources/stable/gh/jakubdibala/gf"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jakubdibala/gf'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jakubdibala/gf" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jakubdibala/gf"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jakubdibala/gf'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 174dfcf428295a7f06a23b1605d493f5a52095d1 [INFO] sha for GitHub repo jakubdibala/gf: 174dfcf428295a7f06a23b1605d493f5a52095d1 [INFO] validating manifest of jakubdibala/gf on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jakubdibala/gf on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jakubdibala/gf [INFO] finished frobbing jakubdibala/gf [INFO] frobbed toml for jakubdibala/gf written to work/ex/clippy-test-run/sources/stable/gh/jakubdibala/gf/Cargo.toml [INFO] started frobbing jakubdibala/gf [INFO] finished frobbing jakubdibala/gf [INFO] frobbed toml for jakubdibala/gf written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jakubdibala/gf/Cargo.toml [INFO] crate jakubdibala/gf has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jakubdibala/gf against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jakubdibala/gf:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 626491963c85bc4643fbaa68a6865c3bcbe9661ee20ab8ee1e9b283f2c9ac108 [INFO] running `"docker" "start" "-a" "626491963c85bc4643fbaa68a6865c3bcbe9661ee20ab8ee1e9b283f2c9ac108"` [INFO] [stderr] Checking gf v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/repository.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | branch_type: branch_type [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `branch_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/repository.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | branch_type: branch_type [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `branch_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `SubCommand` [INFO] [stderr] --> src/main.rs:7:22 [INFO] [stderr] | [INFO] [stderr] 7 | use clap::{Arg, App, SubCommand}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `SubCommand` [INFO] [stderr] --> src/main.rs:7:22 [INFO] [stderr] | [INFO] [stderr] 7 | use clap::{Arg, App, SubCommand}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `repo` [INFO] [stderr] --> src/main.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | let repo = match git2::Repository::open(Path::new(REPO_PATH)) { [INFO] [stderr] | ^^^^ help: consider using `_repo` instead [INFO] [stderr] warning: unused variable: `repo` [INFO] [stderr] --> src/main.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | let repo = match git2::Repository::open(Path::new(REPO_PATH)) { [INFO] [stderr] | ^^^^ help: consider using `_repo` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Branch` [INFO] [stderr] --> src/repository.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub struct Branch { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Branch` [INFO] [stderr] --> src/repository.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub struct Branch { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `branch_list` [INFO] [stderr] --> src/repository.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn branch_list(r: git2::Repository) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `current_branch` [INFO] [stderr] --> src/repository.rs:36:1 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn current_branch(r: git2::Repository) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/repository.rs:17:25 [INFO] [stderr] | [INFO] [stderr] 17 | while let Some(r) = branches.next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `for r in branches { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `branch_list` [INFO] [stderr] --> src/repository.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn branch_list(r: git2::Repository) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `current_branch` [INFO] [stderr] --> src/repository.rs:36:1 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn current_branch(r: git2::Repository) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/repository.rs:17:25 [INFO] [stderr] | [INFO] [stderr] 17 | while let Some(r) = branches.next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `for r in branches { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.71s [INFO] running `"docker" "inspect" "626491963c85bc4643fbaa68a6865c3bcbe9661ee20ab8ee1e9b283f2c9ac108"` [INFO] running `"docker" "rm" "-f" "626491963c85bc4643fbaa68a6865c3bcbe9661ee20ab8ee1e9b283f2c9ac108"` [INFO] [stdout] 626491963c85bc4643fbaa68a6865c3bcbe9661ee20ab8ee1e9b283f2c9ac108