[INFO] updating cached repository jakobbeckmann/sudoku [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jakobbeckmann/sudoku [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jakobbeckmann/sudoku" "work/ex/clippy-test-run/sources/stable/gh/jakobbeckmann/sudoku"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jakobbeckmann/sudoku'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jakobbeckmann/sudoku" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jakobbeckmann/sudoku"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jakobbeckmann/sudoku'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8c3b1208e5b1361da88105ab855c9c15e4b19ae2 [INFO] sha for GitHub repo jakobbeckmann/sudoku: 8c3b1208e5b1361da88105ab855c9c15e4b19ae2 [INFO] validating manifest of jakobbeckmann/sudoku on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jakobbeckmann/sudoku on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jakobbeckmann/sudoku [INFO] finished frobbing jakobbeckmann/sudoku [INFO] frobbed toml for jakobbeckmann/sudoku written to work/ex/clippy-test-run/sources/stable/gh/jakobbeckmann/sudoku/Cargo.toml [INFO] started frobbing jakobbeckmann/sudoku [INFO] finished frobbing jakobbeckmann/sudoku [INFO] frobbed toml for jakobbeckmann/sudoku written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jakobbeckmann/sudoku/Cargo.toml [INFO] crate jakobbeckmann/sudoku has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jakobbeckmann/sudoku against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jakobbeckmann/sudoku:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8e2d675b45581e6e07f0bede16336e832d2edd2a1bc7ced6ebbc14e8fcc35669 [INFO] running `"docker" "start" "-a" "8e2d675b45581e6e07f0bede16336e832d2edd2a1bc7ced6ebbc14e8fcc35669"` [INFO] [stderr] Compiling bitflags v1.0.0 [INFO] [stderr] Compiling rand v0.3.18 [INFO] [stderr] Checking tempfile v2.2.0 [INFO] [stderr] Checking rayon-core v1.2.1 [INFO] [stderr] Checking num-rational v0.1.40 [INFO] [stderr] Checking rusttype v0.2.3 [INFO] [stderr] Checking pistoncore-input v0.20.0 [INFO] [stderr] Compiling xml-rs v0.7.0 [INFO] [stderr] Checking rayon v0.8.2 [INFO] [stderr] Compiling phf_generator v0.7.21 [INFO] [stderr] Checking piston2d-graphics v0.23.0 [INFO] [stderr] Compiling phf_codegen v0.7.21 [INFO] [stderr] Compiling gl_generator v0.6.1 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Checking pistoncore-window v0.30.0 [INFO] [stderr] Checking jpeg-decoder v0.1.13 [INFO] [stderr] Compiling glutin v0.10.1 [INFO] [stderr] Compiling gl v0.6.5 [INFO] [stderr] Checking pistoncore-event_loop v0.35.0 [INFO] [stderr] Checking piston v0.35.0 [INFO] [stderr] Checking image v0.17.0 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking piston2d-opengl_graphics v0.49.0 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.9.10 [INFO] [stderr] Checking wayland-client v0.9.10 [INFO] [stderr] Checking wayland-protocols v0.9.10 [INFO] [stderr] Checking wayland-kbd v0.9.1 [INFO] [stderr] Checking wayland-window v0.8.0 [INFO] [stderr] Checking winit v0.8.3 [INFO] [stderr] Checking pistoncore-glutin_window v0.42.0 [INFO] [stderr] Checking sudoku v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboard_view.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | settings: settings, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `settings` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboard_view.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | settings: settings, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `settings` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gameboard.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | return self.cells[ind[1]][ind[0]].editable; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.cells[ind[1]][ind[0]].editable` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gameboard.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gameboard.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gameboard.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | return self.value; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gameboard.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | return self.cells[ind[1]][ind[0]].editable; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.cells[ind[1]][ind[0]].editable` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gameboard.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gameboard.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gameboard.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | return self.value; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `idx` [INFO] [stderr] --> src/gameboard.rs:63:17 [INFO] [stderr] | [INFO] [stderr] 63 | for idx in 0..80 { [INFO] [stderr] | ^^^ help: consider using `_idx` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `gameboard::Gameboard` [INFO] [stderr] --> src/gameboard.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Gameboard { [INFO] [stderr] 16 | | Gameboard { [INFO] [stderr] 17 | | cells: [[Cell::new(); SIZE]; SIZE], [INFO] [stderr] 18 | | } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | impl Default for gameboard::Gameboard { [INFO] [stderr] 14 | fn default() -> Self { [INFO] [stderr] 15 | Self::new() [INFO] [stderr] 16 | } [INFO] [stderr] 17 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/gameboard.rs:39:12 [INFO] [stderr] | [INFO] [stderr] 39 | if self.cells[ind[1]][ind[0]].editable == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `self.cells[ind[1]][ind[0]].editable` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/gameboard.rs:92:54 [INFO] [stderr] | [INFO] [stderr] 92 | fn backtrack(&mut self, ind: usize, empty_cells: &Vec<[usize; 2]>) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[[usize; 2]]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gameboard.rs:141:18 [INFO] [stderr] | [INFO] [stderr] 141 | pub fn value(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `gameboard_view::GameboardViewSettings` [INFO] [stderr] --> src/gameboard_view.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | / pub fn new() -> GameboardViewSettings { [INFO] [stderr] 42 | | GameboardViewSettings { [INFO] [stderr] 43 | | position: [10.0; 2], [INFO] [stderr] 44 | | size: 400.0, [INFO] [stderr] ... | [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/gameboard_view.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | let ref settings = self.settings; [INFO] [stderr] | ----^^^^^^^^^^^^----------------- help: try: `let settings = &self.settings;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/gameboard_view.rs:145:44 [INFO] [stderr] | [INFO] [stderr] 145 | let x = settings.position[0] + i as f64 / 9.0 * settings.size; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/gameboard_view.rs:146:44 [INFO] [stderr] | [INFO] [stderr] 146 | let y = settings.position[1] + i as f64 / 9.0 * settings.size; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/gameboard_view.rs:161:44 [INFO] [stderr] | [INFO] [stderr] 161 | let x = settings.position[0] + i as f64 / 3.0 * settings.size; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/gameboard_view.rs:162:44 [INFO] [stderr] | [INFO] [stderr] 162 | let y = settings.position[1] + i as f64 / 3.0 * settings.size; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | let ref mut glyphs = GlyphCache::new("assets/FiraSans-Regular.ttf", (), texture_settings) [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 47 | let glyphs = &mut GlyphCache::new("assets/FiraSans-Regular.ttf", (), texture_settings) [INFO] [stderr] 48 | .expect("Could not load font."); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `idx` [INFO] [stderr] --> src/gameboard.rs:63:17 [INFO] [stderr] | [INFO] [stderr] 63 | for idx in 0..80 { [INFO] [stderr] | ^^^ help: consider using `_idx` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `gameboard::Gameboard` [INFO] [stderr] --> src/gameboard.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Gameboard { [INFO] [stderr] 16 | | Gameboard { [INFO] [stderr] 17 | | cells: [[Cell::new(); SIZE]; SIZE], [INFO] [stderr] 18 | | } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | impl Default for gameboard::Gameboard { [INFO] [stderr] 14 | fn default() -> Self { [INFO] [stderr] 15 | Self::new() [INFO] [stderr] 16 | } [INFO] [stderr] 17 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/gameboard.rs:39:12 [INFO] [stderr] | [INFO] [stderr] 39 | if self.cells[ind[1]][ind[0]].editable == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `self.cells[ind[1]][ind[0]].editable` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/gameboard.rs:92:54 [INFO] [stderr] | [INFO] [stderr] 92 | fn backtrack(&mut self, ind: usize, empty_cells: &Vec<[usize; 2]>) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[[usize; 2]]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gameboard.rs:141:18 [INFO] [stderr] | [INFO] [stderr] 141 | pub fn value(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `gameboard_view::GameboardViewSettings` [INFO] [stderr] --> src/gameboard_view.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | / pub fn new() -> GameboardViewSettings { [INFO] [stderr] 42 | | GameboardViewSettings { [INFO] [stderr] 43 | | position: [10.0; 2], [INFO] [stderr] 44 | | size: 400.0, [INFO] [stderr] ... | [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/gameboard_view.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | let ref settings = self.settings; [INFO] [stderr] | ----^^^^^^^^^^^^----------------- help: try: `let settings = &self.settings;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/gameboard_view.rs:145:44 [INFO] [stderr] | [INFO] [stderr] 145 | let x = settings.position[0] + i as f64 / 9.0 * settings.size; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/gameboard_view.rs:146:44 [INFO] [stderr] | [INFO] [stderr] 146 | let y = settings.position[1] + i as f64 / 9.0 * settings.size; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/gameboard_view.rs:161:44 [INFO] [stderr] | [INFO] [stderr] 161 | let x = settings.position[0] + i as f64 / 3.0 * settings.size; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/gameboard_view.rs:162:44 [INFO] [stderr] | [INFO] [stderr] 162 | let y = settings.position[1] + i as f64 / 3.0 * settings.size; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | let ref mut glyphs = GlyphCache::new("assets/FiraSans-Regular.ttf", (), texture_settings) [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 47 | let glyphs = &mut GlyphCache::new("assets/FiraSans-Regular.ttf", (), texture_settings) [INFO] [stderr] 48 | .expect("Could not load font."); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 50.40s [INFO] running `"docker" "inspect" "8e2d675b45581e6e07f0bede16336e832d2edd2a1bc7ced6ebbc14e8fcc35669"` [INFO] running `"docker" "rm" "-f" "8e2d675b45581e6e07f0bede16336e832d2edd2a1bc7ced6ebbc14e8fcc35669"` [INFO] [stdout] 8e2d675b45581e6e07f0bede16336e832d2edd2a1bc7ced6ebbc14e8fcc35669