[INFO] updating cached repository jakobbeckmann/chans_algorithm [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jakobbeckmann/chans_algorithm [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jakobbeckmann/chans_algorithm" "work/ex/clippy-test-run/sources/stable/gh/jakobbeckmann/chans_algorithm"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jakobbeckmann/chans_algorithm'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jakobbeckmann/chans_algorithm" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jakobbeckmann/chans_algorithm"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jakobbeckmann/chans_algorithm'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fef9a303f1fd0c2b000af908aff6f956aa224784 [INFO] sha for GitHub repo jakobbeckmann/chans_algorithm: fef9a303f1fd0c2b000af908aff6f956aa224784 [INFO] validating manifest of jakobbeckmann/chans_algorithm on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jakobbeckmann/chans_algorithm on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jakobbeckmann/chans_algorithm [INFO] finished frobbing jakobbeckmann/chans_algorithm [INFO] frobbed toml for jakobbeckmann/chans_algorithm written to work/ex/clippy-test-run/sources/stable/gh/jakobbeckmann/chans_algorithm/Cargo.toml [INFO] started frobbing jakobbeckmann/chans_algorithm [INFO] finished frobbing jakobbeckmann/chans_algorithm [INFO] frobbed toml for jakobbeckmann/chans_algorithm written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jakobbeckmann/chans_algorithm/Cargo.toml [INFO] crate jakobbeckmann/chans_algorithm has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jakobbeckmann/chans_algorithm against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jakobbeckmann/chans_algorithm:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f9b2ac429fe388186490dcce5a51de74922ead21a6417ce92ca764d8b29be8ca [INFO] running `"docker" "start" "-a" "f9b2ac429fe388186490dcce5a51de74922ead21a6417ce92ca764d8b29be8ca"` [INFO] [stderr] Compiling cc v1.0.2 [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking serde v1.0.16 [INFO] [stderr] Checking ordered-float v0.5.0 [INFO] [stderr] Compiling serde_derive v1.0.16 [INFO] [stderr] Checking chrono v0.3.0 [INFO] [stderr] Checking csv-core v0.1.3 [INFO] [stderr] Compiling miniz-sys v0.1.10 [INFO] [stderr] Checking flate2 v0.2.20 [INFO] [stderr] Checking serde-value v0.5.1 [INFO] [stderr] Checking serde_json v1.0.4 [INFO] [stderr] Checking serde_yaml v0.7.1 [INFO] [stderr] Checking csv v1.0.0-beta.5 [INFO] [stderr] Checking log4rs v0.7.0 [INFO] [stderr] Checking chan v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/io.rs:74:29 [INFO] [stderr] | [INFO] [stderr] 74 | writeln!(file, "{},{}", "x value", "y value"); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/io.rs:74:40 [INFO] [stderr] | [INFO] [stderr] 74 | writeln!(file, "{},{}", "x value", "y value"); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/io.rs:98:29 [INFO] [stderr] | [INFO] [stderr] 98 | writeln!(file, "{},{}", "x value", "y value"); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/io.rs:98:40 [INFO] [stderr] | [INFO] [stderr] 98 | writeln!(file, "{},{}", "x value", "y value"); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/io.rs:74:29 [INFO] [stderr] | [INFO] [stderr] 74 | writeln!(file, "{},{}", "x value", "y value"); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/io.rs:74:40 [INFO] [stderr] | [INFO] [stderr] 74 | writeln!(file, "{},{}", "x value", "y value"); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/io.rs:98:29 [INFO] [stderr] | [INFO] [stderr] 98 | writeln!(file, "{},{}", "x value", "y value"); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/io.rs:98:40 [INFO] [stderr] | [INFO] [stderr] 98 | writeln!(file, "{},{}", "x value", "y value"); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/io.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | return points; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `points` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util/graham.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | return hull; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `hull` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util/chan.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util/chan.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util/chan.rs:141:5 [INFO] [stderr] | [INFO] [stderr] 141 | return lower_bound as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `lower_bound as usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util/mod.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | return Ordering::Equal; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ordering::Equal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | return (self.x - other.x).abs() < EPSILON && (self.y - other.y).abs() < EPSILON; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.x - other.x).abs() < EPSILON && (self.y - other.y).abs() < EPSILON` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `idx` [INFO] [stderr] --> src/util/chan.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | for idx in 0..parallelism { [INFO] [stderr] | ^^^ help: consider using `_idx` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/io.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | return points; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `points` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util/graham.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | return hull; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `hull` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util/chan.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util/chan.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util/chan.rs:141:5 [INFO] [stderr] | [INFO] [stderr] 141 | return lower_bound as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `lower_bound as usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::*` [INFO] [stderr] --> src/util/chan.rs:147:9 [INFO] [stderr] | [INFO] [stderr] 147 | use super::*; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util/mod.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | return Ordering::Equal; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ordering::Equal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | return (self.x - other.x).abs() < EPSILON && (self.y - other.y).abs() < EPSILON; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.x - other.x).abs() < EPSILON && (self.y - other.y).abs() < EPSILON` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/io.rs:42:29 [INFO] [stderr] | [INFO] [stderr] 42 | 0 as f64 [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/io.rs:50:33 [INFO] [stderr] | [INFO] [stderr] 50 | 0 as f64 [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/io.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | writeln!(file, "{},{}", "x value", "y value"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/io.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | writeln!(file, "{},{}", x, y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/io.rs:90:45 [INFO] [stderr] | [INFO] [stderr] 90 | pub fn print_points(filename: &str, points: &Vec<::Point>) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[::Point]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/io.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | writeln!(file, "{},{}", "x value", "y value"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/io.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | writeln!(file, "{},{}", point.x, point.y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/util/chan.rs:62:33 [INFO] [stderr] | [INFO] [stderr] 62 | fn find_next_merge_point(hulls: &Vec>, base_pair: (usize, usize)) -> (usize, usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec<::Point>]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/util/chan.rs:85:29 [INFO] [stderr] | [INFO] [stderr] 85 | fn find_lowest_point(hulls: &Vec>) -> (usize, usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec<::Point>]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/util/chan.rs:103:29 [INFO] [stderr] | [INFO] [stderr] 103 | fn find_tangent_index(hull: &Vec<::Point>, base: &::Point) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[::Point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/util/chan.rs:132:19 [INFO] [stderr] | [INFO] [stderr] 132 | } else if (cut_direction != Ordering::Greater && lb_turn_after != Ordering::Less) || [INFO] [stderr] | ___________________^ [INFO] [stderr] 133 | | (cut_direction == Ordering::Greater && mid_turn_before == Ordering::Greater) { [INFO] [stderr] | |______________________________________________________________________________________________^ help: try: `cut_direction != Ordering::Greater && lb_turn_after != Ordering::Less || cut_direction == Ordering::Greater && mid_turn_before == Ordering::Greater` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: unused variable: `idx` [INFO] [stderr] --> src/util/chan.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | for idx in 0..parallelism { [INFO] [stderr] | ^^^ help: consider using `_idx` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/io.rs:42:29 [INFO] [stderr] | [INFO] [stderr] 42 | 0 as f64 [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/io.rs:50:33 [INFO] [stderr] | [INFO] [stderr] 50 | 0 as f64 [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/io.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | writeln!(file, "{},{}", "x value", "y value"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/io.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | writeln!(file, "{},{}", x, y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/io.rs:90:45 [INFO] [stderr] | [INFO] [stderr] 90 | pub fn print_points(filename: &str, points: &Vec<::Point>) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[::Point]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/io.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | writeln!(file, "{},{}", "x value", "y value"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/io.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | writeln!(file, "{},{}", point.x, point.y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/util/chan.rs:62:33 [INFO] [stderr] | [INFO] [stderr] 62 | fn find_next_merge_point(hulls: &Vec>, base_pair: (usize, usize)) -> (usize, usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec<::Point>]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/util/chan.rs:85:29 [INFO] [stderr] | [INFO] [stderr] 85 | fn find_lowest_point(hulls: &Vec>) -> (usize, usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec<::Point>]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/util/chan.rs:103:29 [INFO] [stderr] | [INFO] [stderr] 103 | fn find_tangent_index(hull: &Vec<::Point>, base: &::Point) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[::Point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/util/chan.rs:132:19 [INFO] [stderr] | [INFO] [stderr] 132 | } else if (cut_direction != Ordering::Greater && lb_turn_after != Ordering::Less) || [INFO] [stderr] | ___________________^ [INFO] [stderr] 133 | | (cut_direction == Ordering::Greater && mid_turn_before == Ordering::Greater) { [INFO] [stderr] | |______________________________________________________________________________________________^ help: try: `cut_direction != Ordering::Greater && lb_turn_after != Ordering::Less || cut_direction == Ordering::Greater && mid_turn_before == Ordering::Greater` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: value assigned to `hull` is never read [INFO] [stderr] --> src/main.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | let mut hull: Vec = Vec::with_capacity(1_000_000); // TODO: this could be made smaller maybe [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:23:25 [INFO] [stderr] | [INFO] [stderr] 23 | io::generate_points(1000 as f64, n_points); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(1000)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: value assigned to `hull` is never read [INFO] [stderr] --> src/main.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | let mut hull: Vec = Vec::with_capacity(1_000_000); // TODO: this could be made smaller maybe [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:23:25 [INFO] [stderr] | [INFO] [stderr] 23 | io::generate_points(1000 as f64, n_points); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(1000)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 32.86s [INFO] running `"docker" "inspect" "f9b2ac429fe388186490dcce5a51de74922ead21a6417ce92ca764d8b29be8ca"` [INFO] running `"docker" "rm" "-f" "f9b2ac429fe388186490dcce5a51de74922ead21a6417ce92ca764d8b29be8ca"` [INFO] [stdout] f9b2ac429fe388186490dcce5a51de74922ead21a6417ce92ca764d8b29be8ca