[INFO] updating cached repository jakewins/neobench [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jakewins/neobench [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jakewins/neobench" "work/ex/clippy-test-run/sources/stable/gh/jakewins/neobench"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jakewins/neobench'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jakewins/neobench" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jakewins/neobench"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jakewins/neobench'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 338915c455681ea630d66127f0da6e66748f20fa [INFO] sha for GitHub repo jakewins/neobench: 338915c455681ea630d66127f0da6e66748f20fa [INFO] validating manifest of jakewins/neobench on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jakewins/neobench on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jakewins/neobench [INFO] finished frobbing jakewins/neobench [INFO] frobbed toml for jakewins/neobench written to work/ex/clippy-test-run/sources/stable/gh/jakewins/neobench/Cargo.toml [INFO] started frobbing jakewins/neobench [INFO] finished frobbing jakewins/neobench [INFO] frobbed toml for jakewins/neobench written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jakewins/neobench/Cargo.toml [INFO] crate jakewins/neobench has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jakewins/neobench against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jakewins/neobench:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6ccd766d7845c0f8a1aa97d9732656b221f9b0fe1e4f1e1e81b53d72a5b0580c [INFO] running `"docker" "start" "-a" "6ccd766d7845c0f8a1aa97d9732656b221f9b0fe1e4f1e1e81b53d72a5b0580c"` [INFO] [stderr] Checking neobench v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | registers: registers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `registers` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | function: function, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `function` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | function: function, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `function` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | registers: registers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `registers` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | function: function, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `function` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | function: function, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `function` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fmt::Display` [INFO] [stderr] --> src/main.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::fmt::Display; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fmt::Formatter` [INFO] [stderr] --> src/main.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::fmt::Formatter; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `core::fmt` [INFO] [stderr] --> src/main.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use core::fmt; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/types.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | return self.vars.len() - 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.vars.len() - 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/types.rs:163:63 [INFO] [stderr] | [INFO] [stderr] 163 | (Value::Integer(l), Value::Integer(r)) => return Value::Integer(l * r), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Value::Integer(l * r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/types.rs:171:63 [INFO] [stderr] | [INFO] [stderr] 171 | (Value::Integer(l), Value::Integer(r)) => return Value::Integer(l / r), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Value::Integer(l / r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/expr_parser.rs:218:5 [INFO] [stderr] | [INFO] [stderr] 218 | return ctx.left_hand_expression.expect("Should be defined") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ctx.left_hand_expression.expect("Should be defined")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/expr_parser.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | return func [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `func` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:14:18 [INFO] [stderr] | [INFO] [stderr] 14 | const TPCBLIKE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/main.rs:36:61 [INFO] [stderr] | [INFO] [stderr] 36 | Command::Cypher(cypher::CypherStatement{ query, params: _ }) => format!("{}", query), [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `CypherStatement { query, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fmt::Display` [INFO] [stderr] --> src/main.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::fmt::Display; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fmt::Formatter` [INFO] [stderr] --> src/main.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::fmt::Formatter; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `core::fmt` [INFO] [stderr] --> src/main.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use core::fmt; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/types.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | return self.vars.len() - 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.vars.len() - 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/types.rs:163:63 [INFO] [stderr] | [INFO] [stderr] 163 | (Value::Integer(l), Value::Integer(r)) => return Value::Integer(l * r), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Value::Integer(l * r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/types.rs:171:63 [INFO] [stderr] | [INFO] [stderr] 171 | (Value::Integer(l), Value::Integer(r)) => return Value::Integer(l / r), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Value::Integer(l / r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/expr_parser.rs:218:5 [INFO] [stderr] | [INFO] [stderr] 218 | return ctx.left_hand_expression.expect("Should be defined") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ctx.left_hand_expression.expect("Should be defined")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/expr_parser.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | return func [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `func` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `types::*` [INFO] [stderr] --> src/expr_parser.rs:294:9 [INFO] [stderr] | [INFO] [stderr] 294 | use types::*; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:14:18 [INFO] [stderr] | [INFO] [stderr] 14 | const TPCBLIKE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/main.rs:36:61 [INFO] [stderr] | [INFO] [stderr] 36 | Command::Cypher(cypher::CypherStatement{ query, params: _ }) => format!("{}", query), [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `CypherStatement { query, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/types.rs:212:20 [INFO] [stderr] | [INFO] [stderr] 212 | fn eval(&self, ctx: & mut EvalScope) -> Value { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `len` [INFO] [stderr] --> src/types.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn len(&self) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Text` [INFO] [stderr] --> src/types.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | Text(String), [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `vars` [INFO] [stderr] --> src/types.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | vars: Variables, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/types.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | pub fn new(v: Variables) -> EvalScope { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set` [INFO] [stderr] --> src/types.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | pub fn set(&mut self, name: String, val: Value) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `describe` [INFO] [stderr] --> src/expr_parser.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | fn describe(&self) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cypher.rs:16:45 [INFO] [stderr] | [INFO] [stderr] 16 | fn already_seen(idx: &VarIndex, params: &Vec<(VarIndex, String)>) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(VarIndex, String)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cypher.rs:16:26 [INFO] [stderr] | [INFO] [stderr] 16 | fn already_seen(idx: &VarIndex, params: &Vec<(VarIndex, String)>) -> bool { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `VarIndex` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/types.rs:48:49 [INFO] [stderr] | [INFO] [stderr] 48 | Value::Integer(v) => Value::Integer(v.clone()), [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*v` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: method `newOperator` should have a snake case name such as `new_operator` [INFO] [stderr] --> src/types.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | / pub fn newOperator(function: FunctionName) -> Box { [INFO] [stderr] 130 | | Box::new(ExprFuncCall{ [INFO] [stderr] 131 | | function: function, [INFO] [stderr] 132 | | args: Vec::new(), [INFO] [stderr] 133 | | is_operator: true, [INFO] [stderr] 134 | | }) [INFO] [stderr] 135 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/types.rs:141:61 [INFO] [stderr] | [INFO] [stderr] 141 | let lh = self.args.get(0).map(|f| f.describe()).unwrap_or(String::from("None")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("None"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/types.rs:142:61 [INFO] [stderr] | [INFO] [stderr] 142 | let rh = self.args.get(1).map(|f| f.describe()).unwrap_or(String::from("None")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("None"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/expr_parser.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | / match ctx.left_hand_expression { [INFO] [stderr] 69 | | Some(_) => { [INFO] [stderr] 70 | | func.args.push(ctx.left_hand_expression.take().unwrap()); [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | None => () [INFO] [stderr] 73 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 68 | if let Some(_) = ctx.left_hand_expression { [INFO] [stderr] 69 | func.args.push(ctx.left_hand_expression.take().unwrap()); [INFO] [stderr] 70 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:36:77 [INFO] [stderr] | [INFO] [stderr] 36 | Command::Cypher(cypher::CypherStatement{ query, params: _ }) => format!("{}", query), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `query.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the variable `cursor` is used as a loop counter. Consider using `for (cursor, item) in chars.enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:75:14 [INFO] [stderr] | [INFO] [stderr] 75 | for c in chars { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/types.rs:212:20 [INFO] [stderr] | [INFO] [stderr] 212 | fn eval(&self, ctx: & mut EvalScope) -> Value { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `describe` [INFO] [stderr] --> src/expr_parser.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | fn describe(&self) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cypher.rs:16:45 [INFO] [stderr] | [INFO] [stderr] 16 | fn already_seen(idx: &VarIndex, params: &Vec<(VarIndex, String)>) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(VarIndex, String)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cypher.rs:16:26 [INFO] [stderr] | [INFO] [stderr] 16 | fn already_seen(idx: &VarIndex, params: &Vec<(VarIndex, String)>) -> bool { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `VarIndex` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/types.rs:48:49 [INFO] [stderr] | [INFO] [stderr] 48 | Value::Integer(v) => Value::Integer(v.clone()), [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*v` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: method `newOperator` should have a snake case name such as `new_operator` [INFO] [stderr] --> src/types.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | / pub fn newOperator(function: FunctionName) -> Box { [INFO] [stderr] 130 | | Box::new(ExprFuncCall{ [INFO] [stderr] 131 | | function: function, [INFO] [stderr] 132 | | args: Vec::new(), [INFO] [stderr] 133 | | is_operator: true, [INFO] [stderr] 134 | | }) [INFO] [stderr] 135 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/types.rs:141:61 [INFO] [stderr] | [INFO] [stderr] 141 | let lh = self.args.get(0).map(|f| f.describe()).unwrap_or(String::from("None")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("None"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/types.rs:142:61 [INFO] [stderr] | [INFO] [stderr] 142 | let rh = self.args.get(1).map(|f| f.describe()).unwrap_or(String::from("None")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("None"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/expr_parser.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | / match ctx.left_hand_expression { [INFO] [stderr] 69 | | Some(_) => { [INFO] [stderr] 70 | | func.args.push(ctx.left_hand_expression.take().unwrap()); [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | None => () [INFO] [stderr] 73 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 68 | if let Some(_) = ctx.left_hand_expression { [INFO] [stderr] 69 | func.args.push(ctx.left_hand_expression.take().unwrap()); [INFO] [stderr] 70 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:36:77 [INFO] [stderr] | [INFO] [stderr] 36 | Command::Cypher(cypher::CypherStatement{ query, params: _ }) => format!("{}", query), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `query.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the variable `cursor` is used as a loop counter. Consider using `for (cursor, item) in chars.enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:75:14 [INFO] [stderr] | [INFO] [stderr] 75 | for c in chars { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.50s [INFO] running `"docker" "inspect" "6ccd766d7845c0f8a1aa97d9732656b221f9b0fe1e4f1e1e81b53d72a5b0580c"` [INFO] running `"docker" "rm" "-f" "6ccd766d7845c0f8a1aa97d9732656b221f9b0fe1e4f1e1e81b53d72a5b0580c"` [INFO] [stdout] 6ccd766d7845c0f8a1aa97d9732656b221f9b0fe1e4f1e1e81b53d72a5b0580c