[INFO] updating cached repository jakecoffman/rust-rest [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jakecoffman/rust-rest [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jakecoffman/rust-rest" "work/ex/clippy-test-run/sources/stable/gh/jakecoffman/rust-rest"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jakecoffman/rust-rest'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jakecoffman/rust-rest" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jakecoffman/rust-rest"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jakecoffman/rust-rest'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0b93915708734480bd2f530fee8e8171f680d3dd [INFO] sha for GitHub repo jakecoffman/rust-rest: 0b93915708734480bd2f530fee8e8171f680d3dd [INFO] validating manifest of jakecoffman/rust-rest on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jakecoffman/rust-rest on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jakecoffman/rust-rest [INFO] finished frobbing jakecoffman/rust-rest [INFO] frobbed toml for jakecoffman/rust-rest written to work/ex/clippy-test-run/sources/stable/gh/jakecoffman/rust-rest/Cargo.toml [INFO] started frobbing jakecoffman/rust-rest [INFO] finished frobbing jakecoffman/rust-rest [INFO] frobbed toml for jakecoffman/rust-rest written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jakecoffman/rust-rest/Cargo.toml [INFO] crate jakecoffman/rust-rest has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jakecoffman/rust-rest against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jakecoffman/rust-rest:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9f2b24792158b9d1e766627074f3cd2f3cee1a510d484c9d9779ef3fb7c4c708 [INFO] running `"docker" "start" "-a" "9f2b24792158b9d1e766627074f3cd2f3cee1a510d484c9d9779ef3fb7c4c708"` [INFO] [stderr] Compiling serde v1.0.49 [INFO] [stderr] Checking horrorshow v0.6.3 [INFO] [stderr] Compiling memchr v1.0.2 [INFO] [stderr] Checking socket2 v0.3.5 [INFO] [stderr] Checking stringprep v0.1.2 [INFO] [stderr] Compiling syn v0.12.15 [INFO] [stderr] Checking tokio-io v0.1.5 [INFO] [stderr] Compiling serde_derive v1.0.49 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Compiling nom v3.2.1 [INFO] [stderr] Checking sha2 v0.7.1 [INFO] [stderr] Compiling askama_shared v0.6.2 [INFO] [stderr] Checking tokio-core v0.1.12 [INFO] [stderr] Checking h2 v0.1.6 [INFO] [stderr] Checking postgres-protocol v0.3.2 [INFO] [stderr] Checking trust-dns-proto v0.3.3 [INFO] [stderr] Checking tokio-signal v0.1.5 [INFO] [stderr] Checking postgres-shared v0.4.1 [INFO] [stderr] Compiling askama_derive v0.6.4 [INFO] [stderr] Checking trust-dns-resolver v0.8.2 [INFO] [stderr] Compiling diesel_derives v1.2.0 [INFO] [stderr] Compiling semver v0.8.0 [INFO] [stderr] Compiling serde_json v1.0.17 [INFO] [stderr] Checking postgres v0.15.2 [INFO] [stderr] Checking serde_urlencoded v0.5.1 [INFO] [stderr] Compiling cargo_metadata v0.3.3 [INFO] [stderr] Checking diesel v1.2.2 [INFO] [stderr] Compiling skeptic v0.13.2 [INFO] [stderr] Checking askama v0.6.4 [INFO] [stderr] Compiling actix v0.5.6 [INFO] [stderr] Checking actix-web v0.5.6 [INFO] [stderr] Checking rust-rest v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/users.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / match user.candy.borrow() { [INFO] [stderr] 30 | | &None => {} [INFO] [stderr] 31 | | &Some(ref candy) => if candy == "pez" { println!("Yum, pez!") } [INFO] [stderr] 32 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 29 | match *user.candy.borrow() { [INFO] [stderr] 30 | None => {} [INFO] [stderr] 31 | Some(ref candy) => if candy == "pez" { println!("Yum, pez!") } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/users.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / match user.candy.borrow() { [INFO] [stderr] 30 | | &None => {} [INFO] [stderr] 31 | | &Some(ref candy) => if candy == "pez" { println!("Yum, pez!") } [INFO] [stderr] 32 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 29 | match *user.candy.borrow() { [INFO] [stderr] 30 | None => {} [INFO] [stderr] 31 | Some(ref candy) => if candy == "pez" { println!("Yum, pez!") } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2m 00s [INFO] running `"docker" "inspect" "9f2b24792158b9d1e766627074f3cd2f3cee1a510d484c9d9779ef3fb7c4c708"` [INFO] running `"docker" "rm" "-f" "9f2b24792158b9d1e766627074f3cd2f3cee1a510d484c9d9779ef3fb7c4c708"` [INFO] [stdout] 9f2b24792158b9d1e766627074f3cd2f3cee1a510d484c9d9779ef3fb7c4c708