[INFO] updating cached repository jakeactually/chip-8 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jakeactually/chip-8 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jakeactually/chip-8" "work/ex/clippy-test-run/sources/stable/gh/jakeactually/chip-8"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jakeactually/chip-8'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jakeactually/chip-8" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jakeactually/chip-8"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jakeactually/chip-8'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6cb0e1937bb4ae31f4cda8a7eec9bbe1ebbfe306 [INFO] sha for GitHub repo jakeactually/chip-8: 6cb0e1937bb4ae31f4cda8a7eec9bbe1ebbfe306 [INFO] validating manifest of jakeactually/chip-8 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jakeactually/chip-8 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jakeactually/chip-8 [INFO] finished frobbing jakeactually/chip-8 [INFO] frobbed toml for jakeactually/chip-8 written to work/ex/clippy-test-run/sources/stable/gh/jakeactually/chip-8/Cargo.toml [INFO] started frobbing jakeactually/chip-8 [INFO] finished frobbing jakeactually/chip-8 [INFO] frobbed toml for jakeactually/chip-8 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jakeactually/chip-8/Cargo.toml [INFO] crate jakeactually/chip-8 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jakeactually/chip-8 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jakeactually/chip-8:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 56c7aefa18aede7960ec1742e340f945a61e038b8b4ce5edc92d3b0df0dea2fb [INFO] running `"docker" "start" "-a" "56c7aefa18aede7960ec1742e340f945a61e038b8b4ce5edc92d3b0df0dea2fb"` [INFO] [stderr] Compiling log v0.4.1 [INFO] [stderr] Compiling phf v0.7.22 [INFO] [stderr] Checking rusttype v0.2.3 [INFO] [stderr] Compiling num-traits v0.1.43 [INFO] [stderr] Checking gfx_core v0.7.2 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Checking png v0.9.0 [INFO] [stderr] Checking pistoncore-input v0.19.0 [INFO] [stderr] Compiling serde_json v0.9.10 [INFO] [stderr] Checking jpeg-decoder v0.1.14 [INFO] [stderr] Checking memmap v0.4.0 [INFO] [stderr] Compiling log v0.3.9 [INFO] [stderr] Compiling gl_generator v0.6.1 [INFO] [stderr] Compiling gl_generator v0.5.5 [INFO] [stderr] Compiling gl_generator v0.7.0 [INFO] [stderr] Checking image v0.15.0 [INFO] [stderr] Checking pistoncore-window v0.28.0 [INFO] [stderr] Compiling gfx_gl v0.4.0 [INFO] [stderr] Compiling glutin v0.9.2 [INFO] [stderr] Compiling gl v0.6.5 [INFO] [stderr] Checking pistoncore-event_loop v0.33.0 [INFO] [stderr] Checking piston v0.33.0 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.9.10 [INFO] [stderr] Checking wayland-client v0.9.10 [INFO] [stderr] Checking wayland-protocols v0.9.10 [INFO] [stderr] Checking wayland-kbd v0.9.1 [INFO] [stderr] Checking wayland-window v0.7.0 [INFO] [stderr] Checking winit v0.7.6 [INFO] [stderr] Checking pistoncore-glutin_window v0.39.1 [INFO] [stderr] Checking gfx v0.16.3 [INFO] [stderr] Checking gfx_device_gl v0.14.6 [INFO] [stderr] Checking piston-gfx_texture v0.26.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.43.0 [INFO] [stderr] Checking piston_window v0.70.0 [INFO] [stderr] Checking chip8 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/chip8.rs:148:17 [INFO] [stderr] | [INFO] [stderr] 148 | let _ = write!( [INFO] [stderr] | _________________^ [INFO] [stderr] 149 | | &mut self.log, [INFO] [stderr] 150 | | "{:<16} {:<4x} {} p{:<4x} i{:<4x}\n", [INFO] [stderr] 151 | | decode(byte1, byte2), [INFO] [stderr] ... | [INFO] [stderr] 155 | | self.cpu.i [INFO] [stderr] 156 | | ); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/chip8.rs:148:17 [INFO] [stderr] | [INFO] [stderr] 148 | let _ = write!( [INFO] [stderr] | _________________^ [INFO] [stderr] 149 | | &mut self.log, [INFO] [stderr] 150 | | "{:<16} {:<4x} {} p{:<4x} i{:<4x}\n", [INFO] [stderr] 151 | | decode(byte1, byte2), [INFO] [stderr] ... | [INFO] [stderr] 155 | | self.cpu.i [INFO] [stderr] 156 | | ); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/assembler.rs:39:50 [INFO] [stderr] | [INFO] [stderr] 39 | "LOAD" => 0xF000 + args[0] * 0x100 + 055, [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 39 | "LOAD" => 0xF000 + args[0] * 0x100 + 55, [INFO] [stderr] | ^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 39 | "LOAD" => 0xF000 + args[0] * 0x100 + 0o55, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::string::String` [INFO] [stderr] --> src/run.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use std::string::String; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/run.rs:45:44 [INFO] [stderr] | [INFO] [stderr] 45 | thread::sleep(Duration::new(0, 8333333)); [INFO] [stderr] | ^^^^^^^ help: consider: `8_333_333` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `WHITE` [INFO] [stderr] --> src/data.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | pub const WHITE: [f32; 4] = [1.0, 1.0, 1.0, 1.0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `BLACK` [INFO] [stderr] --> src/data.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub const BLACK: [f32; 4] = [0.0, 0.0, 0.0, 1.0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `disassemble` [INFO] [stderr] --> src/dissasembler.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn disassemble(bytes: Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/assembler.rs:68:36 [INFO] [stderr] | [INFO] [stderr] 68 | let args = right.split(",").map( |x| x.trim().parse::().unwrap() ).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `fontset` [INFO] [stderr] --> src/chip8.rs:32:18 [INFO] [stderr] | [INFO] [stderr] 32 | for i in 0..80 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 32 | for (i, ) in fontset.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/chip8.rs:32:18 [INFO] [stderr] | [INFO] [stderr] 32 | for i in 0..80 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `chip8.cpu.memory[..80].clone_from_slice(&fontset[..80])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/chip8.rs:82:54 [INFO] [stderr] | [INFO] [stderr] 82 | let byte = self.cpu.memory[(self.cpu.i + relative_y as u16) as usize]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(relative_y)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/chip8.rs:145:22 [INFO] [stderr] | [INFO] [stderr] 145 | let opcode = (byte1 as u16) << 8 | byte2 as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(byte1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/chip8.rs:145:44 [INFO] [stderr] | [INFO] [stderr] 145 | let opcode = (byte1 as u16) << 8 | byte2 as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(byte2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:105:26 [INFO] [stderr] | [INFO] [stderr] 105 | let three_last = (bits2 as u16) << 8 | (bits3 as u16) << 4 | bits4 as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(bits2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:105:48 [INFO] [stderr] | [INFO] [stderr] 105 | let three_last = (bits2 as u16) << 8 | (bits3 as u16) << 4 | bits4 as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(bits3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:105:70 [INFO] [stderr] | [INFO] [stderr] 105 | let three_last = (bits2 as u16) << 8 | (bits3 as u16) << 4 | bits4 as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(bits4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:120:26 [INFO] [stderr] | [INFO] [stderr] 120 | let three_last = (bits2 as u16) << 8 | (bits3 as u16) << 4 | bits4 as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(bits2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:120:48 [INFO] [stderr] | [INFO] [stderr] 120 | let three_last = (bits2 as u16) << 8 | (bits3 as u16) << 4 | bits4 as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(bits3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:120:70 [INFO] [stderr] | [INFO] [stderr] 120 | let three_last = (bits2 as u16) << 8 | (bits3 as u16) << 4 | bits4 as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(bits4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:126:26 [INFO] [stderr] | [INFO] [stderr] 126 | let three_last = (bits2 as u16) << 8 | (bits3 as u16) << 4 | bits4 as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(bits2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:126:48 [INFO] [stderr] | [INFO] [stderr] 126 | let three_last = (bits2 as u16) << 8 | (bits3 as u16) << 4 | bits4 as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(bits3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:126:70 [INFO] [stderr] | [INFO] [stderr] 126 | let three_last = (bits2 as u16) << 8 | (bits3 as u16) << 4 | bits4 as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(bits4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:250:26 [INFO] [stderr] | [INFO] [stderr] 250 | let three_last = (bits2 as u16) << 8 | (bits3 as u16) << 4 | bits4 as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(bits2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:250:48 [INFO] [stderr] | [INFO] [stderr] 250 | let three_last = (bits2 as u16) << 8 | (bits3 as u16) << 4 | bits4 as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(bits3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:250:70 [INFO] [stderr] | [INFO] [stderr] 250 | let three_last = (bits2 as u16) << 8 | (bits3 as u16) << 4 | bits4 as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(bits4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:256:26 [INFO] [stderr] | [INFO] [stderr] 256 | let three_last = (bits2 as u16) << 8 | (bits3 as u16) << 4 | bits4 as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(bits2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:256:48 [INFO] [stderr] | [INFO] [stderr] 256 | let three_last = (bits2 as u16) << 8 | (bits3 as u16) << 4 | bits4 as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(bits3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:256:70 [INFO] [stderr] | [INFO] [stderr] 256 | let three_last = (bits2 as u16) << 8 | (bits3 as u16) << 4 | bits4 as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(bits4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:257:19 [INFO] [stderr] | [INFO] [stderr] 257 | self.pc = self.v[0] as u16 + three_last; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(self.v[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:285:27 [INFO] [stderr] | [INFO] [stderr] 285 | self.i += v[x] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(v[x])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:292:30 [INFO] [stderr] | [INFO] [stderr] 292 | 0x29 => self.i = v[x] as u16 * 5, [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(v[x])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/cpu.rs:311:26 [INFO] [stderr] | [INFO] [stderr] 311 | for j in 0..bits2 + 1 { [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `0..=bits2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:316:31 [INFO] [stderr] | [INFO] [stderr] 316 | self.i -= bits2 as u16 + 1; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(bits2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/cpu.rs:322:26 [INFO] [stderr] | [INFO] [stderr] 322 | for j in 0..bits2 + 1 { [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `0..=bits2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:327:31 [INFO] [stderr] | [INFO] [stderr] 327 | self.i -= bits2 as u16 + 1; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(bits2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/dissasembler.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | (byte1 as u16) << 8 | byte2 as u16 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(byte1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/dissasembler.rs:78:27 [INFO] [stderr] | [INFO] [stderr] 78 | (byte1 as u16) << 8 | byte2 as u16 [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(byte2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `y` is used to index `gfx2` [INFO] [stderr] --> src/run.rs:66:14 [INFO] [stderr] | [INFO] [stderr] 66 | for y in 0..32 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 66 | for (y, ) in gfx2.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/assembler.rs:39:50 [INFO] [stderr] | [INFO] [stderr] 39 | "LOAD" => 0xF000 + args[0] * 0x100 + 055, [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 39 | "LOAD" => 0xF000 + args[0] * 0x100 + 55, [INFO] [stderr] | ^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 39 | "LOAD" => 0xF000 + args[0] * 0x100 + 0o55, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::string::String` [INFO] [stderr] --> src/run.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use std::string::String; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/run.rs:45:44 [INFO] [stderr] | [INFO] [stderr] 45 | thread::sleep(Duration::new(0, 8333333)); [INFO] [stderr] | ^^^^^^^ help: consider: `8_333_333` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `WHITE` [INFO] [stderr] --> src/data.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | pub const WHITE: [f32; 4] = [1.0, 1.0, 1.0, 1.0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `BLACK` [INFO] [stderr] --> src/data.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub const BLACK: [f32; 4] = [0.0, 0.0, 0.0, 1.0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `disassemble` [INFO] [stderr] --> src/dissasembler.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn disassemble(bytes: Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/assembler.rs:68:36 [INFO] [stderr] | [INFO] [stderr] 68 | let args = right.split(",").map( |x| x.trim().parse::().unwrap() ).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `fontset` [INFO] [stderr] --> src/chip8.rs:32:18 [INFO] [stderr] | [INFO] [stderr] 32 | for i in 0..80 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 32 | for (i, ) in fontset.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/chip8.rs:32:18 [INFO] [stderr] | [INFO] [stderr] 32 | for i in 0..80 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `chip8.cpu.memory[..80].clone_from_slice(&fontset[..80])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/chip8.rs:82:54 [INFO] [stderr] | [INFO] [stderr] 82 | let byte = self.cpu.memory[(self.cpu.i + relative_y as u16) as usize]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(relative_y)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/chip8.rs:145:22 [INFO] [stderr] | [INFO] [stderr] 145 | let opcode = (byte1 as u16) << 8 | byte2 as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(byte1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/chip8.rs:145:44 [INFO] [stderr] | [INFO] [stderr] 145 | let opcode = (byte1 as u16) << 8 | byte2 as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(byte2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:105:26 [INFO] [stderr] | [INFO] [stderr] 105 | let three_last = (bits2 as u16) << 8 | (bits3 as u16) << 4 | bits4 as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(bits2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:105:48 [INFO] [stderr] | [INFO] [stderr] 105 | let three_last = (bits2 as u16) << 8 | (bits3 as u16) << 4 | bits4 as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(bits3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:105:70 [INFO] [stderr] | [INFO] [stderr] 105 | let three_last = (bits2 as u16) << 8 | (bits3 as u16) << 4 | bits4 as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(bits4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:120:26 [INFO] [stderr] | [INFO] [stderr] 120 | let three_last = (bits2 as u16) << 8 | (bits3 as u16) << 4 | bits4 as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(bits2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:120:48 [INFO] [stderr] | [INFO] [stderr] 120 | let three_last = (bits2 as u16) << 8 | (bits3 as u16) << 4 | bits4 as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(bits3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:120:70 [INFO] [stderr] | [INFO] [stderr] 120 | let three_last = (bits2 as u16) << 8 | (bits3 as u16) << 4 | bits4 as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(bits4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:126:26 [INFO] [stderr] | [INFO] [stderr] 126 | let three_last = (bits2 as u16) << 8 | (bits3 as u16) << 4 | bits4 as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(bits2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:126:48 [INFO] [stderr] | [INFO] [stderr] 126 | let three_last = (bits2 as u16) << 8 | (bits3 as u16) << 4 | bits4 as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(bits3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:126:70 [INFO] [stderr] | [INFO] [stderr] 126 | let three_last = (bits2 as u16) << 8 | (bits3 as u16) << 4 | bits4 as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(bits4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:250:26 [INFO] [stderr] | [INFO] [stderr] 250 | let three_last = (bits2 as u16) << 8 | (bits3 as u16) << 4 | bits4 as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(bits2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:250:48 [INFO] [stderr] | [INFO] [stderr] 250 | let three_last = (bits2 as u16) << 8 | (bits3 as u16) << 4 | bits4 as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(bits3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:250:70 [INFO] [stderr] | [INFO] [stderr] 250 | let three_last = (bits2 as u16) << 8 | (bits3 as u16) << 4 | bits4 as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(bits4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:256:26 [INFO] [stderr] | [INFO] [stderr] 256 | let three_last = (bits2 as u16) << 8 | (bits3 as u16) << 4 | bits4 as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(bits2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:256:48 [INFO] [stderr] | [INFO] [stderr] 256 | let three_last = (bits2 as u16) << 8 | (bits3 as u16) << 4 | bits4 as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(bits3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:256:70 [INFO] [stderr] | [INFO] [stderr] 256 | let three_last = (bits2 as u16) << 8 | (bits3 as u16) << 4 | bits4 as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(bits4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:257:19 [INFO] [stderr] | [INFO] [stderr] 257 | self.pc = self.v[0] as u16 + three_last; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(self.v[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:285:27 [INFO] [stderr] | [INFO] [stderr] 285 | self.i += v[x] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(v[x])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:292:30 [INFO] [stderr] | [INFO] [stderr] 292 | 0x29 => self.i = v[x] as u16 * 5, [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(v[x])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/cpu.rs:311:26 [INFO] [stderr] | [INFO] [stderr] 311 | for j in 0..bits2 + 1 { [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `0..=bits2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:316:31 [INFO] [stderr] | [INFO] [stderr] 316 | self.i -= bits2 as u16 + 1; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(bits2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/cpu.rs:322:26 [INFO] [stderr] | [INFO] [stderr] 322 | for j in 0..bits2 + 1 { [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `0..=bits2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:327:31 [INFO] [stderr] | [INFO] [stderr] 327 | self.i -= bits2 as u16 + 1; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(bits2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/dissasembler.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | (byte1 as u16) << 8 | byte2 as u16 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(byte1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/dissasembler.rs:78:27 [INFO] [stderr] | [INFO] [stderr] 78 | (byte1 as u16) << 8 | byte2 as u16 [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(byte2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `y` is used to index `gfx2` [INFO] [stderr] --> src/run.rs:66:14 [INFO] [stderr] | [INFO] [stderr] 66 | for y in 0..32 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 66 | for (y, ) in gfx2.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 43s [INFO] running `"docker" "inspect" "56c7aefa18aede7960ec1742e340f945a61e038b8b4ce5edc92d3b0df0dea2fb"` [INFO] running `"docker" "rm" "-f" "56c7aefa18aede7960ec1742e340f945a61e038b8b4ce5edc92d3b0df0dea2fb"` [INFO] [stdout] 56c7aefa18aede7960ec1742e340f945a61e038b8b4ce5edc92d3b0df0dea2fb