[INFO] updating cached repository jail-maker/jmaker-local-network-agent [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jail-maker/jmaker-local-network-agent [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jail-maker/jmaker-local-network-agent" "work/ex/clippy-test-run/sources/stable/gh/jail-maker/jmaker-local-network-agent"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jail-maker/jmaker-local-network-agent'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jail-maker/jmaker-local-network-agent" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jail-maker/jmaker-local-network-agent"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jail-maker/jmaker-local-network-agent'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a4d0e1fa55d8c7411eb87bcdf229e4a2f1a5bab1 [INFO] sha for GitHub repo jail-maker/jmaker-local-network-agent: a4d0e1fa55d8c7411eb87bcdf229e4a2f1a5bab1 [INFO] validating manifest of jail-maker/jmaker-local-network-agent on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jail-maker/jmaker-local-network-agent on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jail-maker/jmaker-local-network-agent [INFO] finished frobbing jail-maker/jmaker-local-network-agent [INFO] frobbed toml for jail-maker/jmaker-local-network-agent written to work/ex/clippy-test-run/sources/stable/gh/jail-maker/jmaker-local-network-agent/Cargo.toml [INFO] started frobbing jail-maker/jmaker-local-network-agent [INFO] finished frobbing jail-maker/jmaker-local-network-agent [INFO] frobbed toml for jail-maker/jmaker-local-network-agent written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jail-maker/jmaker-local-network-agent/Cargo.toml [INFO] crate jail-maker/jmaker-local-network-agent has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jail-maker/jmaker-local-network-agent against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jail-maker/jmaker-local-network-agent:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 35dea477591c79f88df336a5608a2a8ec15dfbfe6d8e1832045f6c9b7610ea8b [INFO] running `"docker" "start" "-a" "35dea477591c79f88df336a5608a2a8ec15dfbfe6d8e1832045f6c9b7610ea8b"` [INFO] [stderr] Compiling backtrace-sys v0.1.24 [INFO] [stderr] Compiling ring v0.13.2 [INFO] [stderr] Compiling brotli-sys v0.3.2 [INFO] [stderr] Compiling miniz-sys v0.1.10 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Checking crossbeam-channel v0.2.4 [INFO] [stderr] Checking tokio-signal v0.2.5 [INFO] [stderr] Checking flate2 v1.0.2 [INFO] [stderr] Checking backtrace v0.2.3 [INFO] [stderr] Checking backtrace v0.3.9 [INFO] [stderr] Checking error-chain v0.1.12 [INFO] [stderr] Checking trust-dns-proto v0.4.0 [INFO] [stderr] Checking cookie v0.11.0 [INFO] [stderr] Checking brotli2 v0.3.2 [INFO] [stderr] Checking trust-dns-resolver v0.9.1 [INFO] [stderr] Compiling synstructure v0.9.0 [INFO] [stderr] Compiling actix_derive v0.3.0 [INFO] [stderr] Compiling serde_derive v1.0.75 [INFO] [stderr] Compiling failure_derive v0.1.2 [INFO] [stderr] Checking failure v0.1.2 [INFO] [stderr] Checking actix v0.7.4 [INFO] [stderr] Checking ipnetwork v0.13.0 [INFO] [stderr] Checking actix-web v0.7.4 [INFO] [stderr] Checking jmaker-local-network-agent v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `Error` [INFO] [stderr] --> src/main.rs:11:25 [INFO] [stderr] | [INFO] [stderr] 11 | use serde_json::{Value, Error}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:134:5 [INFO] [stderr] | [INFO] [stderr] 134 | ips [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:126:15 [INFO] [stderr] | [INFO] [stderr] 126 | let ips = interface.iter() [INFO] [stderr] | _______________^ [INFO] [stderr] 127 | | .map(|object| { [INFO] [stderr] 128 | | [INFO] [stderr] 129 | | object["address"].as_str().unwrap().to_string() [INFO] [stderr] 130 | | [INFO] [stderr] 131 | | }) [INFO] [stderr] 132 | | .collect::>(); [INFO] [stderr] | |_________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `Error` [INFO] [stderr] --> src/main.rs:11:25 [INFO] [stderr] | [INFO] [stderr] 11 | use serde_json::{Value, Error}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:134:5 [INFO] [stderr] | [INFO] [stderr] 134 | ips [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:126:15 [INFO] [stderr] | [INFO] [stderr] 126 | let ips = interface.iter() [INFO] [stderr] | _______________^ [INFO] [stderr] 127 | | .map(|object| { [INFO] [stderr] 128 | | [INFO] [stderr] 129 | | object["address"].as_str().unwrap().to_string() [INFO] [stderr] 130 | | [INFO] [stderr] 131 | | }) [INFO] [stderr] 132 | | .collect::>(); [INFO] [stderr] | |_________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:78:20 [INFO] [stderr] | [INFO] [stderr] 78 | if val < &now { reserved.remove(key); } [INFO] [stderr] | ^^^^^^---- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `now` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:155:27 [INFO] [stderr] | [INFO] [stderr] 155 | Some(time) if time >= &now => { [INFO] [stderr] | ^^^^^^^^---- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `now` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:78:20 [INFO] [stderr] | [INFO] [stderr] 78 | if val < &now { reserved.remove(key); } [INFO] [stderr] | ^^^^^^---- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `now` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:155:27 [INFO] [stderr] | [INFO] [stderr] 155 | Some(time) if time >= &now => { [INFO] [stderr] | ^^^^^^^^---- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `now` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 28s [INFO] running `"docker" "inspect" "35dea477591c79f88df336a5608a2a8ec15dfbfe6d8e1832045f6c9b7610ea8b"` [INFO] running `"docker" "rm" "-f" "35dea477591c79f88df336a5608a2a8ec15dfbfe6d8e1832045f6c9b7610ea8b"` [INFO] [stdout] 35dea477591c79f88df336a5608a2a8ec15dfbfe6d8e1832045f6c9b7610ea8b