[INFO] updating cached repository jafow/pals [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jafow/pals [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jafow/pals" "work/ex/clippy-test-run/sources/stable/gh/jafow/pals"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jafow/pals'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jafow/pals" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jafow/pals"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jafow/pals'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 78874709150ef8b88cffe0c28bd92291dc5c9422 [INFO] sha for GitHub repo jafow/pals: 78874709150ef8b88cffe0c28bd92291dc5c9422 [INFO] validating manifest of jafow/pals on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jafow/pals on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jafow/pals [INFO] finished frobbing jafow/pals [INFO] frobbed toml for jafow/pals written to work/ex/clippy-test-run/sources/stable/gh/jafow/pals/Cargo.toml [INFO] started frobbing jafow/pals [INFO] finished frobbing jafow/pals [INFO] frobbed toml for jafow/pals written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jafow/pals/Cargo.toml [INFO] crate jafow/pals has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jafow/pals against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jafow/pals:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 112f0861dbf485c42b3f146be843932cd29cdf22b49493ebeba615ed0c980b7d [INFO] running `"docker" "start" "-a" "112f0861dbf485c42b3f146be843932cd29cdf22b49493ebeba615ed0c980b7d"` [INFO] [stderr] Compiling rust-crypto v0.2.36 [INFO] [stderr] Checking pals v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: function is never used: `cycle_bytes` [INFO] [stderr] --> src/xor.rs:49:1 [INFO] [stderr] | [INFO] [stderr] 49 | fn cycle_bytes(slice_len: u8, bytes: &[u8]) -> Vec<&u8> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/xor.rs:61:40 [INFO] [stderr] | [INFO] [stderr] 61 | fn fill_bytes(slice_len: usize, _char: &u8) -> Vec { [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/xor.rs:61:40 [INFO] [stderr] | [INFO] [stderr] 61 | fn fill_bytes(slice_len: usize, _char: &u8) -> Vec { [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.14s [INFO] running `"docker" "inspect" "112f0861dbf485c42b3f146be843932cd29cdf22b49493ebeba615ed0c980b7d"` [INFO] running `"docker" "rm" "-f" "112f0861dbf485c42b3f146be843932cd29cdf22b49493ebeba615ed0c980b7d"` [INFO] [stdout] 112f0861dbf485c42b3f146be843932cd29cdf22b49493ebeba615ed0c980b7d