[INFO] updating cached repository jaemk/transfer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jaemk/transfer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jaemk/transfer" "work/ex/clippy-test-run/sources/stable/gh/jaemk/transfer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jaemk/transfer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jaemk/transfer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jaemk/transfer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jaemk/transfer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0f5c115ef3a258676342ed32fab84b869315487e [INFO] sha for GitHub repo jaemk/transfer: 0f5c115ef3a258676342ed32fab84b869315487e [INFO] validating manifest of jaemk/transfer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jaemk/transfer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jaemk/transfer [INFO] finished frobbing jaemk/transfer [INFO] frobbed toml for jaemk/transfer written to work/ex/clippy-test-run/sources/stable/gh/jaemk/transfer/Cargo.toml [INFO] started frobbing jaemk/transfer [INFO] finished frobbing jaemk/transfer [INFO] frobbed toml for jaemk/transfer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jaemk/transfer/Cargo.toml [INFO] crate jaemk/transfer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jaemk/transfer against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jaemk/transfer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 81bab7447ef9b2f6a86f5b290dba9ccfcef73ee773310813db8c1667eea1b993 [INFO] running `"docker" "start" "-a" "81bab7447ef9b2f6a86f5b290dba9ccfcef73ee773310813db8c1667eea1b993"` [INFO] [stderr] Checking fallible-iterator v0.1.6 [INFO] [stderr] Compiling serde v1.0.82 [INFO] [stderr] Checking block-buffer v0.3.3 [INFO] [stderr] Checking base64 v0.6.0 [INFO] [stderr] Checking stringprep v0.1.2 [INFO] [stderr] Checking rand v0.4.3 [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking socket2 v0.3.8 [INFO] [stderr] Checking filetime v0.2.4 [INFO] [stderr] Checking twoway v0.1.8 [INFO] [stderr] Checking threadpool v1.7.1 [INFO] [stderr] Checking digest v0.7.6 [INFO] [stderr] Compiling syn v0.15.23 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking gzip-header v0.2.0 [INFO] [stderr] Checking buf_redux v0.6.3 [INFO] [stderr] Checking error-chain v0.12.0 [INFO] [stderr] Checking hmac v0.5.0 [INFO] [stderr] Checking sha2 v0.7.1 [INFO] [stderr] Checking env_logger v0.6.0 [INFO] [stderr] Compiling mime_guess v1.8.6 [INFO] [stderr] Checking deflate v0.7.19 [INFO] [stderr] Checking rand v0.3.22 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Checking postgres-protocol v0.3.2 [INFO] [stderr] Checking uuid v0.5.1 [INFO] [stderr] Checking rust-crypto v0.2.36 [INFO] [stderr] Checking tiny_http v0.6.0 [INFO] [stderr] Checking postgres-shared v0.4.2 [INFO] [stderr] Checking multipart v0.13.6 [INFO] [stderr] Compiling serde_derive v1.0.82 [INFO] [stderr] Checking postgres v0.15.2 [INFO] [stderr] Checking r2d2_postgres v0.14.0 [INFO] [stderr] Checking toml v0.4.10 [INFO] [stderr] Checking serde_json v1.0.33 [INFO] [stderr] Checking serde_urlencoded v0.5.4 [INFO] [stderr] Checking ron v0.4.0 [INFO] [stderr] Checking migrant_lib v0.21.0 [INFO] [stderr] Checking rouille v2.2.0 [INFO] [stderr] Checking transfer v0.4.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handlers.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | deletion_password: deletion_password, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `deletion_password` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handlers.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | expire_date: expire_date, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `expire_date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handlers.rs:121:13 [INFO] [stderr] | [INFO] [stderr] 121 | uuid: uuid, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `uuid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handlers.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | deletion_password: deletion_password, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `deletion_password` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handlers.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | expire_date: expire_date, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `expire_date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handlers.rs:121:13 [INFO] [stderr] | [INFO] [stderr] 121 | uuid: uuid, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `uuid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/handlers.rs:175:9 [INFO] [stderr] | [INFO] [stderr] 175 | upload [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/handlers.rs:174:22 [INFO] [stderr] | [INFO] [stderr] 174 | let upload = new_upload.insert(&trans)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/handlers.rs:175:9 [INFO] [stderr] | [INFO] [stderr] 175 | upload [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/handlers.rs:174:22 [INFO] [stderr] | [INFO] [stderr] 174 | let upload = new_upload.insert(&trans)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 45 [INFO] [stderr] --> src/service.rs:119:1 [INFO] [stderr] | [INFO] [stderr] 119 | / fn route_request(request: &rouille::Request, db_pool: db::Pool) -> Result { [INFO] [stderr] 120 | | Ok(router!(request, [INFO] [stderr] 121 | | (GET) (/) => { [INFO] [stderr] 122 | | handlers::serve_file("text/html", "assets/main.html")? [INFO] [stderr] ... | [INFO] [stderr] 146 | | )) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/sweep.rs:87:38 [INFO] [stderr] | [INFO] [stderr] 87 | if file_name.starts_with(".") { continue; } [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:111:53 [INFO] [stderr] | [INFO] [stderr] 111 | pub fn find(conn: &T, id: &i32) -> Result { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 45 [INFO] [stderr] --> src/service.rs:119:1 [INFO] [stderr] | [INFO] [stderr] 119 | / fn route_request(request: &rouille::Request, db_pool: db::Pool) -> Result { [INFO] [stderr] 120 | | Ok(router!(request, [INFO] [stderr] 121 | | (GET) (/) => { [INFO] [stderr] 122 | | handlers::serve_file("text/html", "assets/main.html")? [INFO] [stderr] ... | [INFO] [stderr] 146 | | )) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/sweep.rs:87:38 [INFO] [stderr] | [INFO] [stderr] 87 | if file_name.starts_with(".") { continue; } [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:111:53 [INFO] [stderr] | [INFO] [stderr] 111 | pub fn find(conn: &T, id: &i32) -> Result { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:81:12 [INFO] [stderr] | [INFO] [stderr] 81 | if let Some(_) = matches.subcommand_matches("config-dir") { [INFO] [stderr] | _____- ^^^^^^^ [INFO] [stderr] 82 | | println!("{}", transfer::config_dir()?.display()); [INFO] [stderr] 83 | | return Ok(()) [INFO] [stderr] 84 | | } [INFO] [stderr] | |_____- help: try this: `if matches.subcommand_matches("config-dir").is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/main.rs:136:17 [INFO] [stderr] | [INFO] [stderr] 136 | let _ = res?; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:144:12 [INFO] [stderr] | [INFO] [stderr] 144 | if let Some(_) = matches.subcommand_matches("sweep-files") { [INFO] [stderr] | _____- ^^^^^^^ [INFO] [stderr] 145 | | transfer::admin::sweep_files()?; [INFO] [stderr] 146 | | return Ok(()) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_____- help: try this: `if matches.subcommand_matches("sweep-files").is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:81:12 [INFO] [stderr] | [INFO] [stderr] 81 | if let Some(_) = matches.subcommand_matches("config-dir") { [INFO] [stderr] | _____- ^^^^^^^ [INFO] [stderr] 82 | | println!("{}", transfer::config_dir()?.display()); [INFO] [stderr] 83 | | return Ok(()) [INFO] [stderr] 84 | | } [INFO] [stderr] | |_____- help: try this: `if matches.subcommand_matches("config-dir").is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/main.rs:136:17 [INFO] [stderr] | [INFO] [stderr] 136 | let _ = res?; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:144:12 [INFO] [stderr] | [INFO] [stderr] 144 | if let Some(_) = matches.subcommand_matches("sweep-files") { [INFO] [stderr] | _____- ^^^^^^^ [INFO] [stderr] 145 | | transfer::admin::sweep_files()?; [INFO] [stderr] 146 | | return Ok(()) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_____- help: try this: `if matches.subcommand_matches("sweep-files").is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 20s [INFO] running `"docker" "inspect" "81bab7447ef9b2f6a86f5b290dba9ccfcef73ee773310813db8c1667eea1b993"` [INFO] running `"docker" "rm" "-f" "81bab7447ef9b2f6a86f5b290dba9ccfcef73ee773310813db8c1667eea1b993"` [INFO] [stdout] 81bab7447ef9b2f6a86f5b290dba9ccfcef73ee773310813db8c1667eea1b993