[INFO] updating cached repository jaemk/transfer-cli [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jaemk/transfer-cli [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jaemk/transfer-cli" "work/ex/clippy-test-run/sources/stable/gh/jaemk/transfer-cli"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jaemk/transfer-cli'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jaemk/transfer-cli" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jaemk/transfer-cli"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jaemk/transfer-cli'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6f954b849e182846abea997714d30c5ab15d1ea5 [INFO] sha for GitHub repo jaemk/transfer-cli: 6f954b849e182846abea997714d30c5ab15d1ea5 [INFO] validating manifest of jaemk/transfer-cli on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jaemk/transfer-cli on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jaemk/transfer-cli [INFO] finished frobbing jaemk/transfer-cli [INFO] frobbed toml for jaemk/transfer-cli written to work/ex/clippy-test-run/sources/stable/gh/jaemk/transfer-cli/Cargo.toml [INFO] started frobbing jaemk/transfer-cli [INFO] finished frobbing jaemk/transfer-cli [INFO] frobbed toml for jaemk/transfer-cli written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jaemk/transfer-cli/Cargo.toml [INFO] crate jaemk/transfer-cli has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jaemk/transfer-cli against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jaemk/transfer-cli:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ede34c054886fb55ee1fe055cba4ea948775f5e5359a68b97e3d20413db39be5 [INFO] running `"docker" "start" "-a" "ede34c054886fb55ee1fe055cba4ea948775f5e5359a68b97e3d20413db39be5"` [INFO] [stderr] Compiling openssl v0.9.17 [INFO] [stderr] Compiling libc v0.2.30 [INFO] [stderr] Compiling backtrace-sys v0.1.12 [INFO] [stderr] Checking rpassword v1.0.2 [INFO] [stderr] Checking futures-cpupool v0.1.6 [INFO] [stderr] Checking pbr v1.0.0 [INFO] [stderr] Checking mime v0.3.3 [INFO] [stderr] Checking hyper v0.11.2 [INFO] [stderr] Compiling num_cpus v1.6.2 [INFO] [stderr] Compiling rand v0.3.16 [INFO] [stderr] Compiling rayon-core v1.2.1 [INFO] [stderr] Compiling rayon v0.8.2 [INFO] [stderr] Checking native-tls v0.1.4 [INFO] [stderr] Checking tokio-tls v0.1.3 [INFO] [stderr] Checking hyper-tls v0.1.2 [INFO] [stderr] Compiling ring v0.12.1 [INFO] [stderr] Checking reqwest v0.7.3 [INFO] [stderr] Checking backtrace v0.3.3 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking transfer v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:27:22 [INFO] [stderr] | [INFO] [stderr] 27 | pub const APP_NAME: &'static str = "Transfer"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:28:25 [INFO] [stderr] | [INFO] [stderr] 28 | pub const APP_VERSION: &'static str = crate_version!(); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:338:5 [INFO] [stderr] | [INFO] [stderr] 338 | / if exists { [INFO] [stderr] 339 | | if prompt("Destination file already exists. Overwrite? [y/n] ")? != "y" { [INFO] [stderr] 340 | | println!("Looking for an available file-path since the download may no longer be available..."); [INFO] [stderr] 341 | | let mut n = 1; [INFO] [stderr] ... | [INFO] [stderr] 358 | | } [INFO] [stderr] 359 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 338 | if exists && prompt("Destination file already exists. Overwrite? [y/n] ")? != "y" { [INFO] [stderr] 339 | println!("Looking for an available file-path since the download may no longer be available..."); [INFO] [stderr] 340 | let mut n = 1; [INFO] [stderr] 341 | loop { [INFO] [stderr] 342 | let new_file_name = out_path.file_name() [INFO] [stderr] 343 | .and_then(std::ffi::OsStr::to_str) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:27:22 [INFO] [stderr] | [INFO] [stderr] 27 | pub const APP_NAME: &'static str = "Transfer"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:28:25 [INFO] [stderr] | [INFO] [stderr] 28 | pub const APP_VERSION: &'static str = crate_version!(); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:338:5 [INFO] [stderr] | [INFO] [stderr] 338 | / if exists { [INFO] [stderr] 339 | | if prompt("Destination file already exists. Overwrite? [y/n] ")? != "y" { [INFO] [stderr] 340 | | println!("Looking for an available file-path since the download may no longer be available..."); [INFO] [stderr] 341 | | let mut n = 1; [INFO] [stderr] ... | [INFO] [stderr] 358 | | } [INFO] [stderr] 359 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 338 | if exists && prompt("Destination file already exists. Overwrite? [y/n] ")? != "y" { [INFO] [stderr] 339 | println!("Looking for an available file-path since the download may no longer be available..."); [INFO] [stderr] 340 | let mut n = 1; [INFO] [stderr] 341 | loop { [INFO] [stderr] 342 | let new_file_name = out_path.file_name() [INFO] [stderr] 343 | .and_then(std::ffi::OsStr::to_str) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/crypto.rs:30:16 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn encrypt<'a>(bytes: &[u8], nonce: &[u8], pass: &[u8]) -> Result> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/crypto.rs:30:16 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn encrypt<'a>(bytes: &[u8], nonce: &[u8], pass: &[u8]) -> Result> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/main.rs:140:43 [INFO] [stderr] | [INFO] [stderr] 140 | fn prompt_passwords(with_delete: bool) -> Result<(Vec, Vec, Option>)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/main.rs:140:43 [INFO] [stderr] | [INFO] [stderr] 140 | fn prompt_passwords(with_delete: bool) -> Result<(Vec, Vec, Option>)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/main.rs:210:18 [INFO] [stderr] | [INFO] [stderr] 210 | .or(defaults.download_limit_default.map(|s| s.to_string())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| defaults.download_limit_default.map(|s| s.to_string()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/main.rs:210:18 [INFO] [stderr] | [INFO] [stderr] 210 | .or(defaults.download_limit_default.map(|s| s.to_string())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| defaults.download_limit_default.map(|s| s.to_string()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: The function/method `status` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:299:18 [INFO] [stderr] | [INFO] [stderr] 299 | unwrap_resp!(&mut bytes_resp); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `status` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:299:18 [INFO] [stderr] | [INFO] [stderr] 299 | unwrap_resp!(&mut bytes_resp); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `status` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:299:18 [INFO] [stderr] | [INFO] [stderr] 299 | unwrap_resp!(&mut bytes_resp); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `status` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:299:18 [INFO] [stderr] | [INFO] [stderr] 299 | unwrap_resp!(&mut bytes_resp); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 42.62s [INFO] running `"docker" "inspect" "ede34c054886fb55ee1fe055cba4ea948775f5e5359a68b97e3d20413db39be5"` [INFO] running `"docker" "rm" "-f" "ede34c054886fb55ee1fe055cba4ea948775f5e5359a68b97e3d20413db39be5"` [INFO] [stdout] ede34c054886fb55ee1fe055cba4ea948775f5e5359a68b97e3d20413db39be5