[INFO] updating cached repository jaemk/rok [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jaemk/rok [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jaemk/rok" "work/ex/clippy-test-run/sources/stable/gh/jaemk/rok"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jaemk/rok'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jaemk/rok" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jaemk/rok"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jaemk/rok'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 01e5e25ded1ecad283c329d12686c039eaf2f06b [INFO] sha for GitHub repo jaemk/rok: 01e5e25ded1ecad283c329d12686c039eaf2f06b [INFO] validating manifest of jaemk/rok on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jaemk/rok on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jaemk/rok [INFO] finished frobbing jaemk/rok [INFO] frobbed toml for jaemk/rok written to work/ex/clippy-test-run/sources/stable/gh/jaemk/rok/Cargo.toml [INFO] started frobbing jaemk/rok [INFO] finished frobbing jaemk/rok [INFO] frobbed toml for jaemk/rok written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jaemk/rok/Cargo.toml [INFO] crate jaemk/rok has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jaemk/rok against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jaemk/rok:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 41487b81d8d67a1bcfcf5376f52d347778154eab5904a69a17b6c65bad880c96 [INFO] running `"docker" "start" "-a" "41487b81d8d67a1bcfcf5376f52d347778154eab5904a69a17b6c65bad880c96"` [INFO] [stderr] Checking either v1.3.0 [INFO] [stderr] Checking num-bigint v0.1.40 [INFO] [stderr] Checking rustyline v1.0.0 [INFO] [stderr] Checking itertools v0.7.2 [INFO] [stderr] Checking num-rational v0.1.39 [INFO] [stderr] Checking num v0.1.40 [INFO] [stderr] Checking rok v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/token.rs:118:17 [INFO] [stderr] | [INFO] [stderr] 118 | write!(f, ",\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/token.rs:118:17 [INFO] [stderr] | [INFO] [stderr] 118 | write!(f, ",\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/lib.rs:40:20 [INFO] [stderr] | [INFO] [stderr] 40 | let path = env::home_dir().unwrap_or_else(|| path::PathBuf::from(".")); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/lib.rs:40:20 [INFO] [stderr] | [INFO] [stderr] 40 | let path = env::home_dir().unwrap_or_else(|| path::PathBuf::from(".")); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `tokens` [INFO] [stderr] --> src/lib.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn eval(tokens: &[Token]) -> Result<()> { [INFO] [stderr] | ^^^^^^ help: consider using `_tokens` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `tokens` [INFO] [stderr] --> src/lib.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn eval(tokens: &[Token]) -> Result<()> { [INFO] [stderr] | ^^^^^^ help: consider using `_tokens` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `token::TokenStream` [INFO] [stderr] --> src/token.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | / pub fn new() -> Self { [INFO] [stderr] 97 | | TokenStream(vec![]) [INFO] [stderr] 98 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 94 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/token.rs:173:36 [INFO] [stderr] | [INFO] [stderr] 173 | while let Some(next) = source.next() { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `for next in source { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/token.rs:185:36 [INFO] [stderr] | [INFO] [stderr] 185 | while let Some(next) = source.next() { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `for next in source { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/token.rs:307:62 [INFO] [stderr] | [INFO] [stderr] 307 | (Comment, comment.trim_right_matches("\n").to_owned()) [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/token.rs:317:48 [INFO] [stderr] | [INFO] [stderr] 317 | (Str, s.trim_right_matches("\"").to_owned()) [INFO] [stderr] | ^^^^ help: try using a char instead: `'\"'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/token.rs:322:48 [INFO] [stderr] | [INFO] [stderr] 322 | (Str, s.trim_right_matches("\'").to_owned()) [INFO] [stderr] | ^^^^ help: try using a char instead: `'\''` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Repl` [INFO] [stderr] --> src/lib.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | / pub fn new() -> Self { [INFO] [stderr] 33 | | Self { [INFO] [stderr] 34 | | save_history: false, [INFO] [stderr] 35 | | history_path: None, [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 27 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `token::TokenStream` [INFO] [stderr] --> src/token.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | / pub fn new() -> Self { [INFO] [stderr] 97 | | TokenStream(vec![]) [INFO] [stderr] 98 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 94 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/token.rs:173:36 [INFO] [stderr] | [INFO] [stderr] 173 | while let Some(next) = source.next() { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `for next in source { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/token.rs:185:36 [INFO] [stderr] | [INFO] [stderr] 185 | while let Some(next) = source.next() { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `for next in source { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/token.rs:307:62 [INFO] [stderr] | [INFO] [stderr] 307 | (Comment, comment.trim_right_matches("\n").to_owned()) [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/token.rs:317:48 [INFO] [stderr] | [INFO] [stderr] 317 | (Str, s.trim_right_matches("\"").to_owned()) [INFO] [stderr] | ^^^^ help: try using a char instead: `'\"'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/token.rs:322:48 [INFO] [stderr] | [INFO] [stderr] 322 | (Str, s.trim_right_matches("\'").to_owned()) [INFO] [stderr] | ^^^^ help: try using a char instead: `'\''` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Repl` [INFO] [stderr] --> src/lib.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | / pub fn new() -> Self { [INFO] [stderr] 33 | | Self { [INFO] [stderr] 34 | | save_history: false, [INFO] [stderr] 35 | | history_path: None, [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 27 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.84s [INFO] running `"docker" "inspect" "41487b81d8d67a1bcfcf5376f52d347778154eab5904a69a17b6c65bad880c96"` [INFO] running `"docker" "rm" "-f" "41487b81d8d67a1bcfcf5376f52d347778154eab5904a69a17b6c65bad880c96"` [INFO] [stdout] 41487b81d8d67a1bcfcf5376f52d347778154eab5904a69a17b6c65bad880c96